From: Eric Dumazet <eric.dumazet@gmail.com>
To: Kirill Tkhai <ktkhai@virtuozzo.com>,
davem@davemloft.net, yoshfuji@linux-ipv6.org,
netdev@vger.kernel.org
Cc: Yuval Mintz <yuvalm@mellanox.com>
Subject: Re: [PATCH RESEND net-next] net: Do synchronize_rcu() in ip6mr_sk_done() only if this is needed
Date: Tue, 06 Mar 2018 08:58:53 -0800 [thread overview]
Message-ID: <1520355533.109662.24.camel@gmail.com> (raw)
In-Reply-To: <1520355021.109662.22.camel@gmail.com>
On Tue, 2018-03-06 at 08:50 -0800, Eric Dumazet wrote:
>
> But... what is this synchronize_rcu() doing exactly ?
>
> This was added in 8571ab479a6e1ef46ead5ebee567e128a422767c
>
> ("ip6mr: Make mroute_sk rcu-based")
>
> Typically on a delete, the synchronize_rcu() would be needed before
> freeing the deleted object.
>
> But nowadays we have better way : SOCK_RCU_FREE
To be clear, your patch is fine Kirill,
I am only sad seeing one can add a synchronize_rcu() in hot path
without anyone complaining during code review.
Reviewed-by: Eric Dumazet <edumazet@google.com>
next prev parent reply other threads:[~2018-03-06 16:58 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-06 16:24 [PATCH RESEND net-next] net: Do synchronize_rcu() in ip6mr_sk_done() only if this is needed Kirill Tkhai
2018-03-06 16:50 ` Eric Dumazet
2018-03-06 16:58 ` Eric Dumazet [this message]
2018-03-06 17:20 ` Eric Dumazet
2018-03-07 9:22 ` Kirill Tkhai
2018-03-07 9:32 ` Kirill Tkhai
2018-03-07 13:51 ` Yuval Mintz
2018-03-07 14:22 ` Eric Dumazet
2018-03-07 16:43 ` [PATCH net-next] ip6mr: remove synchronize_rcu() in favor of SOCK_RCU_FREE Eric Dumazet
2018-03-07 22:11 ` Kirill Tkhai
2018-03-07 23:14 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1520355533.109662.24.camel@gmail.com \
--to=eric.dumazet@gmail.com \
--cc=davem@davemloft.net \
--cc=ktkhai@virtuozzo.com \
--cc=netdev@vger.kernel.org \
--cc=yoshfuji@linux-ipv6.org \
--cc=yuvalm@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.