From mboxrd@z Thu Jan 1 00:00:00 1970 From: Joe Perches Subject: Re: linux-next: Signed-off-by missing for commit in the rdma-fixes tree Date: Thu, 08 Mar 2018 08:39:38 -0800 Message-ID: <1520527178.11634.9.camel@perches.com> References: <20180308164058.2ad5a158@canb.auug.org.au> <20180308161845.GC6773@mellanox.com> Mime-Version: 1.0 Content-Type: text/plain; charset="ISO-8859-1" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180308161845.GC6773@mellanox.com> Sender: linux-kernel-owner@vger.kernel.org To: Jason Gunthorpe , Stephen Rothwell , Andy Whitcroft Cc: Doug Ledford , Linux-Next Mailing List , Linux Kernel Mailing List , Leon Romanovsky List-Id: linux-next.vger.kernel.org On Thu, 2018-03-08 at 09:18 -0700, Jason Gunthorpe wrote: > On Thu, Mar 08, 2018 at 04:40:58PM +1100, Stephen Rothwell wrote: > > Hi all, > > > > Commit > > > > aa0de36a40f4 ("RDMA/mlx5: Fix integer overflow while resizing CQ") > > > > is missing a Signed-off-by from its author. > > Thanks Stephen, > > May I suggest to the checkpatch maintainers that checkpack should look > for this too? No such commit in current -hext $ git status HEAD HEAD detached at next-20180308 checkpatch doesn't try to match email sender to sign-off as the email sender doesn't have to sign-off on a patch. It currently does: if ($is_patch && $has_commit_log && $chk_signoff && $signoff == 0) { ERROR("MISSING_SIGN_OFF", "Missing Signed-off-by: line(s)\n"); }