diff for duplicates of <1520546740.3605.124.camel@linux.vnet.ibm.com> diff --git a/a/1.txt b/N1/1.txt index 7ec515e..c083b07 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -25,7 +25,7 @@ On Thu, 2018-03-08 at 14:45 -0700, Tycho Andersen wrote: > > > rc = 0; > > > > Only when IMA-appraisal is enforcing file data integrity should -> > process_measurement() ever fail. Other errors can be logged/audited. +> > process_measurement() ever fail. Other errors can be logged/audited. > > Ok, so previously in ima_audit_measurement() when allocation failed, > there was nothing logged. If we just keep this behavior like below, @@ -33,13 +33,13 @@ On Thu, 2018-03-08 at 14:45 -0700, Tycho Andersen wrote: Before the IMA locking change that were just upstreamed, there were problems with measuring/appraising files that were opened with the -O_DIRECT flag. Unless the IMA policy specified permit_directio, the -measurement/appraisal failed. With the new locking, opening files -with the O_DIRECTIO flag shouldn't be a problem. It just needs to be +O_DIRECT flag. Unless the IMA policy specified permit_directio, the +measurement/appraisal failed. With the new locking, opening files +with the O_DIRECTIO flag shouldn't be a problem. It just needs to be fully tested before removing this code. On failure, the code below tests the ima_audit_measurement() result -and skips the IMA_PERMIT_DIRECTIO test. Unless I'm missing something, +and skips the IMA_PERMIT_DIRECTIO test. Unless I'm missing something, I don't see the point. Mimi diff --git a/a/content_digest b/N1/content_digest index cc56538..b27439d 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -38,7 +38,7 @@ "> > > \t\trc = 0;\n" "> > \n" "> > Only when IMA-appraisal is enforcing file data integrity should\n" - "> > process_measurement() ever fail. \302\240Other errors can be logged/audited.\n" + "> > process_measurement() ever fail. Other errors can be logged/audited.\n" "> \n" "> Ok, so previously in ima_audit_measurement() when allocation failed,\n" "> there was nothing logged. If we just keep this behavior like below,\n" @@ -46,13 +46,13 @@ "\n" "Before the IMA locking change that were just upstreamed, there were\n" "problems with measuring/appraising files that were opened with the\n" - "O_DIRECT flag. \302\240Unless the IMA policy specified permit_directio, the\n" - "measurement/appraisal failed. \302\240With the new locking, opening files\n" - "with the O_DIRECTIO flag shouldn't be a problem. \302\240It just needs to be\n" + "O_DIRECT flag. Unless the IMA policy specified permit_directio, the\n" + "measurement/appraisal failed. With the new locking, opening files\n" + "with the O_DIRECTIO flag shouldn't be a problem. It just needs to be\n" "fully tested before removing this code.\n" "\n" "On failure, the code below tests the ima_audit_measurement() result\n" - "and skips the IMA_PERMIT_DIRECTIO test. \302\240Unless I'm missing something,\n" + "and skips the IMA_PERMIT_DIRECTIO test. Unless I'm missing something,\n" "I don't see the point.\n" "\n" "Mimi\n" @@ -84,4 +84,4 @@ "> \tif ((file->f_flags & O_DIRECT) && (iint->flags & IMA_PERMIT_DIRECTIO))\n" > -452943e49b9882d138574f2d3f07113129c85a45844e5cce1386b046deadbad4 +b28b6a54f9664ed77c264bde3e224c2f369f91b72e966f2d8389e6d4fc736aa2
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.