From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from galahad.ideasonboard.com ([185.26.127.97]:34663 "EHLO galahad.ideasonboard.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751936AbdAKWql (ORCPT ); Wed, 11 Jan 2017 17:46:41 -0500 From: Laurent Pinchart To: dri-devel@lists.freedesktop.org Cc: Thierry Reding , linux-renesas-soc@vger.kernel.org, Tomi Valkeinen , Laurent Pinchart Subject: Re: [PATCH v2 06/13] drm: panels: Add LVDS panel driver Date: Thu, 12 Jan 2017 00:46:09 +0200 Message-ID: <1520553.AzMTRoXz5E@avalon> In-Reply-To: <3357569.dBCZ3D9MU7@avalon> References: <1479526093-7014-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> <20161122111457.GC22735@ulmo.ba.sec> <3357569.dBCZ3D9MU7@avalon> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Sender: linux-renesas-soc-owner@vger.kernel.org List-ID: Hi Thierry, Ping ? On Tuesday 22 Nov 2016 15:17:09 Laurent Pinchart wrote: > On Tuesday 22 Nov 2016 12:14:57 Thierry Reding wrote: > > On Sat, Nov 19, 2016 at 05:28:06AM +0200, Laurent Pinchart wrote: > >> This driver supports LVDS panels that don't require device-specific > >> handling of power supplies or control signals. It implements automatic > >> backlight handling if the panel is attached to a backlight controller. > >> > >> Signed-off-by: Laurent Pinchart > >> > >> --- > >> > >> drivers/gpu/drm/panel/Kconfig | 10 ++ > >> drivers/gpu/drm/panel/Makefile | 1 + > >> drivers/gpu/drm/panel/panel-lvds.c | 284 ++++++++++++++++++++++++++++++ > >> 3 files changed, 295 insertions(+) > >> create mode 100644 drivers/gpu/drm/panel/panel-lvds.c > > > > The bulk of this is a duplicate of panel-simple.c > > Implementing the panel API should obviously be expected to produce some > quantity of similar code. > > > and it adds all the things on top that I've been repeatedly rejecting in > > the past. > > It's a good thing I haven't tried to add them to panel-simple.c then :-) -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH v2 06/13] drm: panels: Add LVDS panel driver Date: Thu, 12 Jan 2017 00:46:09 +0200 Message-ID: <1520553.AzMTRoXz5E@avalon> References: <1479526093-7014-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> <20161122111457.GC22735@ulmo.ba.sec> <3357569.dBCZ3D9MU7@avalon> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from galahad.ideasonboard.com (galahad.ideasonboard.com [IPv6:2001:4b98:dc2:45:216:3eff:febb:480d]) by gabe.freedesktop.org (Postfix) with ESMTPS id 20C356EA63 for ; Wed, 11 Jan 2017 22:45:57 +0000 (UTC) In-Reply-To: <3357569.dBCZ3D9MU7@avalon> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel@lists.freedesktop.org Cc: linux-renesas-soc@vger.kernel.org, Tomi Valkeinen , Laurent Pinchart List-Id: dri-devel@lists.freedesktop.org SGkgVGhpZXJyeSwKClBpbmcgPwoKT24gVHVlc2RheSAyMiBOb3YgMjAxNiAxNToxNzowOSBMYXVy ZW50IFBpbmNoYXJ0IHdyb3RlOgo+IE9uIFR1ZXNkYXkgMjIgTm92IDIwMTYgMTI6MTQ6NTcgVGhp ZXJyeSBSZWRpbmcgd3JvdGU6Cj4gPiBPbiBTYXQsIE5vdiAxOSwgMjAxNiBhdCAwNToyODowNkFN ICswMjAwLCBMYXVyZW50IFBpbmNoYXJ0IHdyb3RlOgo+ID4+IFRoaXMgZHJpdmVyIHN1cHBvcnRz IExWRFMgcGFuZWxzIHRoYXQgZG9uJ3QgcmVxdWlyZSBkZXZpY2Utc3BlY2lmaWMKPiA+PiBoYW5k bGluZyBvZiBwb3dlciBzdXBwbGllcyBvciBjb250cm9sIHNpZ25hbHMuIEl0IGltcGxlbWVudHMg YXV0b21hdGljCj4gPj4gYmFja2xpZ2h0IGhhbmRsaW5nIGlmIHRoZSBwYW5lbCBpcyBhdHRhY2hl ZCB0byBhIGJhY2tsaWdodCBjb250cm9sbGVyLgo+ID4+IAo+ID4+IFNpZ25lZC1vZmYtYnk6IExh dXJlbnQgUGluY2hhcnQKPiA+PiA8bGF1cmVudC5waW5jaGFydCtyZW5lc2FzQGlkZWFzb25ib2Fy ZC5jb20+Cj4gPj4gLS0tCj4gPj4gCj4gPj4gIGRyaXZlcnMvZ3B1L2RybS9wYW5lbC9LY29uZmln ICAgICAgfCAgMTAgKysKPiA+PiAgZHJpdmVycy9ncHUvZHJtL3BhbmVsL01ha2VmaWxlICAgICB8 ICAgMSArCj4gPj4gIGRyaXZlcnMvZ3B1L2RybS9wYW5lbC9wYW5lbC1sdmRzLmMgfCAyODQgKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrCj4gPj4gIDMgZmlsZXMgY2hhbmdlZCwgMjk1IGlu c2VydGlvbnMoKykKPiA+PiAgY3JlYXRlIG1vZGUgMTAwNjQ0IGRyaXZlcnMvZ3B1L2RybS9wYW5l bC9wYW5lbC1sdmRzLmMKPiA+IAo+ID4gVGhlIGJ1bGsgb2YgdGhpcyBpcyBhIGR1cGxpY2F0ZSBv ZiBwYW5lbC1zaW1wbGUuYwo+IAo+IEltcGxlbWVudGluZyB0aGUgcGFuZWwgQVBJIHNob3VsZCBv YnZpb3VzbHkgYmUgZXhwZWN0ZWQgdG8gcHJvZHVjZSBzb21lCj4gcXVhbnRpdHkgb2Ygc2ltaWxh ciBjb2RlLgo+IAo+ID4gYW5kIGl0IGFkZHMgYWxsIHRoZSB0aGluZ3Mgb24gdG9wIHRoYXQgSSd2 ZSBiZWVuIHJlcGVhdGVkbHkgcmVqZWN0aW5nIGluCj4gPiB0aGUgcGFzdC4KPiAKPiBJdCdzIGEg Z29vZCB0aGluZyBJIGhhdmVuJ3QgdHJpZWQgdG8gYWRkIHRoZW0gdG8gcGFuZWwtc2ltcGxlLmMg dGhlbiA6LSkKCi0tIApSZWdhcmRzLAoKTGF1cmVudCBQaW5jaGFydAoKX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVsIG1haWxpbmcgbGlzdApk cmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Au b3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg==