All of lore.kernel.org
 help / color / mirror / Atom feed
From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Bhargava Sreekantappa Gayathri
	<bhargava.sreekantappa-gayathri@xilinx.com>,
	openembedded-core@lists.openembedded.org, manjukum@xilinx.com
Subject: Re: [PATCH] own-mirrors.bbclass: Change prepend to append
Date: Fri, 09 Mar 2018 05:26:48 -0800	[thread overview]
Message-ID: <1520602008.10851.102.camel@linuxfoundation.org> (raw)
In-Reply-To: <1520560178-31053-1-git-send-email-bhargava.sreekantappa-gayathri@xilinx.com>

On Thu, 2018-03-08 at 17:49 -0800, Bhargava Sreekantappa Gayathri
wrote:
> If BB_NO_NETWORK is set to 1, and local download directory is added
> as
> PREMIRRORS_prepend in conf file, PREMIRRORS variable will have
> SOURCE_MIRROR_URL as the first url. This causes build to fail as
> network
> access is diabled. PREMIRRORS should be appended here so that a
> prepend
> in other layers/conf files takes precedence.
> 
> Signed-off-by: Bhargava Sreekantappa Gayathri <bhargava.sreekantappa-
> gayathri@xilinx.com>
> Signed-off-by: Manjukumar Matha <manjukumar.harthikote-matha@xilinx.c
> om>
> ---
>  meta/classes/own-mirrors.bbclass | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)

I think this patch just moves the problem, you could easily have a
file:/// url as SOURCE_MIRROR_URL and a network address in your other
layer in which case your patch would break things...

Cheers,

Richard


  reply	other threads:[~2018-03-09 13:26 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-09  1:49 [PATCH] own-mirrors.bbclass: Change prepend to append Bhargava Sreekantappa Gayathri
2018-03-09 13:26 ` Richard Purdie [this message]
2018-03-09 17:56   ` Manjukumar Harthikote Matha
2018-03-09 19:04     ` Richard Purdie
2018-03-20 20:26     ` Bhargava Sreekantappa Gayathri
  -- strict thread matches above, loose matches on Subject: below --
2018-03-09  1:54 Bhargava Sreekantappa Gayathri
2018-03-09  1:06 Bhargava Sreekantappa Gayathri

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1520602008.10851.102.camel@linuxfoundation.org \
    --to=richard.purdie@linuxfoundation.org \
    --cc=bhargava.sreekantappa-gayathri@xilinx.com \
    --cc=manjukum@xilinx.com \
    --cc=openembedded-core@lists.openembedded.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.