From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: Harish Jenny K N <harish_kandiga@mentor.com>,
Avri Altman <Avri.Altman@wdc.com>,
"ulf.hansson@linaro.org" <ulf.hansson@linaro.org>,
"linus.walleij@linaro.org" <linus.walleij@linaro.org>,
"adrian.hunter@intel.com" <adrian.hunter@intel.com>,
"shawn.lin@rock-chips.com" <shawn.lin@rock-chips.com>
Cc: "linux-mmc@vger.kernel.org" <linux-mmc@vger.kernel.org>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"Vladimir_Zapolskiy@mentor.com" <Vladimir_Zapolskiy@mentor.com>
Subject: Re: [PATCH v9] mmc: Export host capabilities to debugfs.
Date: Mon, 12 Mar 2018 16:27:17 +0200 [thread overview]
Message-ID: <1520864837.10722.596.camel@linux.intel.com> (raw)
In-Reply-To: <1520864550.10722.594.camel@linux.intel.com>
On Mon, 2018-03-12 at 16:22 +0200, Andy Shevchenko wrote:
> On Mon, 2018-03-12 at 19:04 +0530, Harish Jenny K N wrote:
> >
> > On Monday 12 March 2018 06:33 PM, Andy Shevchenko wrote:
> > > On Mon, 2018-03-12 at 18:00 +0530, Harish Jenny K N wrote:
> > > > > > > > > + for_each_set_bit(bit, (const unsigned long
> > > > > > > > > *)&caps,
> > > > > > > > > BITS_PER_LONG)
> > > > > > > > > + for_each_set_bit(bit, (const unsigned long
> > > > > > > > > *)&caps2,
> > > > > > > > > BITS_PER_LONG)
> > > > > > > >
> > > > > > > > Explicit casting is not needed anymore in both cases.
> > Sorry for I was not clear that the compilation error is for the
> > following case
> > > u32 caps = host->caps;
This is wrong! I told you that and you seems changed at least in v9.
What are you doing locally?
> > > for_each_set_bit(bit, &caps, ARRAY_SIZE(mmc_host_capabilities))
> >
> Are you sure you have caps defined as unsigned long?
>
> Check your code, the explicit casting should gone. Otherwise you are
> doing something wrong.
See above.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
prev parent reply other threads:[~2018-03-12 14:27 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-12 4:31 [PATCH v9] mmc: Export host capabilities to debugfs Harish Jenny K N
2018-03-12 4:31 ` Harish Jenny K N
2018-03-12 10:07 ` Andy Shevchenko
2018-03-12 10:27 ` Harish Jenny K N
2018-03-12 10:27 ` Harish Jenny K N
2018-03-12 10:45 ` Avri Altman
2018-03-12 11:16 ` Harish Jenny K N
2018-03-12 11:32 ` Avri Altman
2018-03-12 12:30 ` Harish Jenny K N
2018-03-12 13:03 ` Andy Shevchenko
2018-03-12 13:34 ` Harish Jenny K N
2018-03-12 14:07 ` Harish Jenny K N
2018-03-12 14:20 ` Andy Shevchenko
2018-03-12 14:22 ` Andy Shevchenko
2018-03-12 14:27 ` Andy Shevchenko [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1520864837.10722.596.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=Avri.Altman@wdc.com \
--cc=Vladimir_Zapolskiy@mentor.com \
--cc=adrian.hunter@intel.com \
--cc=harish_kandiga@mentor.com \
--cc=linus.walleij@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mmc@vger.kernel.org \
--cc=shawn.lin@rock-chips.com \
--cc=ulf.hansson@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.