From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: From: "Ardelean, Alexandru" To: "jic23@jic23.retrosnub.co.uk" CC: "lars@metafoo.de" , "linux-iio@vger.kernel.org" , "Hennerich, Michael" Subject: Re: [PATCH] staging: iio: ad5933: merge ring init function into probe function Date: Tue, 13 Mar 2018 09:01:41 +0000 Message-ID: <1520931701.3300.0.camel@analog.com> References: <20180216120915.19277-1-alexandru.ardelean@analog.com> <20180224121747.6ff4b90b@archlinux> In-Reply-To: <20180224121747.6ff4b90b@archlinux> Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 List-ID: T24gU2F0LCAyMDE4LTAyLTI0IGF0IDEyOjE4ICswMDAwLCBKb25hdGhhbiBDYW1lcm9uIHdyb3Rl Og0KPiBPbiBGcmksIDE2IEZlYiAyMDE4IDE0OjA5OjE1ICswMjAwDQo+IEFsZXhhbmRydSBBcmRl bGVhbiA8YWxleGFuZHJ1LmFyZGVsZWFuQGFuYWxvZy5jb20+IHdyb3RlOg0KPiANCj4gPiBUaGlz IGlzIGEgc21hbGwgY2xlYW51cCBvZiB0aGUgZHJpdmVyJ3MgaW5pdCBjb2RlLg0KPiA+IEl0IGRv ZXMgbm90IGZpeCBhbnl0aGluZy4NCj4gPiANCj4gPiBUaGUgYGRldm1faWlvX2tmaWZvX2FsbG9j YXRlKClgIGZ1bmN0aW9uIGlzIHVzZWQgaW5zdGVhZCBvZg0KPiA+IGBpaW9fa2ZpZm9fYWxsb2Nh dGUoKWAuICBUaGlzIHJlbW92ZXMgdGhlIG5lZWQgZm9yIGV4cGxpY2l0IGRlYWxsb2NhdGlvbiBv Zg0KPiA+IHRoZSBkcml2ZXIncyBpaW9fYnVmZmVyLCB3aGljaCB3aWxsIG5vdyBiZSBoYW5kbGVk IHZpYQ0KPiA+IGBpaW9fZGV2aWNlX3VucmVnaXN0ZXIoKWAuDQo+ID4gDQo+ID4gVGhlIGBzZXR1 cF9vcHNgIGFzc2lnbm1lbnQgaGFzIGJlZW4gbW92ZWQgaW50byB0aGUgYGFkNTkzM19wcm9iZSgp YCBjYWxsLA0KPiA+IHNpbmNlIGl0J3MgYSBvbmUtbGluZXIuDQo+ID4gDQo+ID4gU2lnbmVkLW9m Zi1ieTogQWxleGFuZHJ1IEFyZGVsZWFuIDxhbGV4YW5kcnUuYXJkZWxlYW5AYW5hbG9nLmNvbT4N Cj4gPiAtLS0NCj4gPiANCj4gPiBOb3RlOiB0aGlzIGNoYW5nZSBpcyBiYXNlZCBvbiB0b3Agb2Yg YGZpeGVzLXRvZ3JlZy1wb3N0LXJjMWAgYnJhbmNoIHdoaWNoDQo+ID4gY29udGFpbnMgY29tbWl0 ICg3ZDJiOGU2YWFmOTogc3RhZ2luZzogaWlvOiBhZDU5MzM6IHN3aXRjaCBidWZmZXIgbW9kZSB0 bw0KPiA+IHNvZnR3YXJlKQ0KPiANCj4gSXQgd2lsbCB0YWtlIGEgZmV3IHdlZWtzIGZvciB0aGF0 IHRvIGdldCB0byBteSB0b2dyZWcgYnJhbmNoIHNvIHBsZWFzZQ0KPiBkbyByZW1pbmQgbWUgaWYg aXQgaGFzIGFuZCBJIHNlZW0gdG8gaGF2ZSBmb3Jnb3R0ZW4gdGhpcyENCj4gDQoNCldhcyB0aGlz IHN1cHBvc2VkIHRvIGdvIGludG8gb25lIG9mIHRoZSByZWNlbnQgcHVsbCByZXF1ZXN0cyA/DQpP ciBpcyB0aGlzIGZvciBhIGxhdGVyIHB1bGwgPw0KDQpBbGV4DQoNCj4gSm9uYXRoYW4NCj4gDQo+ ID4gDQo+ID4gIGRyaXZlcnMvc3RhZ2luZy9paW8vaW1wZWRhbmNlLWFuYWx5emVyL2FkNTkzMy5j IHwgMzUgKysrKysrKy0tLS0tLS0tLS0tLS0tLS0tLQ0KPiA+ICAxIGZpbGUgY2hhbmdlZCwgMTAg aW5zZXJ0aW9ucygrKSwgMjUgZGVsZXRpb25zKC0pDQo+ID4gDQo+ID4gZGlmZiAtLWdpdCBhL2Ry aXZlcnMvc3RhZ2luZy9paW8vaW1wZWRhbmNlLWFuYWx5emVyL2FkNTkzMy5jIGIvZHJpdmVycy9z dGFnaW5nL2lpby9pbXBlZGFuY2UtYW5hbHl6ZXIvYWQ1OTMzLmMNCj4gPiBpbmRleCAzYmNmNDk0 NjYzNjEuLjFjYWI2N2IzYTgxZSAxMDA2NDQNCj4gPiAtLS0gYS9kcml2ZXJzL3N0YWdpbmcvaWlv L2ltcGVkYW5jZS1hbmFseXplci9hZDU5MzMuYw0KPiA+ICsrKyBiL2RyaXZlcnMvc3RhZ2luZy9p aW8vaW1wZWRhbmNlLWFuYWx5emVyL2FkNTkzMy5jDQo+ID4gQEAgLTYzNSwyMiArNjM1LDYgQEAg c3RhdGljIGNvbnN0IHN0cnVjdCBpaW9fYnVmZmVyX3NldHVwX29wcyBhZDU5MzNfcmluZ19zZXR1 cF9vcHMgPSB7DQo+ID4gIAkucG9zdGRpc2FibGUgPSBhZDU5MzNfcmluZ19wb3N0ZGlzYWJsZSwN Cj4gPiAgfTsNCj4gPiAgDQo+ID4gLXN0YXRpYyBpbnQgYWQ1OTMzX3JlZ2lzdGVyX3JpbmdfZnVu Y3NfYW5kX2luaXQoc3RydWN0IGlpb19kZXYgKmluZGlvX2RldikNCj4gPiAtew0KPiA+IC0Jc3Ry dWN0IGlpb19idWZmZXIgKmJ1ZmZlcjsNCj4gPiAtDQo+ID4gLQlidWZmZXIgPSBpaW9fa2ZpZm9f YWxsb2NhdGUoKTsNCj4gPiAtCWlmICghYnVmZmVyKQ0KPiA+IC0JCXJldHVybiAtRU5PTUVNOw0K PiA+IC0NCj4gPiAtCWlpb19kZXZpY2VfYXR0YWNoX2J1ZmZlcihpbmRpb19kZXYsIGJ1ZmZlcik7 DQo+ID4gLQ0KPiA+IC0JLyogUmluZyBidWZmZXIgZnVuY3Rpb25zIC0gaGVyZSB0cmlnZ2VyIHNl dHVwIHJlbGF0ZWQgKi8NCj4gPiAtCWluZGlvX2Rldi0+c2V0dXBfb3BzID0gJmFkNTkzM19yaW5n X3NldHVwX29wczsNCj4gPiAtDQo+ID4gLQlyZXR1cm4gMDsNCj4gPiAtfQ0KPiA+IC0NCj4gPiAg c3RhdGljIHZvaWQgYWQ1OTMzX3dvcmsoc3RydWN0IHdvcmtfc3RydWN0ICp3b3JrKQ0KPiA+ICB7 DQo+ID4gIAlzdHJ1Y3QgYWQ1OTMzX3N0YXRlICpzdCA9IGNvbnRhaW5lcl9vZih3b3JrLA0KPiA+ IEBAIC03MTQsMTIgKzY5OCwxOSBAQCBzdGF0aWMgaW50IGFkNTkzM19wcm9iZShzdHJ1Y3QgaTJj X2NsaWVudCAqY2xpZW50LA0KPiA+ICAJaW50IHJldCwgdm9sdGFnZV91diA9IDA7DQo+ID4gIAlz dHJ1Y3QgYWQ1OTMzX3BsYXRmb3JtX2RhdGEgKnBkYXRhID0gZGV2X2dldF9wbGF0ZGF0YSgmY2xp ZW50LT5kZXYpOw0KPiA+ICAJc3RydWN0IGFkNTkzM19zdGF0ZSAqc3Q7DQo+ID4gKwlzdHJ1Y3Qg aWlvX2J1ZmZlciAqYnVmZmVyOw0KPiA+ICAJc3RydWN0IGlpb19kZXYgKmluZGlvX2RldjsNCj4g PiAgDQo+ID4gIAlpbmRpb19kZXYgPSBkZXZtX2lpb19kZXZpY2VfYWxsb2MoJmNsaWVudC0+ZGV2 LCBzaXplb2YoKnN0KSk7DQo+ID4gIAlpZiAoIWluZGlvX2RldikNCj4gPiAgCQlyZXR1cm4gLUVO T01FTTsNCj4gPiAgDQo+ID4gKwlidWZmZXIgPSBkZXZtX2lpb19rZmlmb19hbGxvY2F0ZSgmY2xp ZW50LT5kZXYpOw0KPiA+ICsJaWYgKCFidWZmZXIpDQo+ID4gKwkJcmV0dXJuIC1FTk9NRU07DQo+ ID4gKw0KPiA+ICsJaWlvX2RldmljZV9hdHRhY2hfYnVmZmVyKGluZGlvX2RldiwgYnVmZmVyKTsN Cj4gPiArDQo+ID4gIAlzdCA9IGlpb19wcml2KGluZGlvX2Rldik7DQo+ID4gIAlpMmNfc2V0X2Ns aWVudGRhdGEoY2xpZW50LCBpbmRpb19kZXYpOw0KPiA+ICAJc3QtPmNsaWVudCA9IGNsaWVudDsN Cj4gPiBAQCAtNzYzLDIzICs3NTQsMTggQEAgc3RhdGljIGludCBhZDU5MzNfcHJvYmUoc3RydWN0 IGkyY19jbGllbnQgKmNsaWVudCwNCj4gPiAgCWluZGlvX2Rldi0+bW9kZXMgPSAoSU5ESU9fQlVG RkVSX1NPRlRXQVJFIHwgSU5ESU9fRElSRUNUX01PREUpOw0KPiA+ICAJaW5kaW9fZGV2LT5jaGFu bmVscyA9IGFkNTkzM19jaGFubmVsczsNCj4gPiAgCWluZGlvX2Rldi0+bnVtX2NoYW5uZWxzID0g QVJSQVlfU0laRShhZDU5MzNfY2hhbm5lbHMpOw0KPiA+IC0NCj4gPiAtCXJldCA9IGFkNTkzM19y ZWdpc3Rlcl9yaW5nX2Z1bmNzX2FuZF9pbml0KGluZGlvX2Rldik7DQo+ID4gLQlpZiAocmV0KQ0K PiA+IC0JCWdvdG8gZXJyb3JfZGlzYWJsZV9yZWc7DQo+ID4gKwlpbmRpb19kZXYtPnNldHVwX29w cyA9ICZhZDU5MzNfcmluZ19zZXR1cF9vcHM7DQo+ID4gIA0KPiA+ICAJcmV0ID0gYWQ1OTMzX3Nl dHVwKHN0KTsNCj4gPiAgCWlmIChyZXQpDQo+ID4gLQkJZ290byBlcnJvcl91bnJlZ19yaW5nOw0K PiA+ICsJCWdvdG8gZXJyb3JfZGlzYWJsZV9yZWc7DQo+ID4gIA0KPiA+ICAJcmV0ID0gaWlvX2Rl dmljZV9yZWdpc3RlcihpbmRpb19kZXYpOw0KPiA+ICAJaWYgKHJldCkNCj4gPiAtCQlnb3RvIGVy cm9yX3VucmVnX3Jpbmc7DQo+ID4gKwkJZ290byBlcnJvcl9kaXNhYmxlX3JlZzsNCj4gPiAgDQo+ ID4gIAlyZXR1cm4gMDsNCj4gPiAgDQo+ID4gLWVycm9yX3VucmVnX3Jpbmc6DQo+ID4gLQlpaW9f a2ZpZm9fZnJlZShpbmRpb19kZXYtPmJ1ZmZlcik7DQo+ID4gIGVycm9yX2Rpc2FibGVfcmVnOg0K PiA+ICAJcmVndWxhdG9yX2Rpc2FibGUoc3QtPnJlZyk7DQo+ID4gIA0KPiA+IEBAIC03OTIsNyAr Nzc4LDYgQEAgc3RhdGljIGludCBhZDU5MzNfcmVtb3ZlKHN0cnVjdCBpMmNfY2xpZW50ICpjbGll bnQpDQo+ID4gIAlzdHJ1Y3QgYWQ1OTMzX3N0YXRlICpzdCA9IGlpb19wcml2KGluZGlvX2Rldik7 DQo+ID4gIA0KPiA+ICAJaWlvX2RldmljZV91bnJlZ2lzdGVyKGluZGlvX2Rldik7DQo+ID4gLQlp aW9fa2ZpZm9fZnJlZShpbmRpb19kZXYtPmJ1ZmZlcik7DQo+ID4gIAlyZWd1bGF0b3JfZGlzYWJs ZShzdC0+cmVnKTsNCj4gPiAgDQo+ID4gIAlyZXR1cm4gMDsNCj4gDQo+IA==