From: Richard Purdie <richard.purdie@linuxfoundation.org>
To: Robert Yang <liezhi.yang@windriver.com>,
openembedded-core@lists.openembedded.org
Subject: Re: [PATCH 7/8] populate_sdk_ext.bbclass: remove the try...finally
Date: Tue, 13 Mar 2018 07:57:09 -0700 [thread overview]
Message-ID: <1520953029.25754.7.camel@linuxfoundation.org> (raw)
In-Reply-To: <b99839985653f44516cf41291681f2f5cbf63a7e.1520911259.git.liezhi.yang@windriver.com>
On Tue, 2018-03-13 at 11:24 +0800, Robert Yang wrote:
> The "sdkbasepath + '/conf/local.conf.bak" doesn't exist when
> "oe.copy_buildsystem.check_sstate_task_list()" fails, then
> os.replace() would
> raise FileNotFoundError, which overcomes the real error. Keep the
> error status
> makes debug easier, so remove the try..finally.
I don't think this patch is quite right. If there is a failure we
*must* make sure local.conf is restored, that is important. The code
should probably keep the try/finally but make the replace conditional
on the file existing.
Cheers,
Richard
next prev parent reply other threads:[~2018-03-13 14:57 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-13 3:24 [PATCH 0/8] [rebase and resend] fixes for multilib Robert Yang
2018-03-13 3:24 ` [PATCH 1/8] populate_sdk_ext.bbclass: fix " Robert Yang
2018-03-13 3:24 ` [PATCH 2/8] staging.bbclass: staging_populate_sysroot_dir(): " Robert Yang
2018-03-13 3:24 ` [PATCH 3/8] staging.bbclass: print searched manifest when not found Robert Yang
2018-03-13 3:24 ` [PATCH 4/8] package_manager.py: reverse archs correctly Robert Yang
2018-03-13 3:24 ` [PATCH 5/8] multilib.bbclass: extend allarch recipes Robert Yang
2018-03-13 3:24 ` [PATCH 6/8] toolchain-scripts.bbclass: only install all MULTILIB_VARIANTS for image Robert Yang
2018-03-13 3:24 ` [PATCH 7/8] populate_sdk_ext.bbclass: remove the try...finally Robert Yang
2018-03-13 14:57 ` Richard Purdie [this message]
2018-03-14 3:18 ` Robert Yang
2018-03-13 3:24 ` [PATCH 8/8] staging.bbclass: extend_recipe_sysroot: fix multilib manifest Robert Yang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1520953029.25754.7.camel@linuxfoundation.org \
--to=richard.purdie@linuxfoundation.org \
--cc=liezhi.yang@windriver.com \
--cc=openembedded-core@lists.openembedded.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.