From mboxrd@z Thu Jan  1 00:00:00 1970
From: "Souza, Jose" <jose.souza@intel.com>
Subject: Re: [PATCH 2/2] drm/i915/psr: Remove open-coded PSR AUX
 transactions for SKL+
Date: Tue, 13 Mar 2018 20:46:56 +0000
Message-ID: <1520973843.1640.4.camel@intel.com>
References: <20180313034646.3721-1-dhinakaran.pandiyan@intel.com>
 <20180313034646.3721-2-dhinakaran.pandiyan@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga07.intel.com (mga07.intel.com [134.134.136.100])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 2D3EA6E603
 for <intel-gfx@lists.freedesktop.org>; Tue, 13 Mar 2018 20:46:57 +0000 (UTC)
In-Reply-To: <20180313034646.3721-2-dhinakaran.pandiyan@intel.com>
Content-Language: en-US
Content-ID: <2FEB3F032B6F0541872BD776D9E298A7@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: "intel-gfx@lists.freedesktop.org" <intel-gfx@lists.freedesktop.org>, "Pandiyan, Dhinakaran" <dhinakaran.pandiyan@intel.com>
Cc: "Vivi, Rodrigo" <rodrigo.vivi@intel.com>
List-Id: intel-gfx@lists.freedesktop.org

T24gTW9uLCAyMDE4LTAzLTEyIGF0IDIwOjQ2IC0wNzAwLCBEaGluYWthcmFuIFBhbmRpeWFuIHdy
b3RlOg0KPiBIU1cgYW5kIEJEVyBoYXZlIFNSRF9BVVhfe0NUTCwgU1RBVFVTfSByZWdpc3RlcnMg
dGhhdCB0aGUgZHJpdmVyDQo+IG5lZWRzIHRvDQo+IHNldHVwIGZvciB0aGUgSFcgdG8gdXNlIHdo
ZW5ldmVyIGV4aXRpbmcgUFNSLiBTS0wrIGhhcmR3YXJlIHVzZQ0KPiBoYXJkY29kZWQNCj4gdmFs
dWVzIGZvciB0aGUgc2FtZSBhbmQgZG8gbm90IG5lZWQgYW55IHJlZ2lzdGVycyB0byBiZSBzZXR1
cC4gU28sDQo+IHVzZQ0KPiBkcm1fZHBfZHBjZF93cml0ZWIoKSBmb3IgYSBvbmUtdGltZSB3cml0
ZSBkdXJpbmcgUFNSIGVuYWJsZSBhbmQgc2V0dXANCj4gdGhlDQo+IFBTUiBhdXggcmVnaXN0ZXJz
IG9uIEhTVyBhbmQgQkRXIGZvciBsYXRlciB1c2UgYnkgSFcuDQo+IA0KPiBXZSBhbHNvIGVuZCB1
cCB3cml0aW5nIHRvIHJlc2VydmVkIGJpdHMgaW4gU1JEX0FVWF9DVEwgYnkgcmV1c2luZw0KPiBp
bnRlbF9kcC0+Z2V0X2F1eF9zZW5kX2N0bCgpIGZvciBIU1cgYW5kIEJEVywgZml4IHRoaXMuDQo+
IA0KPiBTaW5jZSB0aGUgQVVYIHJlZ2lzdGVyIHNldHVwIGlzIHNvdXJjZSBzaWRlIHByb2dyYW1t
aW5nLCBtb3ZlIHRoZQ0KPiBjYWxsDQo+IHRvIGVuYWJsZV9zb3VyY2UoKSBmcm9tIGVuYWJsZV9z
aW5rKCkuDQo+IA0KPiBDYzogSm9zw6kgUm9iZXJ0byBkZSBTb3V6YSA8am9zZS5zb3V6YUBpbnRl
bC5jb20+DQoNClJldmlld2VkLWJ5OiBKb3NlIFJvYmVydG8gZGUgU291emEgPGpvc2Uuc291emFA
aW50ZWwuY29tPg0KDQo+IENjOiBSb2RyaWdvIFZpdmkgPHJvZHJpZ28udml2aUBpbnRlbC5jb20+
DQo+IFNpZ25lZC1vZmYtYnk6IERoaW5ha2FyYW4gUGFuZGl5YW4gPGRoaW5ha2FyYW4ucGFuZGl5
YW5AaW50ZWwuY29tPg0KPiAtLS0NCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVnLmgg
IHwgIDYgKysrKysNCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3Bzci5jIHwgNTUgKysr
KysrKysrKysrKysrKy0tLS0tLS0tLS0tLQ0KPiAtLS0tLS0tLS0tLS0NCj4gIDIgZmlsZXMgY2hh
bmdlZCwgMjggaW5zZXJ0aW9ucygrKSwgMzMgZGVsZXRpb25zKC0pDQo+IA0KPiBkaWZmIC0tZ2l0
IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZWcuaA0KPiBiL2RyaXZlcnMvZ3B1L2RybS9p
OTE1L2k5MTVfcmVnLmgNCj4gaW5kZXggYWJkYzUxM2E5ZWRkLi4yM2MwZjliZGY1OTEgMTAwNjQ0
DQo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfcmVnLmgNCj4gKysrIGIvZHJpdmVy
cy9ncHUvZHJtL2k5MTUvaTkxNV9yZWcuaA0KPiBAQCAtNDE1MSw2ICs0MTUxLDEyIEBAIGVudW0g
ew0KPiAgI2RlZmluZSAgIEVEUF9QU1JfSURMRV9GUkFNRV9TSElGVAkJMA0KPiAgDQo+ICAjZGVm
aW5lIEVEUF9QU1JfQVVYX0NUTAkJCQlfTU1JTyhkZXZfcHJpDQo+IHYtPnBzcl9tbWlvX2Jhc2Ug
KyAweDEwKQ0KPiArI2RlZmluZSAgIEVEUF9QU1JfQVVYX0NUTF9USU1FX09VVF9NQVNLCQkoMyA8
PCAyNikNCj4gKyNkZWZpbmUgICBFRFBfUFNSX0FVWF9DVExfTUVTU0FHRV9TSVpFX01BU0sJKDB4
MWYgPDwgMjApDQo+ICsjZGVmaW5lICAgRURQX1BTUl9BVVhfQ1RMX1BSRUNIQVJHRV8yVVNfTUFT
SwkoMHhmIDw8IDE2KQ0KPiArI2RlZmluZSAgIEVEUF9QU1JfQVVYX0NUTF9FUlJPUl9JTlRFUlJV
UFQJKDEgPDwgMTEpDQo+ICsjZGVmaW5lICAgRURQX1BTUl9BVVhfQ1RMX0JJVF9DTE9DS18yWF9N
QVNLCSgweDdmZikNCj4gKw0KPiAgI2RlZmluZSBFRFBfUFNSX0FVWF9EQVRBKGkpCQkJX01NSU8o
ZGV2X3ByaXYtDQo+ID5wc3JfbW1pb19iYXNlICsgMHgxNCArIChpKSAqIDQpIC8qIDUgcmVnaXN0
ZXJzICovDQo+ICANCj4gICNkZWZpbmUgRURQX1BTUl9TVEFUVVMJCQkJX01NSU8oZGV2X3ByaXYN
Cj4gLT5wc3JfbW1pb19iYXNlICsgMHg0MCkNCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2Ry
bS9pOTE1L2ludGVsX3Bzci5jDQo+IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfcHNyLmMN
Cj4gaW5kZXggODZkNmMxOWM5YWU2Li4yOTNhOTg3YTFiZmQgMTAwNjQ0DQo+IC0tLSBhL2RyaXZl
cnMvZ3B1L2RybS9pOTE1L2ludGVsX3Bzci5jDQo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1
L2ludGVsX3Bzci5jDQo+IEBAIC0yMjgsMzEgKzIyOCwxMiBAQCBzdGF0aWMgdm9pZCB2bHZfcHNy
X2VuYWJsZV9zaW5rKHN0cnVjdCBpbnRlbF9kcA0KPiAqaW50ZWxfZHApDQo+ICAJCQkgICBEUF9Q
U1JfRU5BQkxFIHwgRFBfUFNSX01BSU5fTElOS19BQ1RJVkUpOw0KPiAgfQ0KPiAgDQo+IC1zdGF0
aWMgaTkxNV9yZWdfdCBwc3JfYXV4X2N0bF9yZWcoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUgKmRl
dl9wcml2LA0KPiAtCQkJCSAgICAgICBlbnVtIHBvcnQgcG9ydCkNCj4gLXsNCj4gLQlpZiAoSU5U
RUxfR0VOKGRldl9wcml2KSA+PSA5KQ0KPiAtCQlyZXR1cm4gRFBfQVVYX0NIX0NUTChwb3J0KTsN
Cj4gLQllbHNlDQo+IC0JCXJldHVybiBFRFBfUFNSX0FVWF9DVEw7DQo+IC19DQo+IC0NCj4gLXN0
YXRpYyBpOTE1X3JlZ190IHBzcl9hdXhfZGF0YV9yZWcoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUN
Cj4gKmRldl9wcml2LA0KPiAtCQkJCQllbnVtIHBvcnQgcG9ydCwgaW50IGluZGV4KQ0KPiAtew0K
PiAtCWlmIChJTlRFTF9HRU4oZGV2X3ByaXYpID49IDkpDQo+IC0JCXJldHVybiBEUF9BVVhfQ0hf
REFUQShwb3J0LCBpbmRleCk7DQo+IC0JZWxzZQ0KPiAtCQlyZXR1cm4gRURQX1BTUl9BVVhfREFU
QShpbmRleCk7DQo+IC19DQo+IC0NCj4gIHN0YXRpYyB2b2lkIGhzd19wc3Jfc2V0dXBfYXV4KHN0
cnVjdCBpbnRlbF9kcCAqaW50ZWxfZHApDQo+ICB7DQo+ICAJc3RydWN0IGludGVsX2RpZ2l0YWxf
cG9ydCAqZGlnX3BvcnQgPQ0KPiBkcF90b19kaWdfcG9ydChpbnRlbF9kcCk7DQo+IC0Jc3RydWN0
IGRybV9kZXZpY2UgKmRldiA9IGRpZ19wb3J0LT5iYXNlLmJhc2UuZGV2Ow0KPiAtCXN0cnVjdCBk
cm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoZGV2KTsNCj4gLQl1aW50MzJfdCBh
dXhfY2xvY2tfZGl2aWRlcjsNCj4gLQlpOTE1X3JlZ190IGF1eF9jdGxfcmVnOw0KPiArCXN0cnVj
dCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiA9IHRvX2k5MTUoZGlnX3BvcnQtDQo+ID5iYXNl
LmJhc2UuZGV2KTsNCj4gKwl1MzIgYXV4X2Nsb2NrX2RpdmlkZXIsIGF1eF9jdGw7DQo+ICsJaW50
IGk7DQo+ICAJc3RhdGljIGNvbnN0IHVpbnQ4X3QgYXV4X21zZ1tdID0gew0KPiAgCQlbMF0gPSBE
UF9BVVhfTkFUSVZFX1dSSVRFIDw8IDQsDQo+ICAJCVsxXSA9IERQX1NFVF9QT1dFUiA+PiA4LA0K
PiBAQCAtMjYwLDIzICsyNDEsMjUgQEAgc3RhdGljIHZvaWQgaHN3X3Bzcl9zZXR1cF9hdXgoc3Ry
dWN0IGludGVsX2RwDQo+ICppbnRlbF9kcCkNCj4gIAkJWzNdID0gMSAtIDEsDQo+ICAJCVs0XSA9
IERQX1NFVF9QT1dFUl9EMCwNCj4gIAl9Ow0KPiAtCWVudW0gcG9ydCBwb3J0ID0gZGlnX3BvcnQt
PmJhc2UucG9ydDsNCj4gLQl1MzIgYXV4X2N0bDsNCj4gLQlpbnQgaTsNCj4gKwl1MzIgcHNyX2F1
eF9tYXNrID0gRURQX1BTUl9BVVhfQ1RMX1RJTUVfT1VUX01BU0sgfA0KPiArCQkJICAgRURQX1BT
Ul9BVVhfQ1RMX01FU1NBR0VfU0laRV9NQVNLIHwNCj4gKwkJCSAgIEVEUF9QU1JfQVVYX0NUTF9Q
UkVDSEFSR0VfMlVTX01BU0sgfA0KPiArCQkJICAgRURQX1BTUl9BVVhfQ1RMX0JJVF9DTE9DS18y
WF9NQVNLOw0KPiAgDQo+ICAJQlVJTERfQlVHX09OKHNpemVvZihhdXhfbXNnKSA+IDIwKTsNCj4g
LQ0KPiAtCWF1eF9jbG9ja19kaXZpZGVyID0gaW50ZWxfZHAtDQo+ID5nZXRfYXV4X2Nsb2NrX2Rp
dmlkZXIoaW50ZWxfZHAsIDApOw0KPiAtCWF1eF9jdGxfcmVnID0gcHNyX2F1eF9jdGxfcmVnKGRl
dl9wcml2LCBwb3J0KTsNCj4gLQ0KPiAtCS8qIFNldHVwIEFVWCByZWdpc3RlcnMgKi8NCj4gIAlm
b3IgKGkgPSAwOyBpIDwgc2l6ZW9mKGF1eF9tc2cpOyBpICs9IDQpDQo+IC0JCUk5MTVfV1JJVEUo
cHNyX2F1eF9kYXRhX3JlZyhkZXZfcHJpdiwgcG9ydCwgaSA+PiAyKSwNCj4gKwkJSTkxNV9XUklU
RShFRFBfUFNSX0FVWF9EQVRBKGkgPj4gMiksDQo+ICAJCQkgICBpbnRlbF9kcF9wYWNrX2F1eCgm
YXV4X21zZ1tpXSwNCj4gc2l6ZW9mKGF1eF9tc2cpIC0gaSkpOw0KPiAgDQo+ICsJYXV4X2Nsb2Nr
X2RpdmlkZXIgPSBpbnRlbF9kcC0NCj4gPmdldF9hdXhfY2xvY2tfZGl2aWRlcihpbnRlbF9kcCwg
MCk7DQo+ICsNCj4gKwkvKiBTdGFydCB3aXRoIGJpdHMgc2V0IGZvciBERElfQVVYX0NUTCByZWdp
c3RlciAqLw0KPiAgCWF1eF9jdGwgPSBpbnRlbF9kcC0+Z2V0X2F1eF9zZW5kX2N0bChpbnRlbF9k
cCwgMCwNCj4gc2l6ZW9mKGF1eF9tc2cpLA0KPiAgCQkJCQkgICAgIGF1eF9jbG9ja19kaXZpZGVy
KTsNCj4gLQlJOTE1X1dSSVRFKGF1eF9jdGxfcmVnLCBhdXhfY3RsKTsNCj4gKw0KPiArCS8qIFNl
bGVjdCBvbmx5IHZhbGlkIGJpdHMgZm9yIFNSRF9BVVhfQ1RMICovDQo+ICsJYXV4X2N0bCAmPSBw
c3JfYXV4X21hc2s7DQo+ICsJSTkxNV9XUklURShFRFBfUFNSX0FVWF9DVEwsIGF1eF9jdGwpOw0K
PiAgfQ0KPiAgDQo+ICBzdGF0aWMgdm9pZCBoc3dfcHNyX2VuYWJsZV9zaW5rKHN0cnVjdCBpbnRl
bF9kcCAqaW50ZWxfZHApDQo+IEBAIC0zMDMsNyArMjg2LDcgQEAgc3RhdGljIHZvaWQgaHN3X3Bz
cl9lbmFibGVfc2luayhzdHJ1Y3QgaW50ZWxfZHANCj4gKmludGVsX2RwKQ0KPiAgCQlkcm1fZHBf
ZHBjZF93cml0ZWIoJmludGVsX2RwLT5hdXgsIERQX1BTUl9FTl9DRkcsDQo+ICAJCQkJICAgRFBf
UFNSX0VOQUJMRSk7DQo+ICANCj4gLQloc3dfcHNyX3NldHVwX2F1eChpbnRlbF9kcCk7DQo+ICsJ
ZHJtX2RwX2RwY2Rfd3JpdGViKCZpbnRlbF9kcC0+YXV4LCBEUF9TRVRfUE9XRVIsDQo+IERQX1NF
VF9QT1dFUl9EMCk7DQo+ICB9DQo+ICANCj4gIHN0YXRpYyB2b2lkIHZsdl9wc3JfZW5hYmxlX3Nv
dXJjZShzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2RwLA0KPiBAQCAtNTk5LDYgKzU4MiwxMiBAQCBz
dGF0aWMgdm9pZCBoc3dfcHNyX2VuYWJsZV9zb3VyY2Uoc3RydWN0DQo+IGludGVsX2RwICppbnRl
bF9kcCwNCj4gIA0KPiAgCXBzcl9hdXhfaW9fcG93ZXJfZ2V0KGludGVsX2RwKTsNCj4gIA0KPiAr
CS8qIE9ubHkgSFNXIGFuZCBCRFcgaGF2ZSBQU1IgQVVYIHJlZ2lzdGVycyB0aGF0IG5lZWQgdG8g
YmUNCj4gc2V0dXAuIFNLTCsNCj4gKwkgKiB1c2UgaGFyZGNvZGVkIHZhbHVlcyBQU1IgQVVYIHRy
YW5zYWN0aW9ucw0KPiArCSAqLw0KPiArCWlmIChJU19IQVNXRUxMKGRldl9wcml2KSB8fCBJU19C
Uk9BRFdFTEwoZGV2X3ByaXYpKQ0KPiArCQloc3dfcHNyX3NldHVwX2F1eChpbnRlbF9kcCk7DQo+
ICsNCj4gIAlpZiAoZGV2X3ByaXYtPnBzci5wc3IyX3N1cHBvcnQpIHsNCj4gIAkJY2hpY2tlbiA9
IFBTUjJfVlNDX0VOQUJMRV9QUk9HX0hFQURFUjsNCj4gIAkJaWYgKGRldl9wcml2LT5wc3IueV9j
b3JkX3N1cHBvcnQpCl9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9y
ZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdm
eAo=