From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de ([195.135.220.15]:50978 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751015AbeCNMX0 (ORCPT ); Wed, 14 Mar 2018 08:23:26 -0400 Message-ID: <1521029854.4511.12.camel@suse.com> Subject: Re: [PATCH 2/3] usb: host: pci: introduce PCI vendor ID for Netlogic From: Oliver Neukum To: Richard Leitner , linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-usb@vger.kernel.org Cc: bhelgaas@google.com, mathias.nyman@intel.com, gregkh@linuxfoundation.org, richard.leitner@skidata.com Date: Wed, 14 Mar 2018 13:17:34 +0100 In-Reply-To: <20180314102933.21367-3-dev@g0hl1n.net> References: <20180314102933.21367-1-dev@g0hl1n.net> <20180314102933.21367-3-dev@g0hl1n.net> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-pci-owner@vger.kernel.org List-ID: Am Mittwoch, den 14.03.2018, 11:29 +0100 schrieb Richard Leitner: > From: Richard Leitner > > Replace the hardcoded PCI vendor ID of Netlogic with a definition in > pci_ids.h Hi, in general, why? Does this patch generate any benefit for any developer reading the source? I don't see it. Does it cause an issue for anybody who has a log file with the nummerical ID and needs to grep for it? Yes it does. Where is the point of this patch? Regards Oliver From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [2/3] usb: host: pci: introduce PCI vendor ID for Netlogic From: Oliver Neukum Message-Id: <1521029854.4511.12.camel@suse.com> Date: Wed, 14 Mar 2018 13:17:34 +0100 To: Richard Leitner , linux-kernel@vger.kernel.org, linux-pci@vger.kernel.org, linux-usb@vger.kernel.org Cc: bhelgaas@google.com, mathias.nyman@intel.com, gregkh@linuxfoundation.org, richard.leitner@skidata.com List-ID: QW0gTWl0dHdvY2gsIGRlbiAxNC4wMy4yMDE4LCAxMToyOSArMDEwMCBzY2hyaWViIFJpY2hhcmQg TGVpdG5lcjoKPiBGcm9tOiBSaWNoYXJkIExlaXRuZXIgPHJpY2hhcmQubGVpdG5lckBza2lkYXRh LmNvbT4KPiAKPiBSZXBsYWNlIHRoZSBoYXJkY29kZWQgUENJIHZlbmRvciBJRCBvZiBOZXRsb2dp YyB3aXRoIGEgZGVmaW5pdGlvbiBpbgo+IHBjaV9pZHMuaAoKSGksCgppbiBnZW5lcmFsLCB3aHk/ CkRvZXMgdGhpcyBwYXRjaCBnZW5lcmF0ZSBhbnkgYmVuZWZpdCBmb3IgYW55IGRldmVsb3Blcgpy ZWFkaW5nIHRoZSBzb3VyY2U/IEkgZG9uJ3Qgc2VlIGl0LiBEb2VzIGl0IGNhdXNlIGFuCmlzc3Vl IGZvciBhbnlib2R5IHdobyBoYXMgYSBsb2cgZmlsZSB3aXRoIHRoZSBudW1tZXJpY2FsCklEIGFu ZCBuZWVkcyB0byBncmVwIGZvciBpdD8gWWVzIGl0IGRvZXMuCgpXaGVyZSBpcyB0aGUgcG9pbnQg b2YgdGhpcyBwYXRjaD8KCglSZWdhcmRzCgkJT2xpdmVyCi0tLQpUbyB1bnN1YnNjcmliZSBmcm9t IHRoaXMgbGlzdDogc2VuZCB0aGUgbGluZSAidW5zdWJzY3JpYmUgbGludXgtdXNiIiBpbgp0aGUg Ym9keSBvZiBhIG1lc3NhZ2UgdG8gbWFqb3Jkb21vQHZnZXIua2VybmVsLm9yZwpNb3JlIG1ham9y ZG9tbyBpbmZvIGF0ICBodHRwOi8vdmdlci5rZXJuZWwub3JnL21ham9yZG9tby1pbmZvLmh0bWwK