From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Kani, Toshi" Subject: Re: [PATCH v1 0/4] Fix issues with huge mapping in ioremap Date: Wed, 14 Mar 2018 14:38:00 +0000 Message-ID: <1521038277.2693.131.camel@hpe.com> References: <1521017305-28518-1-git-send-email-cpandya@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1521017305-28518-1-git-send-email-cpandya@codeaurora.org> Content-Language: en-US Content-ID: <5C99D1C06EF2B3428FA0FC72FB6CB5DB@NAMPRD84.PROD.OUTLOOK.COM> Sender: linux-kernel-owner@vger.kernel.org To: "cpandya@codeaurora.org" , "catalin.marinas@arm.com" , "will.deacon@arm.com" , "arnd@arndb.de" Cc: "linux-kernel@vger.kernel.org" , "ard.biesheuvel@linaro.org" , "tglx@linutronix.de" , "takahiro.akashi@linaro.org" , "james.morse@arm.com" , "kristina.martsenko@arm.com" , "mark.rutland@arm.com" , "akpm@linux-foundation.org" , "gregkh@linuxfoundation.org" , "linux-arm-kernel@lists.infradead.org" , "marc.zyngier@arm.com" , "linux-arch@vger.kernel.org" List-Id: linux-arch.vger.kernel.org T24gV2VkLCAyMDE4LTAzLTE0IGF0IDE0OjE4ICswNTMwLCBDaGludGFuIFBhbmR5YSB3cm90ZToN Cj4gTm90ZTogSSB3YXMgd29ya2luZyBvbiB0aGVzZSBwYXRjaGVzIGZvciBxdWl0ZSBzb21ldGlt ZQ0KPiBhbmQgcmVhbGl6ZWQgdGhhdCBUb3NoaSBLYW5pIGhhcyBzaGFyZWQgc29tZSBwYXRjaGVz DQo+IGFkZHJlc3NpbmcgdGhlIHNhbWUgaXNzc3VlIHdpdGggc3ViamVjdA0KPiAiW1BBVENIIDAv Ml0gZml4IG1lbW9yeSBsZWFrIC8gcGFuaWMgaW4gaW9yZW1hcCBodWdlIHBhZ2VzIi4NCj4gSSd2 ZSB0YWtlbiBzbGlnaHRseSBkaWZmZXJlbnQgYXBwcm9hY2ggaGVyZSwgc28gc2VuZGluZw0KPiB0 byB0aGUgbGlzdCwgZmluYWxseS4NCg0KSGkgQ2hpbnRhbiwNCg0KRG8geW91IGhhdmUgYW55IGlz c3VlIGluIG15IHBhdGNoc2V0PyAgSWYgc28sIGNhbiB5b3UgcGxlYXNlIGNvbW1lbnQgb24NCnRo ZW0/ICBJdCBjb21wbGljYXRlcyB0aGUgdGhpbmcgd2hlbiB5b3Ugc2VuZCBhIGRpZmZlcmVudCBh cHByb2FjaA0Kd2l0aG91dCB0ZWxsaW5nIHdoeSBhIGRpZmZlcmVudCBhcHByb2FjaCBpcyBuZWVk ZWQuICBZb3VyIGFwcHJvYWNoDQpwdXJnZXMgVExCIGFmdGVyIHVwZGF0aW5nIHBtZC9wdWQsIHdo aWNoIEkgdGhpbmsgaXMgYnJva2VuLiAgQ2FuIHlvdQ0Kd29yayBvbiB0b3Agb2YgbXkgcGF0Y2hz ZXQgYW5kIHByb3Blcmx5IGltcGxlbWVudCBwWGRfZnJlZV9wdGVfcGFnZSgpDQpmb3IgYXJtNjQ/ ICBJIHdpbGwgc2VuZCBvdXQgbXkgdjIgdG9kYXkuDQogIA0KVGhhbmtzLA0KLVRvc2hpDQo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: toshi.kani@hpe.com (Kani, Toshi) Date: Wed, 14 Mar 2018 14:38:00 +0000 Subject: [PATCH v1 0/4] Fix issues with huge mapping in ioremap In-Reply-To: <1521017305-28518-1-git-send-email-cpandya@codeaurora.org> References: <1521017305-28518-1-git-send-email-cpandya@codeaurora.org> Message-ID: <1521038277.2693.131.camel@hpe.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Wed, 2018-03-14 at 14:18 +0530, Chintan Pandya wrote: > Note: I was working on these patches for quite sometime > and realized that Toshi Kani has shared some patches > addressing the same isssue with subject > "[PATCH 0/2] fix memory leak / panic in ioremap huge pages". > I've taken slightly different approach here, so sending > to the list, finally. Hi Chintan, Do you have any issue in my patchset? If so, can you please comment on them? It complicates the thing when you send a different approach without telling why a different approach is needed. Your approach purges TLB after updating pmd/pud, which I think is broken. Can you work on top of my patchset and properly implement pXd_free_pte_page() for arm64? I will send out my v2 today. Thanks, -Toshi