All of lore.kernel.org
 help / color / mirror / Atom feed
From: Doug Ledford <dledford@redhat.com>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: bart.vanassche@wdc.com, jgg@mellanox.com,
	linux-rdma@vger.kernel.org, sagi@grimberg.me,
	stable@vger.kernel.org, swise@opengridcomputing.com
Subject: Re: [patch 1/1] drivers/infiniband/core/verbs.c: fix build with gcc-4.4.4
Date: Wed, 14 Mar 2018 18:15:25 -0400	[thread overview]
Message-ID: <1521065725.18703.127.camel@redhat.com> (raw)
In-Reply-To: <1521061939.18703.126.camel@redhat.com>

[-- Attachment #1: Type: text/plain, Size: 1257 bytes --]

On Wed, 2018-03-14 at 17:12 -0400, Doug Ledford wrote:
> On Wed, 2018-03-14 at 14:08 -0700, Andrew Morton wrote:
> > On Wed, 14 Mar 2018 16:41:00 -0400 Doug Ledford <dledford@redhat.com> wrote:
> > 
> > > On Tue, 2018-03-13 at 14:51 -0700, akpm@linux-foundation.org wrote:
> > > > From: Andrew Morton <akpm@linux-foundation.org>
> > > > Subject: drivers/infiniband/core/verbs.c: fix build with gcc-4.4.4
> > > > 
> > > > gcc-4.4.4 has issues with initialization of anonymous unions.
> > > 
> > > That compiler was released in April of 2010, almost a full 8 years ago. 
> > > What still uses it, and do we seriously care?
> > 
> > Documentation/Changes still says gcc-3.2.  A few people are using the
> > older versions.  There's talk going around about requiring something
> > more recent but nothing has happened yet.
> 
> OK, count this as a grumble about the outdated compiler requirement :-/. 
> The code this patches looks nice and clean, this patch uglies it up.
> 

If it wasn't obvious BTW, this and the other patch you sent have been
applied to for-next area, begrudgingly ;-)

-- 
Doug Ledford <dledford@redhat.com>
    GPG KeyID: B826A3330E572FDD
    Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]

      reply	other threads:[~2018-03-14 22:15 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-13 21:51 [patch 1/1] drivers/infiniband/core/verbs.c: fix build with gcc-4.4.4 akpm
2018-03-14 20:41 ` Doug Ledford
2018-03-14 21:08   ` Andrew Morton
2018-03-14 21:12     ` Doug Ledford
2018-03-14 22:15       ` Doug Ledford [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1521065725.18703.127.camel@redhat.com \
    --to=dledford@redhat.com \
    --cc=akpm@linux-foundation.org \
    --cc=bart.vanassche@wdc.com \
    --cc=jgg@mellanox.com \
    --cc=linux-rdma@vger.kernel.org \
    --cc=sagi@grimberg.me \
    --cc=stable@vger.kernel.org \
    --cc=swise@opengridcomputing.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.