diff for duplicates of <1521119909.10304.1.camel@synopsys.com> diff --git a/a/1.txt b/N1/1.txt index b38d2da..8784c13 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,7 +1,7 @@ Hello Ulf, -On Thu, 2018-03-15 at 10:57 +0100, Ulf Hansson wrote: -> On 14 March 2018 at 20:30, Evgeniy Didin <Evgeniy.Didin@synopsys.com> wrote: +On Thu, 2018-03-15@10:57 +0100, Ulf Hansson wrote: +> On 14 March 2018@20:30, Evgeniy Didin <Evgeniy.Didin@synopsys.com> wrote: > > It was found that in IDMAC mode after soft-reset driver switches > > to PIO mode. > > @@ -37,54 +37,50 @@ Evgeniy Didin > > And while at it explicitly zero des0 which otherwise might > > contain garbage as being allocated by dmam_alloc_coherent(). > > -> > Signed-off-by: Evgeniy Didin <Evgeniy.Didin@synopsys.com> -> > Cc: Jaehoon Chung <jh80.chung@samsung.com> -> > Cc: Ulf Hansson <ulf.hansson@linaro.org> -> > Cc: Andy Shevchenko <andy.shevchenko@gmail.com> -> > Cc: Jisheng Zhang <Jisheng.Zhang@synaptics.com> -> > Cc: Shawn Lin <shawn.lin@rock-chips.com> -> > Cc: Alexey Brodkin <abrodkin@synopsys.com> -> > Cc: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com> -> > Cc: linux-snps-arc@lists.infradead.org +> > Signed-off-by: Evgeniy Didin <Evgeniy.Didin at synopsys.com> +> > Cc: Jaehoon Chung <jh80.chung at samsung.com> +> > Cc: Ulf Hansson <ulf.hansson at linaro.org> +> > Cc: Andy Shevchenko <andy.shevchenko at gmail.com> +> > Cc: Jisheng Zhang <Jisheng.Zhang at synaptics.com> +> > Cc: Shawn Lin <shawn.lin at rock-chips.com> +> > Cc: Alexey Brodkin <abrodkin at synopsys.com> +> > Cc: Eugeniy Paltsev <Eugeniy.Paltsev at synopsys.com> +> > Cc: linux-snps-arc at lists.infradead.org > > --- -> > drivers/mmc/host/dw_mmc.c | 6 ++++-- -> > 1 file changed, 4 insertions(+), 2 deletions(-) +> > ?drivers/mmc/host/dw_mmc.c | 6 ++++-- +> > ?1 file changed, 4 insertions(+), 2 deletions(-) > > > > diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c > > index 0aa39975f33b..26f2ac107702 100644 > > --- a/drivers/mmc/host/dw_mmc.c > > +++ b/drivers/mmc/host/dw_mmc.c > > @@ -558,6 +558,7 @@ static int dw_mci_idmac_init(struct dw_mci *host) -> > (sizeof(struct idmac_desc_64addr) * -> > (i + 1))) >> 32; -> > /* Initialize reserved and buffer size fields to "0" */ -> > + p->des0 = 0; -> > p->des1 = 0; -> > p->des2 = 0; -> > p->des3 = 0; +> > ????????????????????????????????????????(sizeof(struct idmac_desc_64addr) * +> > ????????????????????????????????????????????????????????(i + 1))) >> 32; +> > ????????????????????????/* Initialize reserved and buffer size fields to "0" */ +> > +???????????????????????p->des0 = 0; +> > ????????????????????????p->des1 = 0; +> > ????????????????????????p->des2 = 0; +> > ????????????????????????p->des3 = 0; > > @@ -580,6 +581,7 @@ static int dw_mci_idmac_init(struct dw_mci *host) -> > i++, p++) { -> > p->des3 = cpu_to_le32(host->sg_dma + -> > (sizeof(struct idmac_desc) * (i + 1))); -> > + p->des0 = 0; -> > p->des1 = 0; -> > } +> > ?????????????????????i++, p++) { +> > ????????????????????????p->des3 = cpu_to_le32(host->sg_dma + +> > ????????????????????????????????????????(sizeof(struct idmac_desc) * (i + 1))); +> > +???????????????????????p->des0 = 0; +> > ????????????????????????p->des1 = 0; +> > ????????????????} > > > > @@ -1795,8 +1797,8 @@ static bool dw_mci_reset(struct dw_mci *host) -> > } +> > ????????} > > -> > if (host->use_dma == TRANS_MODE_IDMAC) -> > - /* It is also recommended that we reset and reprogram idmac */ -> > - dw_mci_idmac_reset(host); -> > + /* It is also required that we reinit idmac */ -> > + dw_mci_idmac_init(host); +> > ????????if (host->use_dma == TRANS_MODE_IDMAC) +> > -???????????????/* It is also recommended that we reset and reprogram idmac */ +> > -???????????????dw_mci_idmac_reset(host); +> > +???????????????/* It is also required that we reinit idmac */ +> > +???????????????dw_mci_idmac_init(host); > > -> > ret = true; +> > ????????ret = true; > > > > -- > > 2.11.0 -> > -_______________________________________________ -linux-snps-arc mailing list -linux-snps-arc@lists.infradead.org -http://lists.infradead.org/mailman/listinfo/linux-snps-arc +> > diff --git a/a/content_digest b/N1/content_digest index bd80191..7521ade 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,24 +1,15 @@ "ref\020180314193051.16791-1-Evgeniy.Didin@synopsys.com\0" "ref\0CAPDyKFrgBm8-G1CsnqS9G62xFA2qA0XkuGBfA5v6grZnjRLteA@mail.gmail.com\0" - "From\0Evgeniy Didin <Evgeniy.Didin@synopsys.com>\0" - "Subject\0Re: [PATCH] mmc: dw_mmc: fix falling from idmac to PIO mode when dw_mci_reset occurs\0" + "From\0Evgeniy.Didin@synopsys.com (Evgeniy Didin)\0" + "Subject\0[PATCH] mmc: dw_mmc: fix falling from idmac to PIO mode when dw_mci_reset occurs\0" "Date\0Thu, 15 Mar 2018 13:18:31 +0000\0" - "To\0ulf.hansson@linaro.org <ulf.hansson@linaro.org>" - " Evgeniy.Didin@synopsys.com <Evgeniy.Didin@synopsys.com>\0" - "Cc\0shawn.lin@rock-chips.com <shawn.lin@rock-chips.com>" - Alexey.Brodkin@synopsys.com <Alexey.Brodkin@synopsys.com> - linux-mmc@vger.kernel.org <linux-mmc@vger.kernel.org> - Jisheng.Zhang@synaptics.com <Jisheng.Zhang@synaptics.com> - jh80.chung@samsung.com <jh80.chung@samsung.com> - andy.shevchenko@gmail.com <andy.shevchenko@gmail.com> - linux-snps-arc@lists.infradead.org <linux-snps-arc@lists.infradead.org> - " Eugeniy.Paltsev@synopsys.com <Eugeniy.Paltsev@synopsys.com>\0" + "To\0linux-snps-arc@lists.infradead.org\0" "\00:1\0" "b\0" "Hello Ulf,\n" "\n" - "On Thu, 2018-03-15 at 10:57 +0100, Ulf Hansson wrote:\n" - "> On 14 March 2018 at 20:30, Evgeniy Didin <Evgeniy.Didin@synopsys.com> wrote:\n" + "On Thu, 2018-03-15@10:57 +0100, Ulf Hansson wrote:\n" + "> On 14 March 2018@20:30, Evgeniy Didin <Evgeniy.Didin@synopsys.com> wrote:\n" "> > It was found that in IDMAC mode after soft-reset driver switches\n" "> > to PIO mode.\n" "> > \n" @@ -54,56 +45,52 @@ "> > And while at it explicitly zero des0 which otherwise might\n" "> > contain garbage as being allocated by dmam_alloc_coherent().\n" "> > \n" - "> > Signed-off-by: Evgeniy Didin <Evgeniy.Didin@synopsys.com>\n" - "> > Cc: Jaehoon Chung <jh80.chung@samsung.com>\n" - "> > Cc: Ulf Hansson <ulf.hansson@linaro.org>\n" - "> > Cc: Andy Shevchenko <andy.shevchenko@gmail.com>\n" - "> > Cc: Jisheng Zhang <Jisheng.Zhang@synaptics.com>\n" - "> > Cc: Shawn Lin <shawn.lin@rock-chips.com>\n" - "> > Cc: Alexey Brodkin <abrodkin@synopsys.com>\n" - "> > Cc: Eugeniy Paltsev <Eugeniy.Paltsev@synopsys.com>\n" - "> > Cc: linux-snps-arc@lists.infradead.org\n" + "> > Signed-off-by: Evgeniy Didin <Evgeniy.Didin at synopsys.com>\n" + "> > Cc: Jaehoon Chung <jh80.chung at samsung.com>\n" + "> > Cc: Ulf Hansson <ulf.hansson at linaro.org>\n" + "> > Cc: Andy Shevchenko <andy.shevchenko at gmail.com>\n" + "> > Cc: Jisheng Zhang <Jisheng.Zhang at synaptics.com>\n" + "> > Cc: Shawn Lin <shawn.lin at rock-chips.com>\n" + "> > Cc: Alexey Brodkin <abrodkin at synopsys.com>\n" + "> > Cc: Eugeniy Paltsev <Eugeniy.Paltsev at synopsys.com>\n" + "> > Cc: linux-snps-arc at lists.infradead.org\n" "> > ---\n" - "> > \302\240drivers/mmc/host/dw_mmc.c | 6 ++++--\n" - "> > \302\2401 file changed, 4 insertions(+), 2 deletions(-)\n" + "> > ?drivers/mmc/host/dw_mmc.c | 6 ++++--\n" + "> > ?1 file changed, 4 insertions(+), 2 deletions(-)\n" "> > \n" "> > diff --git a/drivers/mmc/host/dw_mmc.c b/drivers/mmc/host/dw_mmc.c\n" "> > index 0aa39975f33b..26f2ac107702 100644\n" "> > --- a/drivers/mmc/host/dw_mmc.c\n" "> > +++ b/drivers/mmc/host/dw_mmc.c\n" "> > @@ -558,6 +558,7 @@ static int dw_mci_idmac_init(struct dw_mci *host)\n" - "> > \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240(sizeof(struct idmac_desc_64addr) *\n" - "> > \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240(i + 1))) >> 32;\n" - "> > \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240/* Initialize reserved and buffer size fields to \"0\" */\n" - "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240p->des0 = 0;\n" - "> > \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240p->des1 = 0;\n" - "> > \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240p->des2 = 0;\n" - "> > \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240p->des3 = 0;\n" + "> > ????????????????????????????????????????(sizeof(struct idmac_desc_64addr) *\n" + "> > ????????????????????????????????????????????????????????(i + 1))) >> 32;\n" + "> > ????????????????????????/* Initialize reserved and buffer size fields to \"0\" */\n" + "> > +???????????????????????p->des0 = 0;\n" + "> > ????????????????????????p->des1 = 0;\n" + "> > ????????????????????????p->des2 = 0;\n" + "> > ????????????????????????p->des3 = 0;\n" "> > @@ -580,6 +581,7 @@ static int dw_mci_idmac_init(struct dw_mci *host)\n" - "> > \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240i++, p++) {\n" - "> > \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240p->des3 = cpu_to_le32(host->sg_dma +\n" - "> > \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240(sizeof(struct idmac_desc) * (i + 1)));\n" - "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240p->des0 = 0;\n" - "> > \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240p->des1 = 0;\n" - "> > \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240}\n" + "> > ?????????????????????i++, p++) {\n" + "> > ????????????????????????p->des3 = cpu_to_le32(host->sg_dma +\n" + "> > ????????????????????????????????????????(sizeof(struct idmac_desc) * (i + 1)));\n" + "> > +???????????????????????p->des0 = 0;\n" + "> > ????????????????????????p->des1 = 0;\n" + "> > ????????????????}\n" "> > \n" "> > @@ -1795,8 +1797,8 @@ static bool dw_mci_reset(struct dw_mci *host)\n" - "> > \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240}\n" + "> > ????????}\n" "> > \n" - "> > \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240if (host->use_dma == TRANS_MODE_IDMAC)\n" - "> > -\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240/* It is also recommended that we reset and reprogram idmac */\n" - "> > -\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240dw_mci_idmac_reset(host);\n" - "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240/* It is also required that we reinit idmac */\n" - "> > +\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240dw_mci_idmac_init(host);\n" + "> > ????????if (host->use_dma == TRANS_MODE_IDMAC)\n" + "> > -???????????????/* It is also recommended that we reset and reprogram idmac */\n" + "> > -???????????????dw_mci_idmac_reset(host);\n" + "> > +???????????????/* It is also required that we reinit idmac */\n" + "> > +???????????????dw_mci_idmac_init(host);\n" "> > \n" - "> > \302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240ret = true;\n" + "> > ????????ret = true;\n" "> > \n" "> > --\n" "> > 2.11.0\n" - "> > \n" - "_______________________________________________\n" - "linux-snps-arc mailing list\n" - "linux-snps-arc@lists.infradead.org\n" - http://lists.infradead.org/mailman/listinfo/linux-snps-arc + > > -7c15e52a0f2eac26540529f66925987729bdca09c0efa2f0720fb26fbe2841d2 +7b5b33d84dd659623b6f7caf839e8f8c5fc7aad3b0162f13b853d4638610d11a
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.