All of lore.kernel.org
 help / color / mirror / Atom feed
From: Benjamin Herrenschmidt <benh@kernel.crashing.org>
To: "Cédric Le Goater" <clg@kaod.org>,
	"Frederic Barrat" <fbarrat@linux.vnet.ibm.com>,
	linuxppc-dev@lists.ozlabs.org
Cc: andrew.donnellan@au1.ibm.com, vaibhav@linux.vnet.ibm.com
Subject: Re: [RFC] powerpc/xive: Remove irq from queue when it is shutdown
Date: Fri, 16 Mar 2018 09:56:06 +1100	[thread overview]
Message-ID: <1521154566.16434.171.camel@kernel.crashing.org> (raw)
In-Reply-To: <ba73a10a-320c-914e-5d7e-1ff212fdd6c5@kaod.org>

On Wed, 2018-03-14 at 18:47 +0100, Cédric Le Goater wrote:
> We could also loop on the ESB 'P' bit to wait for the irqs to be handled,
> using :
> 
>         xive_esb_read(irq, XIVE_ESB_GET)
> 
> which has no side effect. It looks simpler to me. Is that possible ? 

But you can race with something sending another one... I prefer the
guarantee that after final masking, we check the queue contents on
shutdown.

That will be solid vs. other type of interrupts as well.

Cheers,
Ben.

  reply	other threads:[~2018-03-15 22:56 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-14 16:58 [RFC] powerpc/xive: Remove irq from queue when it is shutdown Frederic Barrat
2018-03-14 17:47 ` Cédric Le Goater
2018-03-15 22:56   ` Benjamin Herrenschmidt [this message]
2018-03-15 22:59 ` Benjamin Herrenschmidt

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1521154566.16434.171.camel@kernel.crashing.org \
    --to=benh@kernel.crashing.org \
    --cc=andrew.donnellan@au1.ibm.com \
    --cc=clg@kaod.org \
    --cc=fbarrat@linux.vnet.ibm.com \
    --cc=linuxppc-dev@lists.ozlabs.org \
    --cc=vaibhav@linux.vnet.ibm.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.