From mboxrd@z Thu Jan 1 00:00:00 1970 From: Martin Wilck Subject: Re: [PATCH 1/3] multipathd: fix waiter thread cancelling Date: Mon, 19 Mar 2018 13:59:24 +0100 Message-ID: <1521464364.3798.48.camel@suse.com> References: <1521235867-29476-1-git-send-email-bmarzins@redhat.com> <1521235867-29476-2-git-send-email-bmarzins@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <1521235867-29476-2-git-send-email-bmarzins@redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: Benjamin Marzinski , device-mapper development List-Id: dm-devel.ids T24gRnJpLCAyMDE4LTAzLTE2IGF0IDE2OjMxIC0wNTAwLCBCZW5qYW1pbiBNYXJ6aW5za2kgd3Jv dGU6Cj4gbXVsdGlwYXRoZCB3YXMgc2VuZGluZyBhIHNpZ25hbCB0byB0aGUgcGVyLWRldmljZSB3 YWl0ZXIgdGhyZWFkIGFmdGVyCj4gY2FuY2VsbGluZyBpdC4gIFNpbmNlIHRoZXNlIHRocmVhZHMg YXJlIGRldGFjaGVkLCB0aGVyZSBpcyBhIHdpbmRvdwo+IHdoZXJlIGEgbmV3IHRocmVhZCBjb3Vs ZCBoYXZlIHN0YXJ0ZWQgd2l0aCB0aGUgb2xkIHRocmVhZCBpZCBiZXR3ZWVuCj4gdGhlCj4gY2Fu Y2VsIGFuZCB0aGUgc2lnbmFsbGluZywgY2F1c2luZyB0aGUgc2lnbmFsIHRvIGJlIGRlbGl2ZXJl ZCB0byB0aGUKPiB3cm9uZyB0aHJlYWQuIFNpbXBseSByZXZlcnNpbmcgdGhlIG9yZGVyIGRvZXNu J3QgZml4IHRoZSBpc3N1ZSwgc2luY2UKPiB0aGUgd2FpdGVyIHRocmVhZHMgZXhpdCBpbW1lZGlh dGVseSBpZiB0aGV5IHJlY2VpdmUgYSBzaWduYWwsIGFnYWluCj4gb3BlbmluZyBhIHdpbmRvdyBm b3IgdGhlIGNhbmNlbCB0byBiZSBkZWxpdmVyZWQgdG8gdGhlIHdyb25nIHRocmVhZC4KPiAKPiBU byBmaXggdGhpcywgbXVsdGlwYXRoZCBkb2VzIHJldmVyc2UgdGhlIG9yZGVyLCBzbyB0aGF0IGl0 IHNpZ25hbHMKPiB0aGUKPiB0aHJlYWQgZmlyc3QgKGl0IG5lZWRzIHRvIHNpZ25hbCB0aGUgdGhy ZWFkLCBzaW5jZSB0aGUgZG1fdGFza19ydW4KPiBpb2N0bAo+IGlzbid0IGEgY2FuY2VsbGF0aW9u IHBvaW50KSBhbmQgdGhlbiBjYW5jZWxzIGl0LiBIb3dldmVyIGl0IGRvZXMgdGhpcwo+IHdoaWxl IGhvbGRpbmcgYSBuZXcgbXV0ZXguCj4gCj4gVGhlIHdhaXRlciB0aHJlYWQgY2FuIG9ubHkgZXhp dCB3aXRob3V0IGJlaW5nIGNhbmNlbGxlZCBmb3IgdHdvCj4gcmVhc29ucy4KPiAxLiBXaGVuIGl0 IGZhaWxzIGluIHVwZGF0ZV9tdWx0aXBhdGgsIHdoaWNoIHJlbW92ZXMgdGhlIGRldmljZSB3aGls ZQo+ICAgIGhvbGRpbmcgdGhlIHZlY3MgbG9jay4KPiAyLiBJZiBpdCByZWNlaXZlcyBhIFNJR1VT UjIgc2lnbmFsIHdoaWxlIHdhaXRpbmcgZm9yIGEgZG0gZXZlbnQuCj4gCj4gQ2FzZSAxIGNhbiBu ZXZlciByYWNlIHdpdGggYW5vdGhlciB0aHJlYWQgcmVtb3ZpbmcgdGhlIGRldmljZSwgc2luY2UK PiByZW1vdmluZyBhIGRldmljZSBhbHdheXMgaGFwcGVucyB3aGlsZSBob2xkaW5nIHRoZSB2ZWNz IGxvY2suICBUaGlzCj4gbWVhbnMgdGhhdCBpZiB0aGUgZGV2aWNlIGV4aXN0cyB0byBiZSByZW1v dmVkLCB0aGVuIHRoZSB3YWl0ZXIgdGhyZWFkCj4gY2FuJ3QgZXhpdCB0aGlzIHdheSBkdXJpbmcg dGhlIHJlbW92YWwuCj4gCj4gQ2FzZSAyIGlzIG5vdyBzb2x2ZWQgYnkgZ3JhYmJpbmcgdGhlIG5l dyBtdXRleCBhZnRlciBmYWlsaW5nCj4gZG1fdGFza19ydW4oKS4gV2l0aCB0aGUgbXV0ZXggaGVs ZCwgdGhlIHRocmVhZCBjaGVja3MgaWYgaXQgaGFzIGJlZW4KPiBjYW5jZWxsZWQuIElmIGl0IHdh c24ndCBjYW5jZWxsZWQsIHRoZSB0aHJlYWQgY29udGludWVzLgo+IAo+IFRoZSByZWFzb24gdGhh dCB0aGlzIHVzZXMgYSBuZXcgbXV0ZXgsIGluc3RlYWQgb2YgdGhlIHZlY3MgbG9jaywgaXMKPiB0 aGF0Cj4gdXNpbmcgdGhlIHZlY3MgbG9jayB3b3VsZCBrZWVwIHRoZSB0aHJlYWQgZnJvbSBlbmRp bmcgdW50aWwgdGhlIHZlY3MKPiBsb2NrIHdhcyByZWxlYXNlZC4gIE5vcm1hbGx5LCB0aGlzIGlz bid0IGEgcHJvYmxlbS4gQnV0IGR1cmluZwo+IHJlY29uZmlndXJlLCB0aGUgd2FpdGVyIHRocmVh ZHMgZm9yIGFsbCBkZXZpY2VzIGFyZSBzdG9wcGVkLCBhbmQgbmV3Cj4gb25lcyBzdGFydGVkLCBh bGwgd2hpbGUgaG9sZGluZyB0aGUgdmVjcyBsb2NrLiAgRm9yIHN5c3RlbXMgd2l0aCBhCj4gbGFy Z2UKPiBudW1iZXIgb2YgbXVsdGlwYXRoIGRldmljZXMsIHRoaXMgd2lsbCBjYXVzZSBtdWx0aXBh dGhkIGRvIGhhdmUKPiBkb3VibGUKPiBpdHMgYWxyZWFkeSBsYXJnZSBudW1iZXIgb2Ygd2FpdGVy IHRocmVhZHMgZHVyaW5nIHJlY29uZmlndXJlLCBhbGwKPiBsb2NrZWQKPiBpbnRvIG1lbW9yeS4K PiAKPiBTaWduZWQtb2ZmLWJ5OiBCZW5qYW1pbiBNYXJ6aW5za2kgPGJtYXJ6aW5zQHJlZGhhdC5j b20+Cj4gLS0tCj4gIG11bHRpcGF0aGQvd2FpdGVyLmMgfCAxNiArKysrKysrKysrKysrLS0tCj4g IDEgZmlsZSBjaGFuZ2VkLCAxMyBpbnNlcnRpb25zKCspLCAzIGRlbGV0aW9ucygtKQo+IAo+IGRp ZmYgLS1naXQgYS9tdWx0aXBhdGhkL3dhaXRlci5jIGIvbXVsdGlwYXRoZC93YWl0ZXIuYwo+IGlu ZGV4IGNiOTcwOGIuLmU4OTQyOTQgMTAwNjQ0Cj4gLS0tIGEvbXVsdGlwYXRoZC93YWl0ZXIuYwo+ ICsrKyBiL211bHRpcGF0aGQvd2FpdGVyLmMKPiBAQCAtMjMsNiArMjMsNyBAQAo+ICAjaW5jbHVk ZSAid2FpdGVyLmgiCj4gIAo+ICBwdGhyZWFkX2F0dHJfdCB3YWl0ZXJfYXR0cjsKPiArc3RydWN0 IG11dGV4X2xvY2sgd2FpdGVyX2xvY2sgPSB7IC5tdXRleCA9IFBUSFJFQURfTVVURVhfSU5JVElB TElaRVIKPiB9Owo+ICAKPiAgc3RhdGljIHN0cnVjdCBldmVudF90aHJlYWQgKmFsbG9jX3dhaXRl ciAodm9pZCkKPiAgewo+IEBAIC01OSw4ICs2MCwxMiBAQCB2b2lkIHN0b3Bfd2FpdGVyX3RocmVh ZCAoc3RydWN0IG11bHRpcGF0aCAqbXBwLAo+IHN0cnVjdCB2ZWN0b3JzICp2ZWNzKQo+ICAJCW1w cC0+d2FpdGVyKTsKPiAgCXRocmVhZCA9IG1wcC0+d2FpdGVyOwo+ICAJbXBwLT53YWl0ZXIgPSAo cHRocmVhZF90KTA7Cj4gLQlwdGhyZWFkX2NhbmNlbCh0aHJlYWQpOwo+ICsJcHRocmVhZF9jbGVh bnVwX3B1c2goY2xlYW51cF9sb2NrLCAmd2FpdGVyX2xvY2spOwo+ICsJbG9jaygmd2FpdGVyX2xv Y2spOwo+ICsJcHRocmVhZF90ZXN0Y2FuY2VsKCk7CgpXaGF0J3MgdGhlIHB1cnBvc2Ugb2YgdGhp cyBwdGhyZWFkX3Rlc3RjYW5jZWwoKSBjYWxsPwoKPiAgCXB0aHJlYWRfa2lsbCh0aHJlYWQsIFNJ R1VTUjIpOwo+ICsJcHRocmVhZF9jYW5jZWwodGhyZWFkKTsKPiArCWxvY2tfY2xlYW51cF9wb3Ao JndhaXRlcl9sb2NrKTsKPiAgfQo+ICAKPiAgLyoKPiBAQCAtMTE0LDggKzExOSwxMyBAQCBzdGF0 aWMgaW50IHdhaXRldmVudGxvb3AgKHN0cnVjdCBldmVudF90aHJlYWQKPiAqd2FpdGVyKQo+ICAJ ZG1fdGFza19kZXN0cm95KHdhaXRlci0+ZG10KTsKPiAgCXdhaXRlci0+ZG10ID0gTlVMTDsKPiAg Cj4gLQlpZiAoIXIpCS8qIHdhaXQgaW50ZXJydXB0ZWQgYnkgc2lnbmFsICovCj4gLQkJcmV0dXJu IC0xOwo+ICsJaWYgKCFyKQl7IC8qIHdhaXQgaW50ZXJydXB0ZWQgYnkgc2lnbmFsLiBjaGVjayBm b3IKPiBjYW5jZWxsYXRpb24gKi8KPiArCQlwdGhyZWFkX2NsZWFudXBfcHVzaChjbGVhbnVwX2xv Y2ssICZ3YWl0ZXJfbG9jayk7Cj4gKwkJbG9jaygmd2FpdGVyX2xvY2spOwo+ICsJCXB0aHJlYWRf dGVzdGNhbmNlbCgpOwo+ICsJCWxvY2tfY2xlYW51cF9wb3AoJndhaXRlcl9sb2NrKTsKCk5pdHBp Y2s6IEknZCBwcmVmZXIgcHRocmVhZF9jbGVhbnVwX3BvcCgxKSBoZXJlLgoKUmVnYXJkcywKTWFy dGluCgoKPiArCQlyZXR1cm4gMTsgLyogSWYgd2Ugd2VyZW4ndCBjYW5jZWxsZWQsIGp1c3QKPiBy ZXNjaGVkdWxlICovCj4gKwl9Cj4gIAo+ICAJd2FpdGVyLT5ldmVudF9ucisrOwo+ICAKCi0tIApE ci4gTWFydGluIFdpbGNrIDxtd2lsY2tAc3VzZS5jb20+LCBUZWwuICs0OSAoMCk5MTEgNzQwNTMg MjEwNwpTVVNFIExpbnV4IEdtYkgsIEdGOiBGZWxpeCBJbWVuZMO2cmZmZXIsIEphbmUgU21pdGhh cmQsIEdyYWhhbSBOb3J0b24KSFJCIDIxMjg0IChBRyBOw7xybmJlcmcpCgotLQpkbS1kZXZlbCBt YWlsaW5nIGxpc3QKZG0tZGV2ZWxAcmVkaGF0LmNvbQpodHRwczovL3d3dy5yZWRoYXQuY29tL21h aWxtYW4vbGlzdGluZm8vZG0tZGV2ZWw=