All of lore.kernel.org
 help / color / mirror / Atom feed
From: Liam Girdwood <liam.r.girdwood@linux.intel.com>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org
Subject: Re: [PATCH] ASoC: topology: Fix kcontrol name string handling.
Date: Mon, 19 Mar 2018 19:32:24 +0000	[thread overview]
Message-ID: <1521487944.1923.71.camel@linux.intel.com> (raw)
In-Reply-To: <20180319070643.GD2186@sirena.org.uk>

On Mon, 2018-03-19 at 15:06 +0800, Mark Brown wrote:
> On Wed, Mar 14, 2018 at 08:43:19PM +0000, Liam Girdwood wrote:
> > Fix the topology kcontrol string handling so that string pointer
> > references are strdup()ed instead of being copied. This fixes issues
> > with kcontrol templates on the stack or ones that are freed. Remember
> > and free the strings too when topology is unloaded.
> 
> This doesn't seem to apply against current code (I was going to apply it
> as a fix but it doesn't seem to apply against -next either).
> _______________________________________________
> 

Ok will do, Fwiw I did them against -next when you were at ELC, I guess there
have been some updates between now and then.

Thanks

Liam

  reply	other threads:[~2018-03-19 19:32 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-03-14 20:43 [PATCH] ASoC: topology: Fix kcontrol name string handling Liam Girdwood
2018-03-19  7:06 ` Mark Brown
2018-03-19 19:32   ` Liam Girdwood [this message]
2018-03-20  0:57     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1521487944.1923.71.camel@linux.intel.com \
    --to=liam.r.girdwood@linux.intel.com \
    --cc=alsa-devel@alsa-project.org \
    --cc=broonie@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.