From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from list by lists.gnu.org with archive (Exim 4.71) id 1eyY6l-0000W7-KO for mharc-grub-devel@gnu.org; Wed, 21 Mar 2018 03:24:27 -0400 Received: from eggs.gnu.org ([2001:4830:134:3::10]:34837) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1eyY6k-0000Vz-2K for grub-devel@gnu.org; Wed, 21 Mar 2018 03:24:26 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1eyY6j-0000gz-56 for grub-devel@gnu.org; Wed, 21 Mar 2018 03:24:26 -0400 Received: from mail.gw90.de ([2a01:4f8:140:71f5::3]:60876) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_128_CBC_SHA1:16) (Exim 4.71) (envelope-from ) id 1eyY6i-0000g2-UN for grub-devel@gnu.org; Wed, 21 Mar 2018 03:24:25 -0400 Received: from [2a02:8109:b5c0:430e:fa51:1615:7b90:1d1b] (helo=mattotaupa) by mail.gw90.de with esmtpsa (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.84_2) (envelope-from ) id 1eyY6Z-0002a7-6i; Wed, 21 Mar 2018 07:24:15 +0000 Message-ID: <1521617037.7171.726.camel@users.sourceforge.net> Subject: Re: [PATCH 1/7] Cryptomount support LUKS detached header From: Paul Menzel To: John Lane , Daniel Kiper Cc: grub-devel@gnu.org Date: Wed, 21 Mar 2018 08:23:57 +0100 In-Reply-To: <593f8408-d54b-ab12-2660-f15d55418acb@jelmail.com> References: <20180314094504.6177-1-grub@jelmail.com> <20180314130551.GC21143@router-fw-old.local.net-space.pl> <593f8408-d54b-ab12-2660-f15d55418acb@jelmail.com> Content-Type: multipart/signed; micalg="pgp-sha1"; protocol="application/pgp-signature"; boundary="=-bGsFYB5nlYQ1SJmsBYMN" X-Mailer: Evolution 3.26.5-1+b1 Mime-Version: 1.0 X-detected-operating-system: by eggs.gnu.org: Genre and OS details not recognized. X-Received-From: 2a01:4f8:140:71f5::3 X-BeenThere: grub-devel@gnu.org X-Mailman-Version: 2.1.21 Precedence: list List-Id: The development of GNU GRUB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 21 Mar 2018 07:24:27 -0000 --=-bGsFYB5nlYQ1SJmsBYMN Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Dear John, Am Mittwoch, den 14.03.2018, 19:00 +0000 schrieb John Lane: > On 14/03/18 13:05, Daniel Kiper wrote: > > On Wed, Mar 14, 2018 at 09:44:58AM +0000, John Lane wrote: > > > From: John Lane > >=20 > > I have just skimmed through the series. First of all, most if not > > all patches beg for full blown commit messages. Just vague statements > > in the subject are insufficient for me. And please add patch 0 which > > introduces the series. git send-email --compose is your friend. >=20 > Sorry Daniel, this isn't something I do that often - submitting patches > to ML. Do you want me to resubmit them again, or is the below ok for you = ? [=E2=80=A6] Thank you very much for submitting these patches for review. Judging from the other comments, it looks like, you are going to send an updated series anyway, so I guess, you can wait until then, though expect another round then. I do not know, how well you are versed with git, but it=E2=80=99d be great,= if you added your messages below as =E2=80=9Creal=E2=80=9D commit messages. `g= it rebase -i origin/master` should do that for you. Just replace *pick* by *r*, for *r*eword, and add the commit messages there. So, as testing the review changes will take some time, I suggest you try to resend the patch series as soon as possible to get as much reviews as possible, so you can test everything, when you get to it. Thanks, Paul --=-bGsFYB5nlYQ1SJmsBYMN Content-Type: application/pgp-signature; name="signature.asc" Content-Description: This is a digitally signed message part Content-Transfer-Encoding: 7bit -----BEGIN PGP SIGNATURE----- iF0EABECAB0WIQQ8+w9d414FAVARIpk9fVorbA4dWAUCWrIIjwAKCRA9fVorbA4d WJNeAJ97tYgUXeXlib5NgtSluf3dPAha5wCeKuPCl44vpT8I2ObCsVQvYlMlThE= =Xqvn -----END PGP SIGNATURE----- --=-bGsFYB5nlYQ1SJmsBYMN--