From: Johannes Berg <johannes@sipsolutions.net>
To: Ben Caradoc-Davies <ben@transient.nz>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [PATCH] mac80211: add ieee80211_hw flag for QoS NDP support
Date: Wed, 21 Mar 2018 10:53:50 +0100 [thread overview]
Message-ID: <1521626030.2645.24.camel@sipsolutions.net> (raw)
In-Reply-To: <20180318235744.3527-1-ben@transient.nz>
On Mon, 2018-03-19 at 12:57 +1300, Ben Caradoc-Davies wrote:
> Commit 7b6ddeaf27ec ("mac80211: use QoS NDP for AP probing") adds an
> argument qos_ok to ieee80211_nullfunc_get to support QoS NDP. Despite
> the claim in the commit log "Change all the drivers to *not* allow
> QoS NDP for now, even though it looks like most of them should be OK
> with that", this commit enables QoS NDP in response to beacons (see
> change to mlme.c:ieee80211_send_nullfunc), causing ath9k_htc to lose
> IP connectivity. See:
> https://patchwork.kernel.org/patch/10241109/
> https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=891060
>
> This patch replaces the argument qos_ok of ieee80211_nullfunc_get
> with an ieee80211_hw flag that drivers can use to declare support for
> QoS NDP, allowing consistent behaviour between mlme.c and drivers.
A version identifier (as in "[PATCH v3]" in the subject) would help :-)
I've applied a modified version of this patch - it will also require
setting the new "broken" flag in the driver.
johannes
next prev parent reply other threads:[~2018-03-21 9:53 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-18 23:57 [PATCH] mac80211: add ieee80211_hw flag for QoS NDP support Ben Caradoc-Davies
2018-03-21 9:53 ` Johannes Berg [this message]
2018-03-21 23:11 ` Ben Caradoc-Davies
-- strict thread matches above, loose matches on Subject: below --
2018-03-18 23:38 Ben Caradoc-Davies
2018-03-18 23:50 ` Ben Caradoc-Davies
2018-03-19 10:46 ` kbuild test robot
2018-03-19 19:39 ` kbuild test robot
2018-03-17 20:51 Ben Caradoc-Davies
2018-03-17 20:53 ` Ben Caradoc-Davies
2018-03-18 22:12 ` kbuild test robot
2018-03-18 23:36 ` Ben Caradoc-Davies
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1521626030.2645.24.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=ben@transient.nz \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.