From: Johannes Berg <johannes@sipsolutions.net>
To: Denis Kenzior <denkenz@gmail.com>, linux-wireless@vger.kernel.org
Subject: Re: [RFC v5 4/9] cfg80211: Support all iftypes in autodisconnect_wk
Date: Wed, 21 Mar 2018 16:40:43 +0100 [thread overview]
Message-ID: <1521646843.2645.35.camel@sipsolutions.net> (raw)
In-Reply-To: <1fb6a106-2c9d-7ef4-c154-fa7c69602062@gmail.com> (sfid-20180321_162721_819338_BCC29E74)
On Wed, 2018-03-21 at 10:27 -0500, Denis Kenzior wrote:
>
> cfg80211_leave also messes with scans and autodisconnect_wk didn't. So
> I played it safe as I didn't want to introduce any silent semantic changes.
Makes sense, but we could pass an argument and avoid duplicating the
code?
> Also, cfg80211_leave uses stop_ap/leave_ibss with notify argument being
> true, while I thought it made more sense to use false (as there's
> arguably nobody left to pay attention to it) and to be consistent with
> nl80211_stop_ap and nl80211_leave_ibss which also use false.
Fair enough.
> I don't see an issue with using cfg80211_leave though. Just tell me
> which way you prefer.
It just seemed duplicated, ultimately I don't think I care all that
much.
johannes
next prev parent reply other threads:[~2018-03-21 15:40 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-13 21:59 [RFC v5 0/9] EAPoL over NL80211 Denis Kenzior
2018-03-13 21:59 ` [RFC v5 1/9] nl80211: Add CMD_CONTROL_PORT_FRAME API Denis Kenzior
2018-03-13 21:59 ` [RFC v5 2/9] nl80211: Implement TX of control port frames Denis Kenzior
2018-03-13 21:59 ` [RFC v5 3/9] nl80211: Add CONTROL_PORT_OVER_NL80211 attribute Denis Kenzior
2018-03-21 7:47 ` Johannes Berg
2018-03-21 15:01 ` Denis Kenzior
2018-03-21 15:09 ` Johannes Berg
2018-03-13 21:59 ` [RFC v5 4/9] cfg80211: Support all iftypes in autodisconnect_wk Denis Kenzior
2018-03-21 7:46 ` Johannes Berg
2018-03-21 15:27 ` Denis Kenzior
2018-03-21 15:40 ` Johannes Berg [this message]
2018-03-13 21:59 ` [RFC v5 5/9] nl80211: Add SOCKET_OWNER support to JOIN_IBSS Denis Kenzior
2018-03-13 21:59 ` [RFC v5 6/9] nl80211: Add SOCKET_OWNER support to JOIN_MESH Denis Kenzior
2018-03-13 21:59 ` [RFC v5 7/9] nl80211: Add SOCKET_OWNER support to START_AP Denis Kenzior
2018-03-13 21:59 ` [RFC v5 8/9] mac80211: Add support for tx_control_port Denis Kenzior
2018-03-13 21:59 ` [RFC v5 9/9] mac80211: Send control port frames over nl80211 Denis Kenzior
2018-03-21 15:13 ` [RFC v5 0/9] EAPoL over NL80211 Johannes Berg
2018-03-21 15:18 ` Denis Kenzior
2018-03-22 10:28 ` Johannes Berg
2018-03-22 13:54 ` Denis Kenzior
2018-03-23 8:04 ` Johannes Berg
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1521646843.2645.35.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=denkenz@gmail.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.