From: Johannes Berg <johannes@sipsolutions.net>
To: Arend van Spriel <arend.vanspriel@broadcom.com>,
dimitrysh@google.com, linux-wireless@vger.kernel.org
Cc: franky.lin@broadcom.com
Subject: Re: [PATCH] brcmfmac: Add timestamp to scan results report
Date: Thu, 22 Mar 2018 12:48:24 +0100 [thread overview]
Message-ID: <1521719304.19621.8.camel@sipsolutions.net> (raw)
In-Reply-To: <5AB388FE.2040609@broadcom.com> (sfid-20180322_114417_668509_02BCB500)
On Thu, 2018-03-22 at 11:44 +0100, Arend van Spriel wrote:
> I recall a similar attempt for another driver, but I think the timestamp
> should really be the TSF of the beacon/proberesp received. As you
> already Cc-ed Johannes explicitly maybe he can clarify what is needed
> here as I do not recall the details. ;-)
Yes, this should be "tsf", it's actually labelled explicitly as such. I
know Android used to get this wrong and *even test* it wrongly, but
that's no excuse.
However, should switch this to cfg80211_inform_bss_data() and use the
timestamp set up here to fill the cfg80211_inform_bss::boottime_ns
value. That's also sent to userspace in the proper way for this.
johannes
prev parent reply other threads:[~2018-03-22 11:48 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-21 22:44 [PATCH] brcmfmac: Add timestamp to scan results report dimitrysh
2018-03-22 10:44 ` Arend van Spriel
2018-03-22 11:48 ` Johannes Berg [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1521719304.19621.8.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=arend.vanspriel@broadcom.com \
--cc=dimitrysh@google.com \
--cc=franky.lin@broadcom.com \
--cc=linux-wireless@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.