Re: [MPTCP] [RFC 1/1] Add MPTCP code to work with the modified TCP code

[Krystad, Peter <peter.krystad at intel.com>]

[-- Attachment #1: Type: text/plain, Size: 5487 bytes --]

On Thu, 2018-03-22 at 11:12 -0700, Rao Shoaib wrote:
> 
> On 03/21/2018 02:22 PM, Rao Shoaib wrote:
> > 
> > 
> > On 03/21/2018 01:18 PM, Krystad, Peter wrote:
> > > Hi Rao -
> > > 
> > > On Thu, 2018-03-01 at 12:02 -0800, Rao Shoaib wrote:
> > > > On 03/01/2018 11:20 AM, Christoph Paasch wrote:
> > > > > On 28/02/18 - 16:49:52, rao.shoaib(a)oracle.com wrote:
> > > > > > From: Rao Shoaib <rao.shoaib(a)oracle.com>
> > > > > > 
> > > > > > Signed-off-by: Rao Shoaib <rao.shoaib(a)oracle.com>
> > > > > > ---
> > > > > >    include/net/mptcp.h          | 1474
> > > > > > +++++++++++++++++++++
> > > > > >    include/net/mptcp_v4.h       |   56 +
> > > > > >    include/net/mptcp_v6.h       |   56 +
> > > > > >    include/net/netns/mptcp.h    |   52 +
> > > > > >    net/Kconfig                  |    1 +
> > > > > >    net/Makefile                 |    1 +
> > > > > >    net/mptcp/Kconfig            |  129 ++
> > > > > >    net/mptcp/Makefile           |   22 +
> > > > > >    net/mptcp/mptcp_balia.c      |  267 ++++
> > > > > >    net/mptcp/mptcp_binder.c     |  487 +++++++
> > > > > >    net/mptcp/mptcp_coupled.c    |  270 ++++
> > > > > >    net/mptcp/mptcp_ctrl.c       | 2981
> > > > > > ++++++++++++++++++++++++++++++++++++++++++
> > > > > >    net/mptcp/mptcp_fullmesh.c   | 1877
> > > > > > ++++++++++++++++++++++++++
> > > > > >    net/mptcp/mptcp_input.c      | 2970
> > > > > > +++++++++++++++++++++++++++++++++++++++++
> > > > > >    net/mptcp/mptcp_ipv4.c       |  345 +++++
> > > > > >    net/mptcp/mptcp_ipv6.c       |  316 +++++
> > > > > >    net/mptcp/mptcp_ndiffports.c |  169 +++
> > > > > >    net/mptcp/mptcp_ofo_queue.c  |  177 +++
> > > > > >    net/mptcp/mptcp_olia.c       |  309 +++++
> > > > > >    net/mptcp/mptcp_output.c     | 1837
> > > > > > ++++++++++++++++++++++++++
> > > > > >    net/mptcp/mptcp_pm.c         |  178 +++
> > > > > >    net/mptcp/mptcp_redundant.c  |  268 ++++
> > > > > >    net/mptcp/mptcp_rr.c         |  301 +++++
> > > > > >    net/mptcp/mptcp_sched.c      |  597 +++++++++
> > > > > >    net/mptcp/mptcp_wvegas.c     |  268 ++++
> > > > > >    25 files changed, 15408 insertions(+)
> > > > > 
> > > > > Please read the sections "Separate your changes" and "E-mail
> > > > > size"
> > > > > of
> > > > > process/submitting-patches.rst.
> > > > 
> > > > If you are worried about the size than do not use it. I am not
> > > > asking
> > > > for review, just posting it in case someone wants to try out
> > > > MPTCP
> > > > with
> > > > my changes.
> > > > 
> > > 
> > > It seems now you are asking for a review. Can we get this as a
> > > patch
> > > relative to the existing MPTCP implementation so we can see your
> > > work?
> > > 
> > > Thanks,
> > > 
> > > Peter.
> > > 
> 
> Peter I may have mis-understood your question. In case you want to
> see 
> what was changed in MPTCP you can compare what I posted with 
> mptcp_v0.91. If you want I can provide you the diff or a patch.
> 
> Shoaib.

That is what I was hoping to see (the differences against the existing
MPTCP implementation). A patch would be great.

Thanks,

Peter.


> > Hi Peter,
> > 
> > Thanks a lot for stepping up, you are brave :-).
> > Yes, I am asking for a review but only for the core networking 
> > changes. I have not created a patch for MPTCP because the code is
> > not 
> > formatted properly. I have provided the MPTCP code that I used for 
> > testing. The code base for MPTCP used is a little old but initially
> > we 
> > only plan to support very basic MPTCP operations. So I suggest
> > that 
> > you just use the MPTCP code that I posted. We do not intend to
> > provide 
> > an implementation that is fully compatible with the current MPTCP 
> > implementation, any extra features needed will be added as needed. 
> > However, I do not see any issues.
> > 
> > Also note we do not expect this patch series to be accepted (It
> > would 
> > be great if it is :-)). We only want to start a conversation with
> > the 
> > upstream folks on the direction to take. The review I am looking
> > for 
> > are issues that would prevent TCP code to be independently
> > enhanced, 
> > impact on regular TCP performance (without MPTCP) and ease of
> > build 
> > without requiring any MPTCP file and of course readability of the 
> > code. I think that is all that the upstream folks care. If
> > something 
> > else should be added to the list please suggest.
> > 
> > The code uses function pointers as that was the most clean
> > interface, 
> > but due to the recent security issues the performance enhancements
> > for 
> > indirect branch predictions for certain CPU's have been turned off 
> > (They were ON before). I am in the process of changing the code to
> > use 
> > a macro that activates when MPTCP is compiled and does a check on
> > the 
> > socket. As someone commented, function pointers are integral to 
> > current software, so there will be a solution and we will revert
> > back.
> > 
> > Please do not hesitate to contact me.
> > 
> > Thanks a lot,
> > 
> > Shoaib
> > 
> > 
> > 
> > _______________________________________________
> > mptcp mailing list
> > mptcp(a)lists.01.org
> > https://lists.01.org/mailman/listinfo/mptcp
> 
> _______________________________________________
> mptcp mailing list
> mptcp(a)lists.01.org
> https://lists.01.org/mailman/listinfo/mptcp