Re: [PATCH 2/2] fpga: lattice machxo2: Add Lattice MachXO2 support

[Joe Perches <joe@perches.com>]

On Thu, 2018-03-22 at 16:32 -0500, Alan Tull wrote:
> On Wed, Mar 21, 2018 at 1:04 PM, Joe Perches <joe@perches.com> wrote:
> > On Wed, 2018-03-21 at 18:35 +0100, Paolo Pisati wrote:
> > > This patch adds support to the FPGA manager for programming
> > > MachXO2 device’s internal flash memory, via slave SPI.
> > 
> > style trivia:
> > 
> > > diff --git a/drivers/fpga/machxo2-spi.c b/drivers/fpga/machxo2-spi.c
> > 
> > []
> > > +static int get_status(struct spi_device *spi, unsigned long *status)
> > > +{
> > > +     struct spi_message msg;
> > > +     struct spi_transfer rx, tx;
> > > +     u8 cmd[] = LSC_READ_STATUS;
> > 
> > static const u8 cmd[]
> > here and everywhere else as all the tx_buf assignments
> > of cmd are to const void *
> 
> Why *static* const u8 cmd[]?

So various compilers don't reload it on each call.