From mboxrd@z Thu Jan 1 00:00:00 1970 From: Martin Wilck Subject: Re: [PATCH v2 1/2] libmultipath: don't reject maps with undefined prio Date: Fri, 23 Mar 2018 11:30:22 +0100 Message-ID: <1521801022.13100.41.camel@suse.com> References: <20180321093419.9295-1-mwilck@suse.com> <20180322235225.GE3103@octiron.msp.redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180322235225.GE3103@octiron.msp.redhat.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com To: Benjamin Marzinski Cc: dm-devel@redhat.com List-Id: dm-devel.ids T24gRG8sIDIwMTgtMDMtMjIgYXQgMTg6NTIgLTA1MDAsIEJlbmphbWluIE1hcnppbnNraSB3cm90 ZToKPiBPbiBXZWQsIE1hciAyMSwgMjAxOCBhdCAxMDozNDoxOEFNICswMTAwLCBNYXJ0aW4gV2ls Y2sgd3JvdGU6Cj4gPiBsaWJtdWx0aXBhdGgncyBwcmlvIHJvdXRpbmVzIGNhbiBkZWFsIHdpdGgg cHAtPnByaW9yaXR5ID09Cj4gPiBQUklPX1VOREVGCj4gPiBqdXN0IGZpbmUuIFBSSU9fVU5ERUYg aXMganVzdCBhIHZlcnkgbG93IHByaW9yaXR5LiBTbyB0aGVyZSdzCj4gPiBubyByZWFzb24gdG8g cmVqZWN0IHNldHRpbmcgdXAgYSBtdWx0aXBhdGggbWFwIGJlY2F1c2UgcGF0aHMgaGF2ZQo+ID4g dW5kZWZpbmVkIHByaW9yaXR5Lgo+ID4gCj4gCj4gVGhlIHByb2JsZW0gd2l0aCB0aGlzIGlzIHRo YXQgcHJlc3VtYWJseSwgaWYgdGhlcmUgaXMgYSBwcmlvcml0aXplcgo+IHNldCwKPiB0aGVuIHRo ZSBwYXRocyBhcmVuJ3Qgc3VwcG9zZWQgdG8gYmUgaW4gdGhlIHNhbWUgcGF0aGdyb3VwLiAgSWYg dGhpcwo+IGlzCj4gdGhlIGNhc2UgYW5kIHlvdSBlbmQgdXAgc2V0dGluZyBhbGwgdGhlIHBhdGhz IHRvIHRoZSBzYW1lIHBhdGhncm91cAo+IGJlY2F1c2UgdGhlIHByaW9yaXRpemVyIGlzIHdyb25n LCB5b3Ugd2lsbCBsaWtlbHkgaGF2ZSBhIGJhZAo+IGV4cGVyaWVuY2UuCgpTdXJlLiBUaGlzIGlz IG9idmlvdXNseSBhbiB1bmZvcnR1bmF0ZSBjb3JuZXItY2FzZS4gVGhlIGdvb2QgbmV3cyBpcwp0 aGF0IGl0IGhhcHBlbnMgdmVyeSByYXJlbHkuIFRoZSBkZWZhdWx0IHNldHRpbmcgZm9yIHByaW8g aXMgImNvbnN0IiwKd2hpY2ggY2FuJ3QgZmFpbCwgc28gKGRpc3JlZ2FyZGluZyBGQUlMRUQgcGF0 aHMpIHRoaXMgY2FuIGhhcHBlbiBvbmx5CmZvciBoYXJkd2FyZSB0aGF0IGNsYWltcyB0byBzdXBw b3J0IEFMVUEgKG9yIHNvbWUgb3RoZXIgYWxnb3JpdGhtKSBidXQKYWN0dWFsbHkgZG9lc24ndCAo b3IgZmFpbHMgQUxVQSByZXBlYXRlZGx5KS4gVGhlcmUncyBvbmUgY29uY3JldGUKZXhhbXBsZSBv ZiBzdWNoIGhhcmR3YXJlIChjZXJ0YWluIHZhcmlhbnRzIG9mIElCTSBJUFIpIHRoYXQgaGFzCm1v dGl2YXRlZCB0aGlzIHBhdGNoLgoKVGhlIHJhdGlvbmFsZSBmb3IgbXkgcGF0Y2ggaXMgdGhhdCBt dWx0aXBhdGgtdG9vbHMgY3VycmVudGx5IGJlaGF2ZQppbmNvbnNpc3RlbnRseS4gUHJpbyBjYWxs cyBhcmUgYWxsb3dlZCB0byBmYWlsLiBJZiBwcmlvIGRldGVjdGlvbiB3b3Jrcwppbml0aWFsbHks IGJ1dCBmYWlscyBsYXRlciBmb3Igd2hhdGV2ZXIgcmVhc29uIChlLmcuIEFMVUEgY2FsbHMKZmFp bGluZyksIG11bHRpcGF0aGQgaGFuZGxlcyB0aGF0ICJncmFjZWZ1bGx5IiBieSBhc3NpZ25pbmcg c3VjaCBwYXRocwpQUklPX1VOREVGID09IC0xLiBUaGlzICJ3b3JrcyBmaW5lIiAoeW91ciBjb25j ZXJucyBhcHBseSkgZXZlbiBpZiB0aGUKcHJpbyBjYWxsIGZhaWxzIGZvciBldmVyeSBwYXRoIG9m IHRoZSBtYXAuCgpMaWtld2lzZSwgZXZlbiBtYXBzIGZvciB3aGljaCBnZXRfcHJpbygpIGFsd2F5 cyBmYWlscyBmb3IgZXZlcnkgcGF0aApjYW4gYmUgc2V0IHVwIG1hbnVhbGx5LCB1c2luZyAibXVs dGlwYXRoZCBhZGQgbWFwICRXV0lEIi4gVGhlIG9ubHkgY2FzZQp3aGVyZSBtdWx0aXBhdGgvbXVs dGlwYXRoZCByZWZ1c2UgdG8gc2V0IHVwIHRoaXMga2luZCBvZiBtYXAgaXMKY29hbGVzY2VfcGF0 aHMoKSwgaS5lLiBhdXRvZGV0ZWN0aW9uLiBXZSBoYXZlIGFuIGFkZGl0aW9uYWwsCnVuZG9jdW1l bnRlZCAiYmxhY2tsaXN0IiBjcml0ZXJpb24gaGVyZSAtIG1hcHMgdGhhdCBmYWlsIGdldF9wcmlv LCBldmVuCmlmIGp1c3QgZm9yIGEgc2luZ2xlIHBhdGgsIHdvbid0IGJlIHNldCB1cCBhdXRvbWF0 aWNhbGx5LiBUaGF0IGRvZXNuJ3QKbWFrZSBhIGxvdCBvZiBzZW5zZSB0byBtZS4KCj4gRWl0aGVy IHlvdSB3aWxsIGZyZXF1ZW50bHkgYmUgd3JpdGluZyB0byBhIG5vbi1vcHRpbWl6ZWQgcGF0aCAo d2hpY2gKPiBjYW4KPiBhdXRvLXRyZXNwYXNzIGFuZCBiZWNvbWUgYW4gb3B0aW1pemVkIG9uZSBp biBzb21lIGFycmF5cywgY2F1c2luZwo+IGhvcnJpYmxlIHBpbmctcG9uZ2luZyksIG9yIHNvbWUg b2YgeW91ciBwYXRocyB3aWxsIGp1c3QgYWx3YXlzIGtlZXAKPiBnZXR0aW5nIHJlc3RvcmVkIGFu ZCB0aGVuIGZhaWxlZCwgc2luY2UgdGhleSByZXF1aXJlIGEgbWFudWFsCj4gdHJlc3Bhc3MKPiB0 byBiZSBhY3R1YWxseSB1c2FibGUsIGJ1dCBnaG9zdCBwYXRocyBhcmUgdHJlYXRlZCBhcyB1c2Fi bGUgYnkgdGhlCj4ga2VybmVsLgo+IAo+IElmIHlvdSBqdXN0IHNldCB0aGUgcHJpb3J0aXplciBm b3IgdGhpcyBkZXZpY2UgdG8gY29uc3QgKG9yIHdoYXRldmVyCj4gbWFrZSBzZW5zZSBpZiB0aGUg ZGV2aWNlIGlzbid0IGFsdWEpIGFuZCBoYXZlIGRldGVjdF9wcmlvIGVuYWJsZWQsCj4gd29uJ3QK PiBpdCBjb3JyZWN0bHkgZGV0ZWN0IGFuIGFsdWEgcHJpb3JpdGl6ZXIgd2hlbiBpdCBpcyBzdXBw b3J0ZWQsIGFuZAo+IGZhaWxiYWNrIHRvIGNvbnN0IHdoZW4gbm90PwoKTXkgZmlyc3QgaWRlYSB3 YXMgc2ltaWxhciwgYnV0IG5vLCBBRkFJQ1MgdGhhdCBkb2Vzbid0IGhhcHBlbi4gT25jZSB5b3UK Y2hhbmdlIHBwLT5wcmlvLCBpdCByZW1haW5zICJjb25zdCIgdW50aWwgdGhlIG5leHQgcmVjb25m aWd1cmUoKSwgd2hpY2gKbWF5IG1lYW4gIm5ldmVyIi4gVGhlcmVmb3JlIG15IHBhdGNoICh2Mikg ZG9lc24ndCB0b3VjaCBwcC0+cHJpby4gSWYKdGhlIGZhaWx1cmUgaXMgdGVtcG9yYXJ5LCBwcC0+ cHJpb3JpdHkgd2lsbCBldmVudHVhbGx5IGJlIHJlLWNhbGN1bGF0ZWQgCmNvcnJlY3RseSAobm90 ZSB0aGF0IGdldF9wcmlvKCkgaXMgYWx3YXlzIGNhbGxlZCBieSBwYXRoaW5mbygpIGlmIApwcC0+ cHJpb3JpdHkgPT0gUFJJT19VTkRFRikuIElmIHRoZSBmYWlsdXJlIGlzIHBlcm1hbmVudCwgcHAt PnByaW9yaXR5CnN0YXlzIGF0ICJjb25zdCAtMSIsIGFuZCB0aGF0J3Mgb2suCgpJdCB3b3VsZCBi ZSBwb3NzaWJsZSB0byBjcmVhdGUgYSBjb21wbGV4IHNvbHV0aW9uIHdpdGggbXVsdGlwbGUKcHJp b3JpdGl6ZXJzIGFuZCBmYWxsYmFjayBhbGdvcml0aG1zLCBidXQgSU1ITyB0aGF0IHdvdWxkIGJl Cm92ZXJlbmdpbmVlcmVkIGZvciBhIHJhcmUgYW5kIHJhdGhlciBwYXRob2xvZ2ljYWwgY2FzZSBs aWtlIHRoaXMuCgpSZWdhcmRzLApNYXJ0aW4KCj4gCj4gLUJlbgo+IAo+ID4gU2lnbmVkLW9mZi1i eTogTWFydGluIFdpbGNrIDxtd2lsY2tAc3VzZS5jb20+Cj4gPiAtLS0KPiA+ICBsaWJtdWx0aXBh dGgvY29uZmlndXJlLmMgfCA1IC0tLS0tCj4gPiAgMSBmaWxlIGNoYW5nZWQsIDUgZGVsZXRpb25z KC0pCj4gPiAKPiA+IGRpZmYgLS1naXQgYS9saWJtdWx0aXBhdGgvY29uZmlndXJlLmMgYi9saWJt dWx0aXBhdGgvY29uZmlndXJlLmMKPiA+IGluZGV4IGZhNmUyMWNiMzFhZi4uYmIzZDg3NzE1OTJk IDEwMDY0NAo+ID4gLS0tIGEvbGlibXVsdGlwYXRoL2NvbmZpZ3VyZS5jCj4gPiArKysgYi9saWJt dWx0aXBhdGgvY29uZmlndXJlLmMKPiA+IEBAIC05OTMsOSArOTkzLDYgQEAgaW50IGNvYWxlc2Nl X3BhdGhzIChzdHJ1Y3QgdmVjdG9ycyAqIHZlY3MsCj4gPiB2ZWN0b3IgbmV3bXAsIGNoYXIgKiBy ZWZ3d2lkLAo+ID4gIAkJCWNvbnRpbnVlOwo+ID4gIAkJfQo+ID4gIAo+ID4gLQkJaWYgKHBwMS0+ cHJpb3JpdHkgPT0gUFJJT19VTkRFRikKPiA+IC0JCQltcHAtPmFjdGlvbiA9IEFDVF9SRUpFQ1Q7 Cj4gPiAtCj4gPiAgCQlpZiAoIW1wcC0+cGF0aHMpIHsKPiA+ICAJCQljb25kbG9nKDAsICIlczog c2tpcCBjb2FsZXNjZSAobm8gcGF0aHMpIiwKPiA+IG1wcC0+YWxpYXMpOwo+ID4gIAkJCXJlbW92 ZV9tYXAobXBwLCB2ZWNzLCAwKTsKPiA+IEBAIC0xMDIxLDggKzEwMTgsNiBAQCBpbnQgY29hbGVz Y2VfcGF0aHMgKHN0cnVjdCB2ZWN0b3JzICogdmVjcywKPiA+IHZlY3RvciBuZXdtcCwgY2hhciAq IHJlZnd3aWQsCj4gPiAgCQkJCQltcHAtPnNpemUpOwo+ID4gIAkJCQltcHAtPmFjdGlvbiA9IEFD VF9SRUpFQ1Q7Cj4gPiAgCQkJfQo+ID4gLQkJCWlmIChwcDItPnByaW9yaXR5ID09IFBSSU9fVU5E RUYpCj4gPiAtCQkJCW1wcC0+YWN0aW9uID0gQUNUX1JFSkVDVDsKPiA+ICAJCX0KPiA+ICAJCXZl cmlmeV9wYXRocyhtcHAsIHZlY3MpOwo+ID4gIAo+ID4gLS0gCj4gPiAyLjE2LjEKPiAKPiAKCi0t IApEci4gTWFydGluIFdpbGNrIDxtd2lsY2tAc3VzZS5jb20+LCBUZWwuICs0OSAoMCk5MTEgNzQw NTMgMjEwNwpTVVNFIExpbnV4IEdtYkgsIEdGOiBGZWxpeCBJbWVuZMO2cmZmZXIsIEphbmUgU21p dGhhcmQsIEdyYWhhbSBOb3J0b24KSFJCIDIxMjg0IChBRyBOw7xybmJlcmcpCgotLQpkbS1kZXZl bCBtYWlsaW5nIGxpc3QKZG0tZGV2ZWxAcmVkaGF0LmNvbQpodHRwczovL3d3dy5yZWRoYXQuY29t L21haWxtYW4vbGlzdGluZm8vZG0tZGV2ZWw=