From mboxrd@z Thu Jan 1 00:00:00 1970 From: Rick Chang Subject: Re: [PATCH] [media] vcodec: fix error return value from mtk_jpeg_clk_init() Date: Fri, 23 Mar 2018 19:07:24 -0700 Message-ID: <1521857244.3372.12.camel@mediatek.com> References: Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Ryder Lee , Mauro Carvalho Chehab , Hans Verkuil Cc: Bin Liu , linux-mediatek@lists.infradead.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org List-Id: linux-mediatek@lists.infradead.org T24gRnJpLCAyMDE4LTAzLTIzIGF0IDExOjQ0ICswODAwLCBSeWRlciBMZWUgd3JvdGU6Cj4gVGhl IGVycm9yIHJldHVybiB2YWx1ZSBzaG91bGQgYmUgZml4ZWQgYXMgaXQgbWF5IHJldHVybiBFUFJP QkVfREVGRVIuCj4gCj4gQ2M6IFJpY2sgQ2hhbmcgPHJpY2suY2hhbmdAbWVkaWF0ZWsuY29tPgo+ IENjOiBCaW4gTGl1IDxiaW4ubGl1QG1lZGlhdGVrLmNvbT4KPiBTaWduZWQtb2ZmLWJ5OiBSeWRl ciBMZWUgPHJ5ZGVyLmxlZUBtZWRpYXRlay5jb20+Cj4gLS0tCj4gwqBkcml2ZXJzL21lZGlhL3Bs YXRmb3JtL210ay1qcGVnL210a19qcGVnX2NvcmUuYyB8IDQgKystLQo+IMKgMSBmaWxlIGNoYW5n ZWQsIDIgaW5zZXJ0aW9ucygrKSwgMiBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9tZWRpYS9wbGF0Zm9ybS9tdGstanBlZy9tdGtfanBlZ19jb3JlLmMKPiBiL2RyaXZlcnMv bWVkaWEvcGxhdGZvcm0vbXRrLWpwZWcvbXRrX2pwZWdfY29yZS5jCj4gaW5kZXggMjI2ZjkwOC4u YWYxN2FhYSAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL21lZGlhL3BsYXRmb3JtL210ay1qcGVnL210 a19qcGVnX2NvcmUuYwo+ICsrKyBiL2RyaXZlcnMvbWVkaWEvcGxhdGZvcm0vbXRrLWpwZWcvbXRr X2pwZWdfY29yZS5jCj4gQEAgLTEwODEsMTEgKzEwODEsMTEgQEAgc3RhdGljIGludCBtdGtfanBl Z19jbGtfaW5pdChzdHJ1Y3QKPiBtdGtfanBlZ19kZXYgKmpwZWcpCj4gwqAKPiDCoAlqcGVnLT5j bGtfamRlYyA9IGRldm1fY2xrX2dldChqcGVnLT5kZXYsICJqcGdkZWMiKTsKPiDCoAlpZiAoSVNf RVJSKGpwZWctPmNsa19qZGVjKSkKPiAtCQlyZXR1cm4gLUVJTlZBTDsKPiArCQlyZXR1cm4gUFRS X0VSUihqcGVnLT5jbGtfamRlYyk7Cj4gwqAKPiDCoAlqcGVnLT5jbGtfamRlY19zbWkgPSBkZXZt X2Nsa19nZXQoanBlZy0+ZGV2LCAianBnZGVjLXNtaSIpOwo+IMKgCWlmIChJU19FUlIoanBlZy0+ Y2xrX2pkZWNfc21pKSkKPiAtCQlyZXR1cm4gLUVJTlZBTDsKPiArCQlyZXR1cm4gUFRSX0VSUihq cGVnLT5jbGtfamRlY19zbWkpOwo+IMKgCj4gwqAJcmV0dXJuIDA7Cj4gwqB9CgpBY2tlZC1ieTog UmljayBDaGFuZyA8cmljay5jaGFuZ0BtZWRpYXRlay5jb20+CgpfX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fXwpsaW51eC1hcm0ta2VybmVsIG1haWxpbmcgbGlz dApsaW51eC1hcm0ta2VybmVsQGxpc3RzLmluZnJhZGVhZC5vcmcKaHR0cDovL2xpc3RzLmluZnJh ZGVhZC5vcmcvbWFpbG1hbi9saXN0aW5mby9saW51eC1hcm0ta2VybmVsCg== From mboxrd@z Thu Jan 1 00:00:00 1970 From: rick.chang@mediatek.com (Rick Chang) Date: Fri, 23 Mar 2018 19:07:24 -0700 Subject: [PATCH] [media] vcodec: fix error return value from mtk_jpeg_clk_init() In-Reply-To: References: Message-ID: <1521857244.3372.12.camel@mediatek.com> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Fri, 2018-03-23 at 11:44 +0800, Ryder Lee wrote: > The error return value should be fixed as it may return EPROBE_DEFER. > > Cc: Rick Chang > Cc: Bin Liu > Signed-off-by: Ryder Lee > --- > ?drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 4 ++-- > ?1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c > b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c > index 226f908..af17aaa 100644 > --- a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c > +++ b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c > @@ -1081,11 +1081,11 @@ static int mtk_jpeg_clk_init(struct > mtk_jpeg_dev *jpeg) > ? > ? jpeg->clk_jdec = devm_clk_get(jpeg->dev, "jpgdec"); > ? if (IS_ERR(jpeg->clk_jdec)) > - return -EINVAL; > + return PTR_ERR(jpeg->clk_jdec); > ? > ? jpeg->clk_jdec_smi = devm_clk_get(jpeg->dev, "jpgdec-smi"); > ? if (IS_ERR(jpeg->clk_jdec_smi)) > - return -EINVAL; > + return PTR_ERR(jpeg->clk_jdec_smi); > ? > ? return 0; > ?} Acked-by: Rick Chang From mboxrd@z Thu Jan 1 00:00:00 1970 Return-path: Received: from mailgw01.mediatek.com ([210.61.82.183]:8199 "EHLO mailgw01.mediatek.com" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1750789AbeCXCHb (ORCPT ); Fri, 23 Mar 2018 22:07:31 -0400 Message-ID: <1521857244.3372.12.camel@mediatek.com> Subject: Re: [PATCH] [media] vcodec: fix error return value from mtk_jpeg_clk_init() From: Rick Chang To: Ryder Lee , Mauro Carvalho Chehab , Hans Verkuil CC: , , , , Bin Liu Date: Fri, 23 Mar 2018 19:07:24 -0700 In-Reply-To: References: Content-Type: text/plain; charset="UTF-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: linux-media-owner@vger.kernel.org List-ID: On Fri, 2018-03-23 at 11:44 +0800, Ryder Lee wrote: > The error return value should be fixed as it may return EPROBE_DEFER. > > Cc: Rick Chang > Cc: Bin Liu > Signed-off-by: Ryder Lee > --- >  drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c | 4 ++-- >  1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c > b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c > index 226f908..af17aaa 100644 > --- a/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c > +++ b/drivers/media/platform/mtk-jpeg/mtk_jpeg_core.c > @@ -1081,11 +1081,11 @@ static int mtk_jpeg_clk_init(struct > mtk_jpeg_dev *jpeg) >   >   jpeg->clk_jdec = devm_clk_get(jpeg->dev, "jpgdec"); >   if (IS_ERR(jpeg->clk_jdec)) > - return -EINVAL; > + return PTR_ERR(jpeg->clk_jdec); >   >   jpeg->clk_jdec_smi = devm_clk_get(jpeg->dev, "jpgdec-smi"); >   if (IS_ERR(jpeg->clk_jdec_smi)) > - return -EINVAL; > + return PTR_ERR(jpeg->clk_jdec_smi); >   >   return 0; >  } Acked-by: Rick Chang