From: Johannes Berg <johannes@sipsolutions.net>
To: Tamizh chelvam <tamizhr@codeaurora.org>
Cc: linux-wireless@vger.kernel.org
Subject: Re: [RFC 0/3] cfg80211/mac80211: Notify proper sta opmode change value
Date: Tue, 27 Mar 2018 14:56:34 +0200 [thread overview]
Message-ID: <1522155394.3050.9.camel@sipsolutions.net> (raw)
In-Reply-To: <1522133296-2583-1-git-send-email-tamizhr@codeaurora.org>
On Tue, 2018-03-27 at 12:18 +0530, Tamizh chelvam wrote:
> Currently bw and smps_mode are u8 type value in sta_opmode_info
> structure. This values filled in mac80211 from ieee80211_sta_rx_bandwidth
> and ieee80211_smps_mode. These enum values are specific to mac80211 and
> userspace/cfg80211 doesn't know about that. This patchset change its
> data type in the sta_opmode_info structure and mapping from mac80211
> specific enum to nl80211 enum value.
Good catch.
> Tamizh chelvam (3):
> cfg80211: fix data type of sta_opmode_info parameter
> mac80211: Use proper smps_mode enum in sta opmode event
> mac80211: Use proper chan_width enum in sta opmode event
>
> Note :
> * Is this mac80211 approach sufficient ? or whether some more
> complete cleanup would be preferred ?
Not sure what you mean? The patches look good to me.
johannes
next prev parent reply other threads:[~2018-03-27 12:56 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-27 6:48 [RFC 0/3] cfg80211/mac80211: Notify proper sta opmode change value Tamizh chelvam
2018-03-27 6:48 ` [RFC 1/3] cfg80211: fix data type of sta_opmode_info parameter Tamizh chelvam
2018-03-27 6:48 ` [RFC 2/3] mac80211: Use proper smps_mode enum in sta opmode event Tamizh chelvam
2018-03-27 6:48 ` [RFC 3/3] mac80211: Use proper chan_width " Tamizh chelvam
2018-03-27 12:56 ` Johannes Berg [this message]
2018-03-27 13:12 ` [RFC 0/3] cfg80211/mac80211: Notify proper sta opmode change value Tamizh chelvam
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1522155394.3050.9.camel@sipsolutions.net \
--to=johannes@sipsolutions.net \
--cc=linux-wireless@vger.kernel.org \
--cc=tamizhr@codeaurora.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.