diff for duplicates of <1522249966.2593.14.camel@synopsys.com> diff --git a/a/1.txt b/N1/1.txt index 06c9e41..9cdcaff 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -51,7 +51,3 @@ Tested-by: Evgeniy Didin <Evgeniy.Didin@synopsys.com> > /* GFP_DMA32 and GFP_DMA are no ops without the corresponding zones: */ > if (dev->coherent_dma_mask <= DMA_BIT_MASK(ARCH_ZONE_DMA_BITS)) > gfp |= GFP_DMA; -_______________________________________________ -iommu mailing list -iommu@lists.linux-foundation.org -https://lists.linuxfoundation.org/mailman/listinfo/iommu diff --git a/a/content_digest b/N1/content_digest index fcf52d1..d9b78df 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -1,17 +1,16 @@ "ref\020180328133535.17302-1-hch@lst.de\0" "ref\020180328133535.17302-2-hch@lst.de\0" - "ref\020180328133535.17302-2-hch-jcswGhMUV9g@public.gmane.org\0" - "From\0Evgeniy Didin <Evgeniy.Didin-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>\0" + "From\0Evgeniy Didin <Evgeniy.Didin@synopsys.com>\0" "Subject\0Re: [PATCH] dma-mapping: don't clear GFP_ZERO in dma_alloc_attrs\0" "Date\0Wed, 28 Mar 2018 15:12:47 +0000\0" - "To\0hch-jcswGhMUV9g@public.gmane.org <hch-jcswGhMUV9g@public.gmane.org>" - " x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org <x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>\0" - "Cc\0linux-arch-u79uwXL29TY76Z2rM5mHXA@public.gmane.org <linux-arch-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>" - sebott-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org <sebott-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org> - linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> - Evgeniy.Didin-HKixBCOQz3hWk0Htik3J/w@public.gmane.org <Evgeniy.Didin-HKixBCOQz3hWk0Htik3J/w@public.gmane.org> - iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org <iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org> - " linux-snps-arc-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org <linux-snps-arc-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>\0" + "To\0hch@lst.de <hch@lst.de>" + " x86@kernel.org <x86@kernel.org>\0" + "Cc\0linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org>" + sebott@linux.vnet.ibm.com <sebott@linux.vnet.ibm.com> + linux-arch@vger.kernel.org <linux-arch@vger.kernel.org> + iommu@lists.linux-foundation.org <iommu@lists.linux-foundation.org> + Evgeniy.Didin@synopsys.com <Evgeniy.Didin@synopsys.com> + " linux-snps-arc@lists.infradead.org <linux-snps-arc@lists.infradead.org>\0" "\00:1\0" "b\0" "Adding linux-snps and linux-arch mailing lists.\n" @@ -66,10 +65,6 @@ "> +\n" "> \302\240\t/* GFP_DMA32 and GFP_DMA are no ops without the corresponding zones: */\n" "> \302\240\tif (dev->coherent_dma_mask <= DMA_BIT_MASK(ARCH_ZONE_DMA_BITS))\n" - "> \302\240\t\tgfp |= GFP_DMA;\n" - "_______________________________________________\n" - "iommu mailing list\n" - "iommu@lists.linux-foundation.org\n" - https://lists.linuxfoundation.org/mailman/listinfo/iommu + "> \302\240\t\tgfp |= GFP_DMA;" -fad4356a3fd83bc31653ba3189354e26951436a95b4406eed448abc279c6d216 +4c3a6d296af6e0502a30d13da3e85bbd3fc16a2a93bfc4713d0f32c44537a7f5
diff --git a/a/1.txt b/N2/1.txt index 06c9e41..402e716 100644 --- a/a/1.txt +++ b/N2/1.txt @@ -1,57 +1,53 @@ Adding linux-snps and linux-arch mailing lists. > Revert the clearing of __GFP_ZERO in dma_alloc_attrs and move it to -> dma_direct_alloc for now. While most common architectures always zero dma +> dma_direct_alloc for now.??While most common architectures always zero dma > cohereny allocations (and x86 did so since day one) this is not documented > and at least arc and s390 do not zero without the explicit __GFP_ZERO > argument. This patch fixed Ethernet issues on ARC HSDK. https://www.spinics.net/lists/kernel/msg2762054.html -Tested-by: Evgeniy Didin <Evgeniy.Didin@synopsys.com> +Tested-by: Evgeniy Didin <Evgeniy.Didin at synopsys.com> > Fixes: 57bf5a8963f8 ("dma-mapping: clear harmful GFP_* flags in common code") -> Reported-by: Evgeniy Didin <Evgeniy.Didin@synopsys.com> -> Reported-by: Sebastian Ott <sebott@linux.vnet.ibm.com> -> Signed-off-by: Christoph Hellwig <hch@lst.de> +> Reported-by: Evgeniy Didin <Evgeniy.Didin at synopsys.com> +> Reported-by: Sebastian Ott <sebott at linux.vnet.ibm.com> +> Signed-off-by: Christoph Hellwig <hch at lst.de> > --- -> include/linux/dma-mapping.h | 8 ++------ -> lib/dma-direct.c | 3 +++ -> 2 files changed, 5 insertions(+), 6 deletions(-) +> ?include/linux/dma-mapping.h | 8 ++------ +> ?lib/dma-direct.c????????????| 3 +++ +> ?2 files changed, 5 insertions(+), 6 deletions(-) > > diff --git a/include/linux/dma-mapping.h b/include/linux/dma-mapping.h > index eb9eab4ecd6d..12fedcba9a9a 100644 > --- a/include/linux/dma-mapping.h > +++ b/include/linux/dma-mapping.h > @@ -518,12 +518,8 @@ static inline void *dma_alloc_attrs(struct device *dev, size_t size, -> if (dma_alloc_from_dev_coherent(dev, size, dma_handle, &cpu_addr)) -> return cpu_addr; -> +> ? if (dma_alloc_from_dev_coherent(dev, size, dma_handle, &cpu_addr)) +> ? return cpu_addr; +> ? > - /* -> - * Let the implementation decide on the zone to allocate from, and -> - * decide on the way of zeroing the memory given that the memory -> - * returned should always be zeroed. -> - */ +> - ?* Let the implementation decide on the zone to allocate from, and +> - ?* decide on the way of zeroing the memory given that the memory +> - ?* returned should always be zeroed. +> - ?*/ > - flag &= ~(__GFP_DMA | __GFP_DMA32 | __GFP_HIGHMEM | __GFP_ZERO); > + /* let the implementation decide on the zone to allocate from: */ > + flag &= ~(__GFP_DMA | __GFP_DMA32 | __GFP_HIGHMEM); > -> if (!arch_dma_alloc_attrs(&dev, &flag)) -> return NULL; +> ? if (!arch_dma_alloc_attrs(&dev, &flag)) +> ? return NULL; > diff --git a/lib/dma-direct.c b/lib/dma-direct.c > index 1277d293d4da..c0bba30fef0a 100644 > --- a/lib/dma-direct.c > +++ b/lib/dma-direct.c > @@ -59,6 +59,9 @@ void *dma_direct_alloc(struct device *dev, size_t size, dma_addr_t *dma_handle, -> struct page *page = NULL; -> void *ret; -> +> ? struct page *page = NULL; +> ? void *ret; +> ? > + /* we always manually zero the memory once we are done: */ > + gfp &= ~__GFP_ZERO; > + -> /* GFP_DMA32 and GFP_DMA are no ops without the corresponding zones: */ -> if (dev->coherent_dma_mask <= DMA_BIT_MASK(ARCH_ZONE_DMA_BITS)) -> gfp |= GFP_DMA; -_______________________________________________ -iommu mailing list -iommu@lists.linux-foundation.org -https://lists.linuxfoundation.org/mailman/listinfo/iommu +> ? /* GFP_DMA32 and GFP_DMA are no ops without the corresponding zones: */ +> ? if (dev->coherent_dma_mask <= DMA_BIT_MASK(ARCH_ZONE_DMA_BITS)) +> ? gfp |= GFP_DMA; diff --git a/a/content_digest b/N2/content_digest index fcf52d1..39557a8 100644 --- a/a/content_digest +++ b/N2/content_digest @@ -1,75 +1,63 @@ "ref\020180328133535.17302-1-hch@lst.de\0" "ref\020180328133535.17302-2-hch@lst.de\0" - "ref\020180328133535.17302-2-hch-jcswGhMUV9g@public.gmane.org\0" - "From\0Evgeniy Didin <Evgeniy.Didin-HKixBCOQz3hWk0Htik3J/w@public.gmane.org>\0" - "Subject\0Re: [PATCH] dma-mapping: don't clear GFP_ZERO in dma_alloc_attrs\0" + "From\0Evgeniy.Didin@synopsys.com (Evgeniy Didin)\0" + "Subject\0[PATCH] dma-mapping: don't clear GFP_ZERO in dma_alloc_attrs\0" "Date\0Wed, 28 Mar 2018 15:12:47 +0000\0" - "To\0hch-jcswGhMUV9g@public.gmane.org <hch-jcswGhMUV9g@public.gmane.org>" - " x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org <x86-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org>\0" - "Cc\0linux-arch-u79uwXL29TY76Z2rM5mHXA@public.gmane.org <linux-arch-u79uwXL29TY76Z2rM5mHXA@public.gmane.org>" - sebott-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org <sebott-23VcF4HTsmIX0ybBhKVfKdBPR1lH4CV8@public.gmane.org> - linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org <linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org> - Evgeniy.Didin-HKixBCOQz3hWk0Htik3J/w@public.gmane.org <Evgeniy.Didin-HKixBCOQz3hWk0Htik3J/w@public.gmane.org> - iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org <iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org> - " linux-snps-arc-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org <linux-snps-arc-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org>\0" + "To\0linux-snps-arc@lists.infradead.org\0" "\00:1\0" "b\0" "Adding linux-snps and linux-arch mailing lists.\n" "\n" "> Revert the clearing of __GFP_ZERO in dma_alloc_attrs and move it to\n" - "> dma_direct_alloc for now.\302\240\302\240While most common architectures always zero dma\n" + "> dma_direct_alloc for now.??While most common architectures always zero dma\n" "> cohereny allocations (and x86 did so since day one) this is not documented\n" "> and at least arc and s390 do not zero without the explicit __GFP_ZERO\n" "> argument.\n" "This patch fixed Ethernet issues on ARC HSDK.\n" "https://www.spinics.net/lists/kernel/msg2762054.html\n" "\n" - "Tested-by: Evgeniy Didin <Evgeniy.Didin@synopsys.com>\n" + "Tested-by: Evgeniy Didin <Evgeniy.Didin at synopsys.com>\n" "> Fixes: 57bf5a8963f8 (\"dma-mapping: clear harmful GFP_* flags in common code\")\n" - "> Reported-by: Evgeniy Didin <Evgeniy.Didin@synopsys.com>\n" - "> Reported-by: Sebastian Ott <sebott@linux.vnet.ibm.com>\n" - "> Signed-off-by: Christoph Hellwig <hch@lst.de>\n" + "> Reported-by: Evgeniy Didin <Evgeniy.Didin at synopsys.com>\n" + "> Reported-by: Sebastian Ott <sebott at linux.vnet.ibm.com>\n" + "> Signed-off-by: Christoph Hellwig <hch at lst.de>\n" "> ---\n" - "> \302\240include/linux/dma-mapping.h | 8 ++------\n" - "> \302\240lib/dma-direct.c\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240| 3 +++\n" - "> \302\2402 files changed, 5 insertions(+), 6 deletions(-)\n" + "> ?include/linux/dma-mapping.h | 8 ++------\n" + "> ?lib/dma-direct.c????????????| 3 +++\n" + "> ?2 files changed, 5 insertions(+), 6 deletions(-)\n" "> \n" "> diff --git a/include/linux/dma-mapping.h b/include/linux/dma-mapping.h\n" "> index eb9eab4ecd6d..12fedcba9a9a 100644\n" "> --- a/include/linux/dma-mapping.h\n" "> +++ b/include/linux/dma-mapping.h\n" "> @@ -518,12 +518,8 @@ static inline void *dma_alloc_attrs(struct device *dev, size_t size,\n" - "> \302\240\tif (dma_alloc_from_dev_coherent(dev, size, dma_handle, &cpu_addr))\n" - "> \302\240\t\treturn cpu_addr;\n" - "> \302\240\n" + "> ?\tif (dma_alloc_from_dev_coherent(dev, size, dma_handle, &cpu_addr))\n" + "> ?\t\treturn cpu_addr;\n" + "> ?\n" "> -\t/*\n" - "> -\t\302\240* Let the implementation decide on the zone to allocate from, and\n" - "> -\t\302\240* decide on the way of zeroing the memory given that the memory\n" - "> -\t\302\240* returned should always be zeroed.\n" - "> -\t\302\240*/\n" + "> -\t?* Let the implementation decide on the zone to allocate from, and\n" + "> -\t?* decide on the way of zeroing the memory given that the memory\n" + "> -\t?* returned should always be zeroed.\n" + "> -\t?*/\n" "> -\tflag &= ~(__GFP_DMA | __GFP_DMA32 | __GFP_HIGHMEM | __GFP_ZERO);\n" "> +\t/* let the implementation decide on the zone to allocate from: */\n" "> +\tflag &= ~(__GFP_DMA | __GFP_DMA32 | __GFP_HIGHMEM);\n" "> \n" - "> \302\240\tif (!arch_dma_alloc_attrs(&dev, &flag))\n" - "> \302\240\t\treturn NULL;\n" + "> ?\tif (!arch_dma_alloc_attrs(&dev, &flag))\n" + "> ?\t\treturn NULL;\n" "> diff --git a/lib/dma-direct.c b/lib/dma-direct.c\n" "> index 1277d293d4da..c0bba30fef0a 100644\n" "> --- a/lib/dma-direct.c\n" "> +++ b/lib/dma-direct.c\n" "> @@ -59,6 +59,9 @@ void *dma_direct_alloc(struct device *dev, size_t size, dma_addr_t *dma_handle,\n" - "> \302\240\tstruct page *page = NULL;\n" - "> \302\240\tvoid *ret;\n" - "> \302\240\n" + "> ?\tstruct page *page = NULL;\n" + "> ?\tvoid *ret;\n" + "> ?\n" "> +\t/* we always manually zero the memory once we are done: */\n" "> +\tgfp &= ~__GFP_ZERO;\n" "> +\n" - "> \302\240\t/* GFP_DMA32 and GFP_DMA are no ops without the corresponding zones: */\n" - "> \302\240\tif (dev->coherent_dma_mask <= DMA_BIT_MASK(ARCH_ZONE_DMA_BITS))\n" - "> \302\240\t\tgfp |= GFP_DMA;\n" - "_______________________________________________\n" - "iommu mailing list\n" - "iommu@lists.linux-foundation.org\n" - https://lists.linuxfoundation.org/mailman/listinfo/iommu + "> ?\t/* GFP_DMA32 and GFP_DMA are no ops without the corresponding zones: */\n" + "> ?\tif (dev->coherent_dma_mask <= DMA_BIT_MASK(ARCH_ZONE_DMA_BITS))\n" + "> ?\t\tgfp |= GFP_DMA;" -fad4356a3fd83bc31653ba3189354e26951436a95b4406eed448abc279c6d216 +135bd345cc4b98bff879d08f94b02d1ebf664b9f913802439b09240f89d52703
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.