From mboxrd@z Thu Jan 1 00:00:00 1970 From: Lyude Paul Subject: Re: [PATCH v2] drm/i915: Keep AUX block running when disabling DPMS for MST Date: Wed, 04 Apr 2018 15:00:12 -0400 Message-ID: <1522868412.12403.13.camel@redhat.com> References: <20180402212142.19841-1-lyude@redhat.com> <20180402212617.21247-1-lyude@redhat.com> <20180404153429.GE5453@intel.com> <1522867061.12403.6.camel@redhat.com> <20180404185313.GG5453@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20180404185313.GG5453@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville =?ISO-8859-1?Q?Syrj=E4l=E4?= Cc: dri-devel@lists.freedesktop.org, David Airlie , intel-gfx@lists.freedesktop.org, linux-kernel@vger.kernel.org, Dhinakaran Pandiyan , Rodrigo Vivi , stable@vger.kernel.org, Laura Abbott List-Id: dri-devel@lists.freedesktop.org T24gV2VkLCAyMDE4LTA0LTA0IGF0IDIxOjUzICswMzAwLCBWaWxsZSBTeXJqw6Rsw6Qgd3JvdGU6 Cj4gT24gV2VkLCBBcHIgMDQsIDIwMTggYXQgMDI6Mzc6NDFQTSAtMDQwMCwgTHl1ZGUgUGF1bCB3 cm90ZToKPiA+IE9uIFdlZCwgMjAxOC0wNC0wNCBhdCAxODozNCArMDMwMCwgVmlsbGUgU3lyasOk bMOkIHdyb3RlOgo+ID4gPiBPbiBNb24sIEFwciAwMiwgMjAxOCBhdCAwNToyNjoxNlBNIC0wNDAw LCBMeXVkZSBQYXVsIHdyb3RlOgo+ID4gPiA+IFdoaWxlIGVuYWJsaW5nL2Rpc2FibGluZyBEUE1T IGJlZm9yZSBsaW5rIHRyYWluaW5nIHdpdGggTVNUIGh1YnMgaXMKPiA+ID4gPiBwZXJmZWN0bHkg dmFsaWQ7IHVuZm9ydHVuYXRlbHkgZGlzYWJsaW5nIERQTVMgcmVzdWx0cyBpbiBzb21lIGRldmlj ZXMKPiA+ID4gPiBkaXNhYmxpbmcgdGhlaXIgQVVYIENIIGJsb2NrIGFzIHdlbGwuIEZvciBTU1Qg dGhpcyBpc24ndCBhcyBtdWNoIG9mIGEKPiA+ID4gPiBwcm9ibGVtLCBidXQgZm9yIE1TVCB3ZSBu ZWVkIHRvIGJlIGFibGUgdG8gY29udGludWUgaGFuZGxpbmcgYXV4Cj4gPiA+ID4gdHJhbnNhY3Rp b25zIGV2ZW4gd2hlbiBub25lIG9mIHRoZSBzaW5rcyBhcmUgdHVybmVkIG9uIHNpbmNlIGl0J3MK PiA+ID4gPiBwb3NzaWJsZSBmb3IgdXMgdG8gaGF2ZSBhIHNpbmdsZSBhdG9taWMgY29tbWl0IHdo aWNoIHJlc3VsdHMgaW4KPiA+ID4gPiBkaXNhYmxpbmcgZWFjaCBkb3duc3RyZWFtIHNpbmssIGZv bGxvd2VkIGJ5IHN1YnNlcXVlbnRseSByZS1lbmFibGluZwo+ID4gPiA+IGVhY2ggc2luay4KPiA+ ID4gPiAKPiA+ID4gPiBJZiB3ZSBkb24ndCBkbyB0aGlzLCB3ZSdsbCBlbmQgdXAgc3RhbGxpbmcg YW55IHBlbmRpbmcgRVNJIGludGVycnVwdHMKPiA+ID4gPiBmcm9tIHRoZSBzaW5rIGZvciB1cCB0 byAxbXMuIFVuZm9ydHVuYXRlbHksIGRyb3BwaW5nIEVTSXMgZHVyaW5nIHRoaXMKPiA+ID4gPiB0 aW1lc3BhbiBtYWtlcyBpdCBzbyB0aGF0IGxpbmsgZmFsbGJhY2sgcmV0cmFpbmluZyBmb3IgTVNU ICh3aGljaCBJCj4gPiA+ID4gd2lsbAo+ID4gPiA+IGJlIHN1Ym1pdHRpbmcgdG8gdGhlIE1MIHNo b3J0bHkpIGZhaWxzIGR1ZSB0byB0aGUgY2hhbm5lbCBFUSBmYWlsdXJlCj4gPiA+ID4gaW50ZXJy dXB0cyBwb3RlbnRpYWxseSBnZXR0aW5nIGRyb3BwZWQuIEFkZGl0aW9uYWxseSwgd2hlbiBwZXJm b3JtaW5nCj4gPiA+ID4gYQo+ID4gPiA+IG1vZGVzZXQgdGhhdCBicmluZ3MgdGhlIGh1YiBzdGF0 dXMncyBsaW5rIHN0YXR1cyBmcm9tIGJhZCAtPiBnb29kCj4gPiA+ID4gaGF2aW5nCj4gPiA+ID4g RVNJcyBkaXNhYmxlZCBmb3IgdGhhdCBsb25nIGNhdXNlcyB1cyB0byBtaXNzIHRoZSBodWIncyBy ZXNwb25zZSB0byB1cwo+ID4gPiA+IHRyeWluZyB0byBzdGFydCBsaW5rIHRyYWluaW5nIGFzIHdl bGwuCj4gPiA+ID4gCj4gPiA+ID4gU2luY2UgYW55IHNpbmsgd2l0aCBNU1QgaXMgZ29pbmcgdG8g c3VwcG9ydCBEaXNwbGF5UG9ydCAxLjIgYW55d2F5LAo+ID4gPiA+IHNhdmUKPiA+ID4gPiB1cyB0 aGUgaGFzc2xlIG9mIHRyeWluZyB0byB3YWl0IHVudGlsIHRoZSBzaW5rIGNvbWVzIGJhY2sgdXAg YW5kIGp1c3QKPiA+ID4gPiBuZXZlciBzaHV0IHRoZSBhdXggYmxvY2sgZG93bi4KPiA+ID4gPiAK PiA+ID4gPiBDaGFuZ2VzIHNpbmNlIHYyOgo+ID4gPiA+ICAtIEZpeCBwYXRjaCBuYW1lLCBubyBm dW5jdGlvbmFsIGNoYW5nZXMKPiA+ID4gPiAKPiA+ID4gPiBTaWduZWQtb2ZmLWJ5OiBMeXVkZSBQ YXVsIDxseXVkZUByZWRoYXQuY29tPgo+ID4gPiA+IENjOiBMYXVyYSBBYmJvdHQgPGxhYmJvdHRA cmVkaGF0LmNvbT4KPiA+ID4gPiBDYzogRGhpbmFrYXJhbiBQYW5kaXlhbiA8ZGhpbmFrYXJhbi5w YW5kaXlhbkBpbnRlbC5jb20+Cj4gPiA+ID4gQ2M6IFZpbGxlIFN5cmrDpGzDpCA8dmlsbGUuc3ly amFsYUBsaW51eC5pbnRlbC5jb20+Cj4gPiA+ID4gQ2M6IHN0YWJsZUB2Z2VyLmtlcm5lbC5vcmcK PiA+ID4gPiBGaXhlczogYWQyNjBhYjMyYTRkOSAoImRybS9pOTE1L2RwOiBXcml0ZSB0byBTRVRf UE9XRVIgZHBjZCB0byBlbmFibGUKPiA+ID4gPiBNU1QKPiA+ID4gPiBodWIuIikKPiA+ID4gPiAt LS0KPiA+ID4gPiAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuYyB8IDYgKysrKy0tCj4g PiA+ID4gIDEgZmlsZSBjaGFuZ2VkLCA0IGluc2VydGlvbnMoKyksIDIgZGVsZXRpb25zKC0pCj4g PiA+ID4gCj4gPiA+ID4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rw LmMKPiA+ID4gPiBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2RwLmMKPiA+ID4gPiBpbmRl eCA2MmY4MmM0Mjk4YWMuLjA0NzljMzc3OTgxYiAxMDA2NDQKPiA+ID4gPiAtLS0gYS9kcml2ZXJz L2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jCj4gPiA+ID4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5 MTUvaW50ZWxfZHAuYwo+ID4gPiA+IEBAIC0yNTg5LDExICsyNTg5LDEzIEBAIHZvaWQgaW50ZWxf ZHBfc2lua19kcG1zKHN0cnVjdCBpbnRlbF9kcAo+ID4gPiA+ICppbnRlbF9kcCwKPiA+ID4gPiBp bnQgbW9kZSkKPiA+ID4gPiAgCQlyZXR1cm47Cj4gPiA+ID4gIAo+ID4gPiA+ICAJaWYgKG1vZGUg IT0gRFJNX01PREVfRFBNU19PTikgewo+ID4gPiA+ICsJCXVuc2lnbmVkIGNoYXIgZGF0YSA9IGlu dGVsX2RwLT5pc19tc3QgPwo+ID4gPiA+ICsJCQlEUF9TRVRfUE9XRVJfRDNfQVVYX09OIDogRFBf U0VUX1BPV0VSX0QzOwo+ID4gPiAKPiA+ID4gVGhpcyBzbWVsbHMgbGlrZSBhIHdvcmthcm91bmQg Zm9yIGFuIGFjdHVhbCBidWcgc29tZXdoZXJlLiBXaHkgZXhhY3RseQo+ID4gPiBpcyB0aGUgc2xv d2VyIHdha2V1cCBvciB0aGUgQVVYIGJsb2NrIGEgcHJvYmxlbSBmb3IgTVNUIGJ1dCBub3QgZm9y IFNTVAo+ID4gPiB3aGVuIHRoZSBsaW5rIHRyYWluaW5nIGlzIGV4YWN0bHkgdGhlIHNhbWUgZm9y IFNTVCBhbmQgTVNUPwo+ID4gCj4gPiBJIGFjdHVhbGx5IHRob3VnaHQgYWJvdXQgdGhpcyBidXQg SSBzdGlsbCB0aGluayB0aGlzIGlzIHRoZSBhcHByb3ByaWF0ZQo+ID4gZml4Lgo+ID4gU287IHRo ZSByZWFsIHJlYXNvbiBmb3IgdGhlIHdha2V1cCBub3QgYmVpbmcgYSBwcm9ibGVtIHdpdGggU1NU IGlzIHRoYXQKPiA+IGZvcgo+ID4gRFBNUyBvbiB3aXRoIFNTVCwgd2UgYWN0dWFsbHkgZG8gYSB3 YWl0IHRvIG1ha2Ugc3VyZSB0aGF0IHRoZSBodWIgaXMgcmVhZHkKPiA+IGJlZm9yZSBjb250aW51 aW5nLiBBbmQgeWVzOiBJJ20gZmFpcmx5IHN1cmUgU1NUIGRvZXMgYWN0dWFsbHkgaGF2ZSBhcm91 bmQKPiA+IHRoZQo+ID4gc2FtZSB3YWtldXAgdGltZSB0aGF0IE1TVCBkb2VzLCBidXQgd2l0aCB0 aGUgd2FpdCB3ZSBkbyBpdCBkb2Vzbid0IHJlYWxsaHkKPiA+IG1ha2UgYSBkaWZmZXJlbmNlLiBX aXRoIE1TVCwgd2UgY291bGQgZG8gdGhpcyBidXQgdGhlcmUncyBhIGZldyByZWFzb25zIEkKPiA+ IGRvbid0IHRoaW5rIHdlIHNob3VsZDoKPiA+ICAqIFdlIGRvbid0IG5lZWQgdG8uIEQzX0FVWF9P TiBpcyBhIHBhcnQgb2YgdGhlIDEuMiBzcGVjLCBzbyBhbnkgaHViIHRoYXQKPiA+IGhhcwo+ID4g ICAgTVNUIGlzIGdvaW5nIHRvIGJlIGd1YXJhbnRlZWQgdG8gaGF2ZSB0aGlzLgo+ID4gICogVHVy bmluZyBvZmYgdGhlIGF1eCBibG9jayBtZWFucyB0aGF0IHRoZXJlJ3MgYSBoaWdoIGNoYW5jZSB3 ZSdyZSBnb2luZwo+ID4gdG8KPiA+ICAgIG1pc3MgRVNJcyBmcm9tIHNpbmtzCj4gCj4gQW5kIGhv dyBleGFjdGx5IGRvIHdlIGxvc2UgaXJxcz8gVGhlIGh1Yi93aGF0ZXZlciB0aHJvd3MgdGhlIHVw IHJlcSBtc2dzCj4gYXdheSBpZiB3ZSBkb24ndCByZWFkIHRoZW0gd2l0aGluIHNvbWUgcmVhbGx5 IHNob3J0IHRpbWU/Ck9oLWFkZGl0aW9uYWxseSBJIGRpZCBmb3JnZXQgdG8gbWVudGlvbiB0aGF0 IGkgaGF2ZSBhY3R1YWxseSB3aXRuZXNzZWQgdGhlCmNoYW5uZWwgZXEgZmFpbHVyZXMgaW4gdGhl IEVTSSBnZXR0aW5nIGRyb3BwZWQgd2l0aG91dCB0aGlzIHBhdGNoLiBNZWFuaW5nIGlmCndlIG1p c3MgdGhlbSwgdGhlcmUncyBhIGNoYW5jZSB0aGUgaHViIG1heSBqdXN0IG5vdCBjaG9vc2UgdG8g c2VuZCB0aGVtIGFnYWluCmZvciB3aGF0ZXZlciByZWFzb24uCj4gCj4gPiAgKiBJdCdzIGZhc3Rl ciB0byBrZWVwIHRoZSBhdXggYmxvY2sgb24gYW55d2F5Cj4gPiAKPiA+IAo+ID4gPiAKPiA+ID4g PiArCj4gPiA+ID4gIAkJaWYgKGRvd25zdHJlYW1faHBkX25lZWRzX2QwKGludGVsX2RwKSkKPiA+ ID4gPiAgCQkJcmV0dXJuOwo+ID4gPiA+ICAKPiA+ID4gPiAtCQlyZXQgPSBkcm1fZHBfZHBjZF93 cml0ZWIoJmludGVsX2RwLT5hdXgsCj4gPiA+ID4gRFBfU0VUX1BPV0VSLAo+ID4gPiA+IC0JCQkJ CSBEUF9TRVRfUE9XRVJfRDMpOwo+ID4gPiA+ICsJCXJldCA9IGRybV9kcF9kcGNkX3dyaXRlYigm aW50ZWxfZHAtPmF1eCwKPiA+ID4gPiBEUF9TRVRfUE9XRVIsCj4gPiA+ID4gZGF0YSk7Cj4gPiA+ ID4gIAl9IGVsc2Ugewo+ID4gPiA+ICAJCXN0cnVjdCBpbnRlbF9sc3Bjb24gKmxzcGNvbiA9IGRw X3RvX2xzcGNvbihpbnRlbF9kcCk7Cj4gPiA+ID4gIAo+ID4gPiA+IC0tIAo+ID4gPiA+IDIuMTQu Mwo+ID4gPiAKPiA+ID4gCj4gPiAKPiA+IC0tIAo+ID4gQ2hlZXJzLAo+ID4gCUx5dWRlIFBhdWwK PiAKPiAKLS0gCkNoZWVycywKCUx5dWRlIFBhdWwKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlz dHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4v bGlzdGluZm8vaW50ZWwtZ2Z4Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Cyrus-Session-Id: sloti22d1t05-810554-1522868418-2-16450895472940435035 X-Sieve: CMU Sieve 3.0 X-Spam-known-sender: no ("Email failed DMARC policy for domain") X-Spam-score: 0.0 X-Spam-hits: BAYES_00 -1.9, HEADER_FROM_DIFFERENT_DOMAINS 0.249, ME_NOAUTH 0.01, RCVD_IN_DNSWL_HI -5, T_RP_MATCHES_RCVD -0.01, LANGUAGES en, BAYES_USED global, SA_VERSION 3.4.0 X-Spam-source: IP='209.132.180.67', Host='vger.kernel.org', Country='US', FromHeader='com', MailFrom='org' X-Spam-charsets: to='ISO-8859-1', plain='UTF-8' X-IgnoreVacation: yes ("Email failed DMARC policy for domain") X-Resolved-to: greg@kroah.com X-Delivered-to: greg@kroah.com X-Mail-from: stable-owner@vger.kernel.org ARC-Seal: i=1; a=rsa-sha256; cv=none; d=messagingengine.com; s=fm2; t= 1522868417; b=aC5qsX1gSzHpiYTtl3GRXOsGxdtVAsxkLENbSjo9FDfbdThsTy dtRfga7m8i35H7xCrURyADFEqC7q1q1DgZ+55MlVL5nnQk7HU66tF9FqlMmXgWL7 EeF2DGVxUG3SkSIZVxjZfaWxS5Z8vseApFVLQrIyRjKT0D0A+l6Y92FkydFpXsLL TDFlEt86nTrpgjnvyEUMpqDR7rrOQ08A6PR42b6kX2CEdm345XB7o6jw0+uzhvZ1 2ppZRnM2GhTO1RPX3qDsrV6x+bq8Cy+2iZAE11p87XHg45aNNfbYQnbfYEzNGzYH DukUjnyMvsSTqESPX75xE3LcMtERscSjTOnw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=message-id:subject:from:to:cc:date :in-reply-to:references:content-type:mime-version :content-transfer-encoding:sender:list-id; s=fm2; t=1522868417; bh=f6J1HDrD6oW1gt1RZ0otllPfvtVpluZDJvMNs0MOSBM=; b=X2ZxDPUWnX24 vfFYIJzpOyrNJaM7NLG9KXbDV1vWNHJoF9sCcl0clOQD3z14zRqm97HQAOzYdwWw i7yAGmpkRpvDoNjey27TDaZoT+E24TxgHYX2+yoSC4WjFg0sVMHvTTPNt5lJyzPv eopD7UqS1On31fVtl1r0wzSTbS/Yqq7WGm9sZqGZ5CM7vo36qwIoD9Ouw5e3kefc o3AVdroCx1uHctBmLOer4OxgHfCnYxqE70CtAPooN0XEDaB/6Ww1CX//JEFnNBJQ miFtJVZIAWDLe+w6e9QaS1nIQeNYVnW9hdBt44Sp2bSKY3p2o3rvhuC51aqJsEj3 MZPz5u+Mhw== ARC-Authentication-Results: i=1; mx2.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=fail (p=none,has-list-id=yes,d=none) header.from=redhat.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-cm=none score=0; x-google-dkim=pass (2048-bit rsa key) header.d=1e100.net header.i=@1e100.net header.b=paFQMgwG; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=redhat.com header.result=pass header_is_org_domain=yes; x-vs=clean score=-100 state=0 Authentication-Results: mx2.messagingengine.com; arc=none (no signatures found); dkim=none (no signatures found); dmarc=fail (p=none,has-list-id=yes,d=none) header.from=redhat.com; iprev=pass policy.iprev=209.132.180.67 (vger.kernel.org); spf=none smtp.mailfrom=stable-owner@vger.kernel.org smtp.helo=vger.kernel.org; x-aligned-from=fail; x-cm=none score=0; x-google-dkim=pass (2048-bit rsa key) header.d=1e100.net header.i=@1e100.net header.b=paFQMgwG; x-ptr=pass x-ptr-helo=vger.kernel.org x-ptr-lookup=vger.kernel.org; x-return-mx=pass smtp.domain=vger.kernel.org smtp.result=pass smtp_org.domain=kernel.org smtp_org.result=pass smtp_is_org_domain=no header.domain=redhat.com header.result=pass header_is_org_domain=yes; x-vs=clean score=-100 state=0 X-ME-VSCategory: clean X-CM-Envelope: MS4wfCgSHaITJ0Dpk5GlkBGCToeNNnIXmHZMO7AxNiVzTXfLs7rb+13sJpft5dpsw6ihlC9hdZuY4sRR+Bu01S3TD5YLl9SzO8BM/IJnDVogmMIpeR+4GMZl saPvx+5ZzqNeR2F/RVFiIaXhKVjuTFcZ2KnxQBGn5NnpGOwFQooI3yVzOYySMq600GOru/Yk3EsQ3sUgttGICG33vbi4EOcepoHKGOwLg7J4RZsoA+A9abY4 X-CM-Analysis: v=2.3 cv=E8HjW5Vl c=1 sm=1 tr=0 a=UK1r566ZdBxH71SXbqIOeA==:117 a=UK1r566ZdBxH71SXbqIOeA==:17 a=IkcTkHD0fZMA:10 a=Kd1tUaAdevIA:10 a=20KFwNOVAAAA:8 a=QyXUC8HyAAAA:8 a=VwQbUJbxAAAA:8 a=qj8LwLYKPy8-eemtANAA:9 a=QEXdDO2ut3YA:10 a=AjGcO6oz07-iQ99wixmX:22 X-ME-CMScore: 0 X-ME-CMCategory: none Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751606AbeDDTAP (ORCPT ); Wed, 4 Apr 2018 15:00:15 -0400 Received: from mail-qk0-f195.google.com ([209.85.220.195]:35288 "EHLO mail-qk0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751470AbeDDTAO (ORCPT ); Wed, 4 Apr 2018 15:00:14 -0400 X-Google-Smtp-Source: AIpwx4/qRDylZp2ei3050v2vC3s2WRKokw7MDgkYnxbBNhZIvy8NZBgGW14IE+ihSd/vFp0cFB1xMQ== Message-ID: <1522868412.12403.13.camel@redhat.com> Subject: Re: [PATCH v2] drm/i915: Keep AUX block running when disabling DPMS for MST From: Lyude Paul To: Ville =?ISO-8859-1?Q?Syrj=E4l=E4?= Cc: intel-gfx@lists.freedesktop.org, Laura Abbott , Dhinakaran Pandiyan , stable@vger.kernel.org, Jani Nikula , Joonas Lahtinen , Rodrigo Vivi , David Airlie , dri-devel@lists.freedesktop.org, linux-kernel@vger.kernel.org Date: Wed, 04 Apr 2018 15:00:12 -0400 In-Reply-To: <20180404185313.GG5453@intel.com> References: <20180402212142.19841-1-lyude@redhat.com> <20180402212617.21247-1-lyude@redhat.com> <20180404153429.GE5453@intel.com> <1522867061.12403.6.camel@redhat.com> <20180404185313.GG5453@intel.com> Organization: Red Hat Content-Type: text/plain; charset="UTF-8" X-Mailer: Evolution 3.26.6 (3.26.6-1.fc27) Mime-Version: 1.0 Content-Transfer-Encoding: 8bit Sender: stable-owner@vger.kernel.org X-Mailing-List: stable@vger.kernel.org X-getmail-retrieved-from-mailbox: INBOX X-Mailing-List: linux-kernel@vger.kernel.org List-ID: On Wed, 2018-04-04 at 21:53 +0300, Ville Syrjälä wrote: > On Wed, Apr 04, 2018 at 02:37:41PM -0400, Lyude Paul wrote: > > On Wed, 2018-04-04 at 18:34 +0300, Ville Syrjälä wrote: > > > On Mon, Apr 02, 2018 at 05:26:16PM -0400, Lyude Paul wrote: > > > > While enabling/disabling DPMS before link training with MST hubs is > > > > perfectly valid; unfortunately disabling DPMS results in some devices > > > > disabling their AUX CH block as well. For SST this isn't as much of a > > > > problem, but for MST we need to be able to continue handling aux > > > > transactions even when none of the sinks are turned on since it's > > > > possible for us to have a single atomic commit which results in > > > > disabling each downstream sink, followed by subsequently re-enabling > > > > each sink. > > > > > > > > If we don't do this, we'll end up stalling any pending ESI interrupts > > > > from the sink for up to 1ms. Unfortunately, dropping ESIs during this > > > > timespan makes it so that link fallback retraining for MST (which I > > > > will > > > > be submitting to the ML shortly) fails due to the channel EQ failure > > > > interrupts potentially getting dropped. Additionally, when performing > > > > a > > > > modeset that brings the hub status's link status from bad -> good > > > > having > > > > ESIs disabled for that long causes us to miss the hub's response to us > > > > trying to start link training as well. > > > > > > > > Since any sink with MST is going to support DisplayPort 1.2 anyway, > > > > save > > > > us the hassle of trying to wait until the sink comes back up and just > > > > never shut the aux block down. > > > > > > > > Changes since v2: > > > > - Fix patch name, no functional changes > > > > > > > > Signed-off-by: Lyude Paul > > > > Cc: Laura Abbott > > > > Cc: Dhinakaran Pandiyan > > > > Cc: Ville Syrjälä > > > > Cc: stable@vger.kernel.org > > > > Fixes: ad260ab32a4d9 ("drm/i915/dp: Write to SET_POWER dpcd to enable > > > > MST > > > > hub.") > > > > --- > > > > drivers/gpu/drm/i915/intel_dp.c | 6 ++++-- > > > > 1 file changed, 4 insertions(+), 2 deletions(-) > > > > > > > > diff --git a/drivers/gpu/drm/i915/intel_dp.c > > > > b/drivers/gpu/drm/i915/intel_dp.c > > > > index 62f82c4298ac..0479c377981b 100644 > > > > --- a/drivers/gpu/drm/i915/intel_dp.c > > > > +++ b/drivers/gpu/drm/i915/intel_dp.c > > > > @@ -2589,11 +2589,13 @@ void intel_dp_sink_dpms(struct intel_dp > > > > *intel_dp, > > > > int mode) > > > > return; > > > > > > > > if (mode != DRM_MODE_DPMS_ON) { > > > > + unsigned char data = intel_dp->is_mst ? > > > > + DP_SET_POWER_D3_AUX_ON : DP_SET_POWER_D3; > > > > > > This smells like a workaround for an actual bug somewhere. Why exactly > > > is the slower wakeup or the AUX block a problem for MST but not for SST > > > when the link training is exactly the same for SST and MST? > > > > I actually thought about this but I still think this is the appropriate > > fix. > > So; the real reason for the wakeup not being a problem with SST is that > > for > > DPMS on with SST, we actually do a wait to make sure that the hub is ready > > before continuing. And yes: I'm fairly sure SST does actually have around > > the > > same wakeup time that MST does, but with the wait we do it doesn't reallhy > > make a difference. With MST, we could do this but there's a few reasons I > > don't think we should: > > * We don't need to. D3_AUX_ON is a part of the 1.2 spec, so any hub that > > has > > MST is going to be guaranteed to have this. > > * Turning off the aux block means that there's a high chance we're going > > to > > miss ESIs from sinks > > And how exactly do we lose irqs? The hub/whatever throws the up req msgs > away if we don't read them within some really short time? Oh-additionally I did forget to mention that i have actually witnessed the channel eq failures in the ESI getting dropped without this patch. Meaning if we miss them, there's a chance the hub may just not choose to send them again for whatever reason. > > > * It's faster to keep the aux block on anyway > > > > > > > > > > > + > > > > if (downstream_hpd_needs_d0(intel_dp)) > > > > return; > > > > > > > > - ret = drm_dp_dpcd_writeb(&intel_dp->aux, > > > > DP_SET_POWER, > > > > - DP_SET_POWER_D3); > > > > + ret = drm_dp_dpcd_writeb(&intel_dp->aux, > > > > DP_SET_POWER, > > > > data); > > > > } else { > > > > struct intel_lspcon *lspcon = dp_to_lspcon(intel_dp); > > > > > > > > -- > > > > 2.14.3 > > > > > > > > > > -- > > Cheers, > > Lyude Paul > > -- Cheers, Lyude Paul