diff for duplicates of <1522894016.1824.2.camel@realtek.com> diff --git a/a/1.txt b/N1/1.txt index c0aa6f2..9199edb 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,24 +1,31 @@ -T24gVGh1LCAyMDE4LTA0LTA1IGF0IDAxOjI1ICswMDAwLCBHdXN0YXZvIEEuIFIuIFNpbHZhIHdy -b3RlOg0KPiBIaSBhbGwsDQo+IA0KPiBXaGlsZSBkb2luZyBzb21lIHN0YXRpYyBhbmFseXNpcyBJ -IGNhbWUgYWNyb3NzIHRoZSBmb2xsb3dpbmcgcGllY2Ugb2YgY29kZSBhdA0KPiBkcml2ZXJzL25l -dC93aXJlbGVzcy9yZWFsdGVrL3J0bHdpZmkvYnRjb2V4aXN0L2hhbGJ0Yzg4MjFhMWFudC5jOjE1 -ODE6DQo+IA0KPiAxNTgxIHN0YXRpYyB2b2lkIGJ0Yzg4MjFhMWFudF9hY3RfYnRfc2NvX2hpZF9v -bmx5X2J1c3koc3RydWN0IGJ0Y19jb2V4aXN0ICpidGNvZXhpc3QsDQo+IDE1ODLCoMKgwqDCoMKg -wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC -oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqB1OCB3aWZpX3N0YXR1cykNCj4gMTU4 -MyB7DQo+IDE1ODTCoMKgwqDCoMKgwqDCoMKgwqAvKiB0ZG1hIGFuZCBjb2V4IHRhYmxlICovDQo+ -IDE1ODXCoMKgwqDCoMKgwqDCoMKgwqBidGM4ODIxYTFhbnRfcHNfdGRtYShidGNvZXhpc3QsIE5P -Uk1BTF9FWEVDLCB0cnVlLCA1KTsNCj4gMTU4NsKgDQo+IDE1ODfCoMKgwqDCoMKgwqDCoMKgwqBp -ZiAoQlRfODgyMUFfMUFOVF9XSUZJX1NUQVRVU19OT05fQ09OTkVDVEVEX0FTU09fQVVUSF9TQ0FO -ID09DQo+IDE1ODjCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoHdpZmlfc3RhdHVzKQ0KPiAxNTg5 -wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoGJ0Yzg4MjFhMWFudF9jb2V4X3RhYmxl -X3dpdGhfdHlwZShidGNvZXhpc3QsIE5PUk1BTF9FWEVDLCAxKTsNCj4gMTU5MMKgwqDCoMKgwqDC -oMKgwqDCoGVsc2UNCj4gMTU5McKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqBidGM4 -ODIxYTFhbnRfY29leF90YWJsZV93aXRoX3R5cGUoYnRjb2V4aXN0LCBOT1JNQUxfRVhFQywgMSk7 -DQo+IDE1OTIgfQ0KPiANCj4gVGhlIGlzc3VlIGhlcmUgaXMgdGhhdCB0aGUgY29kZSBmb3IgYm90 -aCBicmFuY2hlcyBvZiB0aGUgaWYtZWxzZSBzdGF0ZW1lbnQgaXMgaWRlbnRpY2FsLg0KPiANCj4g -VGhlIGlmLWVsc2Ugd2FzIGludHJvZHVjZWQgYSB5ZWFyIGFnbyBpbiB0aGlzIGNvbW1pdCBjNjgy -MTYxM2U2NTMNCj4gDQo+IEkgd29uZGVyIGlmIGFuIGFyZ3VtZW50IHNob3VsZCBiZSBjaGFuZ2Vk -IGluIGFueSBvZiB0aGUgY2FsbHMgdG8NCj4gYnRjODgyMWExYW50X2NvZXhfdGFibGVfd2l0aF90 -eXBlPw0KPiANCj4gDQoNCkl0IGxvb2tzIHdlaXJkLiBTaW5jZSB3ZSdyZSBpbiBzcHJpbmcgdmFj -YXRpb24sIEknbGwgY2hlY2sgbXkgY29sbGVhZ3VlIG5leHQgTW9uZGF5Lg0KDQpQSw0KDQo= +On Thu, 2018-04-05 at 01:25 +0000, Gustavo A. R. Silva wrote: +> Hi all, +> +> While doing some static analysis I came across the following piece of code at +> drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8821a1ant.c:1581: +> +> 1581 static void btc8821a1ant_act_bt_sco_hid_only_busy(struct btc_coexist *btcoexist, +> 1582 u8 wifi_status) +> 1583 { +> 1584 /* tdma and coex table */ +> 1585 btc8821a1ant_ps_tdma(btcoexist, NORMAL_EXEC, true, 5); +> 1586 +> 1587 if (BT_8821A_1ANT_WIFI_STATUS_NON_CONNECTED_ASSO_AUTH_SCAN == +> 1588 wifi_status) +> 1589 btc8821a1ant_coex_table_with_type(btcoexist, NORMAL_EXEC, 1); +> 1590 else +> 1591 btc8821a1ant_coex_table_with_type(btcoexist, NORMAL_EXEC, 1); +> 1592 } +> +> The issue here is that the code for both branches of the if-else statement is identical. +> +> The if-else was introduced a year ago in this commit c6821613e653 +> +> I wonder if an argument should be changed in any of the calls to +> btc8821a1ant_coex_table_with_type? +> +> + +It looks weird. Since we're in spring vacation, I'll check my colleague next Monday. + +PK diff --git a/a/content_digest b/N1/content_digest index 757848e..16cd935 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -10,29 +10,36 @@ " linux-kernel@vger.kernel.org <linux-kernel@vger.kernel.org>\0" "\00:1\0" "b\0" - "T24gVGh1LCAyMDE4LTA0LTA1IGF0IDAxOjI1ICswMDAwLCBHdXN0YXZvIEEuIFIuIFNpbHZhIHdy\n" - "b3RlOg0KPiBIaSBhbGwsDQo+IA0KPiBXaGlsZSBkb2luZyBzb21lIHN0YXRpYyBhbmFseXNpcyBJ\n" - "IGNhbWUgYWNyb3NzIHRoZSBmb2xsb3dpbmcgcGllY2Ugb2YgY29kZSBhdA0KPiBkcml2ZXJzL25l\n" - "dC93aXJlbGVzcy9yZWFsdGVrL3J0bHdpZmkvYnRjb2V4aXN0L2hhbGJ0Yzg4MjFhMWFudC5jOjE1\n" - "ODE6DQo+IA0KPiAxNTgxIHN0YXRpYyB2b2lkIGJ0Yzg4MjFhMWFudF9hY3RfYnRfc2NvX2hpZF9v\n" - "bmx5X2J1c3koc3RydWN0IGJ0Y19jb2V4aXN0ICpidGNvZXhpc3QsDQo+IDE1ODLCoMKgwqDCoMKg\n" - "wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDC\n" - "oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqB1OCB3aWZpX3N0YXR1cykNCj4gMTU4\n" - "MyB7DQo+IDE1ODTCoMKgwqDCoMKgwqDCoMKgwqAvKiB0ZG1hIGFuZCBjb2V4IHRhYmxlICovDQo+\n" - "IDE1ODXCoMKgwqDCoMKgwqDCoMKgwqBidGM4ODIxYTFhbnRfcHNfdGRtYShidGNvZXhpc3QsIE5P\n" - "Uk1BTF9FWEVDLCB0cnVlLCA1KTsNCj4gMTU4NsKgDQo+IDE1ODfCoMKgwqDCoMKgwqDCoMKgwqBp\n" - "ZiAoQlRfODgyMUFfMUFOVF9XSUZJX1NUQVRVU19OT05fQ09OTkVDVEVEX0FTU09fQVVUSF9TQ0FO\n" - "ID09DQo+IDE1ODjCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoHdpZmlfc3RhdHVzKQ0KPiAxNTg5\n" - "wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoGJ0Yzg4MjFhMWFudF9jb2V4X3RhYmxl\n" - "X3dpdGhfdHlwZShidGNvZXhpc3QsIE5PUk1BTF9FWEVDLCAxKTsNCj4gMTU5MMKgwqDCoMKgwqDC\n" - "oMKgwqDCoGVsc2UNCj4gMTU5McKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqBidGM4\n" - "ODIxYTFhbnRfY29leF90YWJsZV93aXRoX3R5cGUoYnRjb2V4aXN0LCBOT1JNQUxfRVhFQywgMSk7\n" - "DQo+IDE1OTIgfQ0KPiANCj4gVGhlIGlzc3VlIGhlcmUgaXMgdGhhdCB0aGUgY29kZSBmb3IgYm90\n" - "aCBicmFuY2hlcyBvZiB0aGUgaWYtZWxzZSBzdGF0ZW1lbnQgaXMgaWRlbnRpY2FsLg0KPiANCj4g\n" - "VGhlIGlmLWVsc2Ugd2FzIGludHJvZHVjZWQgYSB5ZWFyIGFnbyBpbiB0aGlzIGNvbW1pdCBjNjgy\n" - "MTYxM2U2NTMNCj4gDQo+IEkgd29uZGVyIGlmIGFuIGFyZ3VtZW50IHNob3VsZCBiZSBjaGFuZ2Vk\n" - "IGluIGFueSBvZiB0aGUgY2FsbHMgdG8NCj4gYnRjODgyMWExYW50X2NvZXhfdGFibGVfd2l0aF90\n" - "eXBlPw0KPiANCj4gDQoNCkl0IGxvb2tzIHdlaXJkLiBTaW5jZSB3ZSdyZSBpbiBzcHJpbmcgdmFj\n" - YXRpb24sIEknbGwgY2hlY2sgbXkgY29sbGVhZ3VlIG5leHQgTW9uZGF5Lg0KDQpQSw0KDQo= + "On Thu, 2018-04-05 at 01:25 +0000, Gustavo A. R. Silva wrote:\n" + "> Hi all,\n" + "> \n" + "> While doing some static analysis I came across the following piece of code at\n" + "> drivers/net/wireless/realtek/rtlwifi/btcoexist/halbtc8821a1ant.c:1581:\n" + "> \n" + "> 1581 static void btc8821a1ant_act_bt_sco_hid_only_busy(struct btc_coexist *btcoexist,\n" + "> 1582\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240u8 wifi_status)\n" + "> 1583 {\n" + "> 1584\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240/* tdma and coex table */\n" + "> 1585\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240btc8821a1ant_ps_tdma(btcoexist, NORMAL_EXEC, true, 5);\n" + "> 1586\302\240\n" + "> 1587\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240if (BT_8821A_1ANT_WIFI_STATUS_NON_CONNECTED_ASSO_AUTH_SCAN ==\n" + "> 1588\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240wifi_status)\n" + "> 1589\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240btc8821a1ant_coex_table_with_type(btcoexist, NORMAL_EXEC, 1);\n" + "> 1590\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240else\n" + "> 1591\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240btc8821a1ant_coex_table_with_type(btcoexist, NORMAL_EXEC, 1);\n" + "> 1592 }\n" + "> \n" + "> The issue here is that the code for both branches of the if-else statement is identical.\n" + "> \n" + "> The if-else was introduced a year ago in this commit c6821613e653\n" + "> \n" + "> I wonder if an argument should be changed in any of the calls to\n" + "> btc8821a1ant_coex_table_with_type?\n" + "> \n" + "> \n" + "\n" + "It looks weird. Since we're in spring vacation, I'll check my colleague next Monday.\n" + "\n" + PK -283d87460e370b09d2a203bbcdf7af1ad0153762060f478c486fd7d99e7fab5f +f0fea660eea32f15f7cb49ce226ea3119d02501d1844ce631b092275ba7f695e
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.