From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexey.Brodkin@synopsys.com (Alexey Brodkin) Date: Mon, 9 Apr 2018 09:45:51 +0000 Subject: DRM_UDL and GPU under Xserver In-Reply-To: <20180409091706.GU31310@phenom.ffwll.local> References: <1522912595.4577.5.camel@synopsys.com> <1522924162.3779.16.camel@pengutronix.de> <1522926602.4587.10.camel@synopsys.com> <20180405134421.GV3881@phenom.ffwll.local> <1522953580.3977.10.camel@synopsys.com> <20180409083127.GL31310@phenom.ffwll.local> <1523264135.5268.14.camel@synopsys.com> <20180409091706.GU31310@phenom.ffwll.local> List-ID: Message-ID: <1523267150.5268.18.camel@synopsys.com> To: linux-snps-arc@lists.infradead.org Hi Daniel, On Mon, 2018-04-09@11:17 +0200, Daniel Vetter wrote: > On Mon, Apr 09, 2018@08:55:36AM +0000, Alexey Brodkin wrote: > > Hi Daniel, > > > > On Mon, 2018-04-09@10:31 +0200, Daniel Vetter wrote: > > > On Thu, Apr 05, 2018@06:39:41PM +0000, Alexey Brodkin wrote: > > > > Hi Daniel, all, > > > > [snip] > > > > > > Ok it was quite some time ago so I forgot about that completely. > > > > I really made one trivial change in xf86-video-armada: > > > > ------------------------>8-------------------------- > > > > --- a/src/armada_module.c > > > > +++ b/src/armada_module.c > > > > @@ -26,7 +26,7 @@ > > > > #define ARMADA_NAME "armada" > > > > #define ARMADA_DRIVER_NAME "armada" > > > > > > > > -#define DRM_MODULE_NAMES "armada-drm", "imx-drm" > > > > +#define DRM_MODULE_NAMES "armada-drm", "imx-drm", "udl" > > > > #define DRM_DEFAULT_BUS_ID NULL > > > > ------------------------>8-------------------------- > > > > > > > > Otherwise Xserver fails on start which is expected given "imx-drm" is intentionally removed. > > > > Here I meant I explicitly disabled DRM_IMX in the kernel configuraion > > so that it is not used in run-time. > > > > > You need to keep imx-drm around. And then light up the udl display using > > > prime. Afaiui it should all just work (but with maybe a few disconnected > > > outputs from imx-drm around that you don't need, but that's not a > > > problem). > > > > And given my comment above I don't really see any difference between > > DRM_IMX and DRM_UDL (except their HW implmentation which I guess should > > not bother upper layers) so why do wee need to treat them differently? > > > > Most probably I'm missing something but my thought was if we have > > 2 equally well supported KMS devices we may easily swap them and still > > have resulting setup functional. > > armada is not a generic drm driver, but can only be used for armada-drm > and imx-drm. You can't just use it with any drm device, for that you need > a generic driver like -modesetting. But "armada" is the name of xf86 "driver" only which then uses true DRM_ETNAVIV kernel driver. That's why I'm a bit confused. And from what I see DRM_ETNAVIV happily works with either DRM_xxx frame-buffer device be it DRM_IMX or DRM_UDL. -Alexey From mboxrd@z Thu Jan 1 00:00:00 1970 From: Alexey Brodkin Subject: Re: DRM_UDL and GPU under Xserver Date: Mon, 9 Apr 2018 09:45:51 +0000 Message-ID: <1523267150.5268.18.camel@synopsys.com> References: <1522912595.4577.5.camel@synopsys.com> <1522924162.3779.16.camel@pengutronix.de> <1522926602.4587.10.camel@synopsys.com> <20180405134421.GV3881@phenom.ffwll.local> <1522953580.3977.10.camel@synopsys.com> <20180409083127.GL31310@phenom.ffwll.local> <1523264135.5268.14.camel@synopsys.com> <20180409091706.GU31310@phenom.ffwll.local> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <20180409091706.GU31310@phenom.ffwll.local> Content-Language: en-US Content-ID: <86121CC4C40A3D408D874E5B4C6BD2B2@internal.synopsys.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-snps-arc" Errors-To: linux-snps-arc-bounces+gla-linux-snps-arc=m.gmane.org@lists.infradead.org To: "daniel@ffwll.ch" Cc: "Jose.Abreu@synopsys.com" , "airlied@linux.ie" , "daniel.vetter@ffwll.ch" , "dri-devel@lists.freedesktop.org" , "seanpaul@chromium.org" , "airlied@redhat.com" , "alexander.deucher@amd.com" , "daniel.vetter@intel.com" , "linux-snps-arc@lists.infradead.org" , "l.stach@pengutronix.de" List-Id: dri-devel@lists.freedesktop.org Hi Daniel, On Mon, 2018-04-09 at 11:17 +0200, Daniel Vetter wrote: > On Mon, Apr 09, 2018 at 08:55:36AM +0000, Alexey Brodkin wrote: > > Hi Daniel, > > > > On Mon, 2018-04-09 at 10:31 +0200, Daniel Vetter wrote: > > > On Thu, Apr 05, 2018 at 06:39:41PM +0000, Alexey Brodkin wrote: > > > > Hi Daniel, all, > > > > [snip] > > > > > > Ok it was quite some time ago so I forgot about that completely. > > > > I really made one trivial change in xf86-video-armada: > > > > ------------------------>8-------------------------- > > > > --- a/src/armada_module.c > > > > +++ b/src/armada_module.c > > > > @@ -26,7 +26,7 @@ > > > > #define ARMADA_NAME "armada" > > > > #define ARMADA_DRIVER_NAME "armada" > > > > > > > > -#define DRM_MODULE_NAMES "armada-drm", "imx-drm" > > > > +#define DRM_MODULE_NAMES "armada-drm", "imx-drm", "udl" > > > > #define DRM_DEFAULT_BUS_ID NULL > > > > ------------------------>8-------------------------- > > > > > > > > Otherwise Xserver fails on start which is expected given "imx-drm" is intentionally removed. > > > > Here I meant I explicitly disabled DRM_IMX in the kernel configuraion > > so that it is not used in run-time. > > > > > You need to keep imx-drm around. And then light up the udl display using > > > prime. Afaiui it should all just work (but with maybe a few disconnected > > > outputs from imx-drm around that you don't need, but that's not a > > > problem). > > > > And given my comment above I don't really see any difference between > > DRM_IMX and DRM_UDL (except their HW implmentation which I guess should > > not bother upper layers) so why do wee need to treat them differently? > > > > Most probably I'm missing something but my thought was if we have > > 2 equally well supported KMS devices we may easily swap them and still > > have resulting setup functional. > > armada is not a generic drm driver, but can only be used for armada-drm > and imx-drm. You can't just use it with any drm device, for that you need > a generic driver like -modesetting. But "armada" is the name of xf86 "driver" only which then uses true DRM_ETNAVIV kernel driver. That's why I'm a bit confused. And from what I see DRM_ETNAVIV happily works with either DRM_xxx frame-buffer device be it DRM_IMX or DRM_UDL. -Alexey