Re: [PATCH 4/7] drm/i915/icl: Add Voltage swing table for MG PHY DDI Buffer

[Paulo Zanoni <paulo.r.zanoni@intel.com>]

Em Ter, 2018-04-10 às 22:07 +0100, Chris Wilson escreveu:
> Quoting Chris Wilson (2018-04-10 22:01:33)
> > Quoting Paulo Zanoni (2018-04-10 21:39:31)
> > > Em Ter, 2018-04-10 às 09:51 +0100, Chris Wilson escreveu:
> > > > Quoting Paulo Zanoni (2018-03-23 17:24:16)
> > > > > From: Manasi Navare <manasi.d.navare@intel.com>
> > > > > 
> > > > > This table is used for voltage swing programming sequence
> > > > > during
> > > > > DDI
> > > > > Buffer initialization for MG PHY DDI Buffers on Icelake.
> > > > 
> > > > Except it is not used at all...
> > > 
> > > It's going to be used later in the series.
> 
> In the context of this patch in merged series, it means that we have
> added unexecuted, untested code. Please justify that. (Unused data
> tables have in the past remain unused, leaving the code using old
> tables; a bug that would have been caught by the compiler.)
> 
> We know our test coverage is lacking, this makes it worse. Yes, it's
> icl, yes we won't even have sim coverage for the entire set of freq
> tables, so what's stopping us from writing unittests to double check
> the
> code at least conforms to our expectations and is exercised?

We have properly tested this code and verified it works. It's just that
we didn't upstream the whole series yet since it's too big. Almost 100
ICL patches already made it to the list already, and about 60 were
merged, but the specific patch that uses that table is not here yet.
I'll take the blame for missing that patch from this series.

> -Chris
_______________________________________________
Intel-gfx mailing list
Intel-gfx@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/intel-gfx