From: Laurent Pinchart <laurent.pinchart@ideasonboard.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: linux-media@vger.kernel.org
Subject: Re: [PATCH] mt9p031: Use bulk regulator API
Date: Mon, 10 Jun 2013 11:48:30 +0200 [thread overview]
Message-ID: <15234200.VFxHPLf0eZ@avalon> (raw)
In-Reply-To: <CAOMZO5DQyeUYVdK0X0OsG51MkGjbN8d_51DW_zhVBZOHLptOQw@mail.gmail.com>
Hi Fabio,
On Saturday 08 June 2013 10:20:42 Fabio Estevam wrote:
> On Sat, Jun 8, 2013 at 4:55 AM, Laurent Pinchart wrote:
> > - if (IS_ERR(mt9p031->vaa) || IS_ERR(mt9p031->vdd) ||
> > - IS_ERR(mt9p031->vdd_io)) {
> > + ret = devm_regulator_bulk_get(&client->dev, 3,
> > mt9p031->regulators); + if (ret < 0) {
> >
> > dev_err(&client->dev, "Unable to get regulators\n");
> > return -ENODEV;
>
> You should do a 'return ret' here instead.
Good point, I'll fix that.
--
Regards,
Laurent Pinchart
next prev parent reply other threads:[~2013-06-10 9:48 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-06-08 7:55 [PATCH] mt9p031: Use bulk regulator API Laurent Pinchart
2013-06-08 13:20 ` Fabio Estevam
2013-06-08 13:24 ` Fabio Estevam
2013-06-10 9:49 ` Laurent Pinchart
2013-06-10 9:48 ` Laurent Pinchart [this message]
-- strict thread matches above, loose matches on Subject: below --
2013-06-10 9:51 Laurent Pinchart
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=15234200.VFxHPLf0eZ@avalon \
--to=laurent.pinchart@ideasonboard.com \
--cc=festevam@gmail.com \
--cc=linux-media@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.