From mboxrd@z Thu Jan  1 00:00:00 1970
From: John Spotswood <john.a.spotswood@intel.com>
Subject: Re: [PATCH v3 1/4] drm/i915: Always do WOPCM
 partitioning based on real firmware sizes
Date: Fri, 13 Apr 2018 16:33:37 -0700
Message-ID: <1523662417.3618.2.camel@intel.com>
References: <1523320940-32742-1-git-send-email-yaodong.li@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: base64
Return-path: <intel-gfx-bounces@lists.freedesktop.org>
Received: from mga02.intel.com (mga02.intel.com [134.134.136.20])
 by gabe.freedesktop.org (Postfix) with ESMTPS id 091ED6EBCD
 for <intel-gfx@lists.freedesktop.org>; Fri, 13 Apr 2018 23:33:38 +0000 (UTC)
In-Reply-To: <1523320940-32742-1-git-send-email-yaodong.li@intel.com>
List-Unsubscribe: <https://lists.freedesktop.org/mailman/options/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <https://lists.freedesktop.org/archives/intel-gfx>
List-Post: <mailto:intel-gfx@lists.freedesktop.org>
List-Help: <mailto:intel-gfx-request@lists.freedesktop.org?subject=help>
List-Subscribe: <https://lists.freedesktop.org/mailman/listinfo/intel-gfx>,
 <mailto:intel-gfx-request@lists.freedesktop.org?subject=subscribe>
Errors-To: intel-gfx-bounces@lists.freedesktop.org
Sender: "Intel-gfx" <intel-gfx-bounces@lists.freedesktop.org>
To: Jackie Li <yaodong.li@intel.com>, intel-gfx@lists.freedesktop.org
List-Id: intel-gfx@lists.freedesktop.org

T24gTW9uLCAyMDE4LTA0LTA5IGF0IDE3OjQyIC0wNzAwLCBKYWNraWUgTGkgd3JvdGU6Cj4gQWZ0
ZXIgZW5hYmxlZCB0aGUgV09QQ00gd3JpdGUtb25jZSByZWdpc3RlcnMgbG9ja2luZyBzdGF0dXMg
Y2hlY2tpbmcsCj4gcmVsb2FkaW5nIG9mIHRoZSBpOTE1IG1vZHVsZSB3aWxsIGZhaWwgd2l0aCBt
b2RwYXJhbSBlbmFibGVfZ3VjIHNldAo+IHRvIDMKPiAoZW5hYmxlIEd1QyBhbmQgSHVDIGZpcm13
YXJlIGxvYWRpbmcpIGlmIHRoZSBtb2R1bGUgd2FzIG9yaWdpbmFsbHkKPiBsb2FkZWQKPiB3aXRo
IGVuYWJsZV9ndWMgc2V0IHRvIDEgKG9ubHkgZW5hYmxlIEd1QyBmaXJtd2FyZSBsb2FkaW5nKS4g
VGhpcyBpcwo+IGJlY2F1c2UgV09QQ00gcmVnaXN0ZXJzIHdlcmUgdXBkYXRlZCBhbmQgbG9ja2Vk
IHdpdGhvdXQgY29uc2lkZXJpbmcKPiB0aGUgSHVDCj4gRlcgc2l6ZS4gU2luY2Ugd2UgbmVlZCBi
b3RoIEd1QyBhbmQgSHVDIEZXIHNpemVzIHRvIGRldGVybWluZSB0aGUKPiBmaW5hbAo+IGxheW91
dCBvZiBXT1BDTSwgd2Ugc2hvdWxkIGFsd2F5cyBjYWxjdWxhdGUgdGhlIFdPUENNIGxheW91dCBi
YXNlZCBvbgo+IHRoZQo+IGFjdHVhbCBzaXplcyBvZiB0aGUgR3VDIGFuZCBIdUMgZmlybXdhcmUg
YXZhaWxhYmxlIGZvciBhIHNwZWNpZmljCj4gcGxhdGZvcm0KPiBpZiB3ZSBuZWVkIGNvbnRpbnVl
IHRvIHN1cHBvcnQgZW5hYmxlL2Rpc2FibGUgSHVDIEZXIGxvYWRpbmcKPiBkeW5hbWljYWxseQo+
IHdpdGggZW5hYmxlX2d1YyBtb2RwYXJhbS4KPiAKPiBUaGlzIHBhdGNoIHNwbGl0cyB1QyBmaXJt
d2FyZSBmZXRjaGluZyBpbnRvIHR3byBzdGFnZXMuIEZpcnN0IHN0YWdlCj4gaXMgdG8KPiBmZXRj
aCB0aGUgZmlybXdhcmUgaW1hZ2UgYW5kIHZlcmlmeSB0aGUgZmlybXdhcmUgaGVhZGVyLiB1QyBm
aXJtd2FyZQo+IHdpbGwKPiBiZSBtYXJrZWQgYXMgdmVyaWZpZWQgYW5kIHRoaXMgd2lsbCBtYWtl
IEZXIGluZm8gYXZhaWxhYmxlIGZvcgo+IGZvbGxvd2luZwo+IFdPUENNIGxheW91dCBjYWxjdWxh
dGlvbi4gVGhlIHNlY29uZCBzdGFnZSBpcyB0byBjcmVhdGUgYSBHRU0gb2JqZWN0Cj4gYW5kCj4g
Y29weSB0aGUgRlcgZGF0YSBpbnRvIHRoZSBjcmVhdGVkIEdFTSBvYmplY3Qgd2hpY2ggd2lsbCBv
bmx5IGJlCj4gYXZhaWxhYmxlCj4gd2hlbiBHdUMvSHVDIGxvYWRpbmcgaXMgZW5hYmxlZCBieSBl
bmFibGVfZ3VjIG1vZHBhcmFtLiBUaGlzIHdpbGwKPiBndWFyYW50ZWUKPiB0aGF0IHRoZSBXT1BD
TSBsYXlvdXQgd2lsbCBiZSBhbHdheXMgYmUgY2FsY3VsYXRlZCBjb3JyZWN0bHkgd2l0aG91dAo+
IG1ha2luZwo+IGFueSBhc3N1bXB0aW9ucyB0byB0aGUgR3VDIGFuZCBIdUMgZmlybXdhcmUgc2l6
ZXMuCj4gCj4gdjM6Cj4gwqAtIFJlYmFzZQo+IAo+IFNpZ25lZC1vZmYtYnk6IEphY2tpZSBMaSA8
eWFvZG9uZy5saUBpbnRlbC5jb20+Cj4gQ2M6IE1pY2hhbCBXYWpkZWN6a28gPG1pY2hhbC53YWpk
ZWN6a29AaW50ZWwuY29tPgo+IENjOiBTYWdhciBBcnVuIEthbWJsZSA8c2FnYXIuYS5rYW1ibGVA
aW50ZWwuY29tPgo+IENjOiBNaWNoYWwgV2luaWFyc2tpIDxtaWNoYWwud2luaWFyc2tpQGludGVs
LmNvbT4KPiBDYzogSm9obiBTcG90c3dvb2QgPGpvaG4uYS5zcG90c3dvb2RAaW50ZWwuY29tPgo+
IENjOiBKb29uYXMgTGFodGluZW4gPGpvb25hcy5sYWh0aW5lbkBsaW51eC5pbnRlbC5jb20+CgpS
ZXZpZXdlZC1ieTogSm9obiBTcG90c3dvb2QgPGpvaG4uYS5zcG90c3dvb2RAaW50ZWwuY29tPgoK
PiAtLS0KPiDCoGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3VjLmPCoMKgwqDCoHwgMTQgKysr
Ky0tLS0tLS0tLS0KPiDCoGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3VjX2Z3LmMgfCAzMSAr
KysrKysrKysrKysrKysrKysrKy0tLS0tLQo+IC0tLS0tCj4gwqBkcml2ZXJzL2dwdS9kcm0vaTkx
NS9pbnRlbF91Y19mdy5oIHzCoMKgNyArKysrKy0tCj4gwqAzIGZpbGVzIGNoYW5nZWQsIDI5IGlu
c2VydGlvbnMoKyksIDIzIGRlbGV0aW9ucygtKQo+IAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dw
dS9kcm0vaTkxNS9pbnRlbF91Yy5jCj4gYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF91Yy5j
Cj4gaW5kZXggMWNmZmFmNy4uNzNiOGY2YyAxMDA2NDQKPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0v
aTkxNS9pbnRlbF91Yy5jCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfdWMuYwo+
IEBAIC0xNzIsMTEgKzE3Miw4IEBAIHZvaWQgaW50ZWxfdWNfaW5pdF9lYXJseShzdHJ1Y3QgZHJt
X2k5MTVfcHJpdmF0ZQo+ICppOTE1KQo+IMKgCj4gwqAJc2FuaXRpemVfb3B0aW9uc19lYXJseShp
OTE1KTsKPiDCoAo+IC0JaWYgKFVTRVNfR1VDKGk5MTUpKQo+IC0JCWludGVsX3VjX2Z3X2ZldGNo
KGk5MTUsICZndWMtPmZ3KTsKPiAtCj4gLQlpZiAoVVNFU19IVUMoaTkxNSkpCj4gLQkJaW50ZWxf
dWNfZndfZmV0Y2goaTkxNSwgJmh1Yy0+ZncpOwo+ICsJaW50ZWxfdWNfZndfZmV0Y2goaTkxNSwg
Jmd1Yy0+ZncsIFVTRVNfR1VDKGk5MTUpKTsKPiArCWludGVsX3VjX2Z3X2ZldGNoKGk5MTUsICZo
dWMtPmZ3LCBVU0VTX0hVQyhpOTE1KSk7Cj4gwqB9Cj4gwqAKPiDCoHZvaWQgaW50ZWxfdWNfY2xl
YW51cF9lYXJseShzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqaTkxNSkKPiBAQCAtMTg0LDExICsx
ODEsOCBAQCB2b2lkIGludGVsX3VjX2NsZWFudXBfZWFybHkoc3RydWN0Cj4gZHJtX2k5MTVfcHJp
dmF0ZSAqaTkxNSkKPiDCoAlzdHJ1Y3QgaW50ZWxfZ3VjICpndWMgPSAmaTkxNS0+Z3VjOwo+IMKg
CXN0cnVjdCBpbnRlbF9odWMgKmh1YyA9ICZpOTE1LT5odWM7Cj4gwqAKPiAtCWlmIChVU0VTX0hV
QyhpOTE1KSkKPiAtCQlpbnRlbF91Y19md19maW5pKCZodWMtPmZ3KTsKPiAtCj4gLQlpZiAoVVNF
U19HVUMoaTkxNSkpCj4gLQkJaW50ZWxfdWNfZndfZmluaSgmZ3VjLT5mdyk7Cj4gKwlpbnRlbF91
Y19md19maW5pKCZodWMtPmZ3KTsKPiArCWludGVsX3VjX2Z3X2ZpbmkoJmd1Yy0+ZncpOwo+IMKg
Cj4gwqAJZ3VjX2ZyZWVfbG9hZF9lcnJfbG9nKGd1Yyk7Cj4gwqB9Cj4gZGlmZiAtLWdpdCBhL2Ry
aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3VjX2Z3LmMKPiBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1
L2ludGVsX3VjX2Z3LmMKPiBpbmRleCA2ZThlMGI1Li5hOWNiOTAwIDEwMDY0NAo+IC0tLSBhL2Ry
aXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3VjX2Z3LmMKPiArKysgYi9kcml2ZXJzL2dwdS9kcm0v
aTkxNS9pbnRlbF91Y19mdy5jCj4gQEAgLTMzLDExICszMywxMyBAQAo+IMKgICoKPiDCoCAqIEBk
ZXZfcHJpdjogZGV2aWNlIHByaXZhdGUKPiDCoCAqIEB1Y19mdzogdUMgZmlybXdhcmUKPiArICog
QGNvcHlfdG9fb2JqOiB3aGV0aGVyIGZldGNoIHVDIGZpcm13YXJlIGludG8gR0VNIG9iamVjdCBv
ciBub3QKPiDCoCAqCj4gLSAqIEZldGNoIHVDIGZpcm13YXJlIGludG8gR0VNIG9iai4KPiArICog
RmV0Y2ggYW5kIHZlcmlmeSB1QyBmaXJtd2FyZSBhbmQgY29weSBmaXJtd2FyZSBkYXRhIGludG8g
R0VNCj4gb2JqZWN0IGlmCj4gKyAqIEBjb3B5X3RvX29iaiBpcyB0cnVlLgo+IMKgICovCj4gwqB2
b2lkIGludGVsX3VjX2Z3X2ZldGNoKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwK
PiAtCQnCoMKgwqDCoMKgwqDCoHN0cnVjdCBpbnRlbF91Y19mdyAqdWNfZncpCj4gKwkJwqDCoMKg
wqDCoMKgwqBzdHJ1Y3QgaW50ZWxfdWNfZncgKnVjX2Z3LCBib29sIGNvcHlfdG9fb2JqKQo+IMKg
ewo+IMKgCXN0cnVjdCBwY2lfZGV2ICpwZGV2ID0gZGV2X3ByaXYtPmRybS5wZGV2Owo+IMKgCXN0
cnVjdCBkcm1faTkxNV9nZW1fb2JqZWN0ICpvYmo7Cj4gQEAgLTE1NCwxNyArMTU2LDI0IEBAIHZv
aWQgaW50ZWxfdWNfZndfZmV0Y2goc3RydWN0IGRybV9pOTE1X3ByaXZhdGUKPiAqZGV2X3ByaXYs
Cj4gwqAJCWdvdG8gZmFpbDsKPiDCoAl9Cj4gwqAKPiAtCW9iaiA9IGk5MTVfZ2VtX29iamVjdF9j
cmVhdGVfZnJvbV9kYXRhKGRldl9wcml2LCBmdy0+ZGF0YSwKPiBmdy0+c2l6ZSk7Cj4gLQlpZiAo
SVNfRVJSKG9iaikpIHsKPiAtCQllcnIgPSBQVFJfRVJSKG9iaik7Cj4gLQkJRFJNX0RFQlVHX0RS
SVZFUigiJXMgZncgb2JqZWN0X2NyZWF0ZSBlcnI9JWRcbiIsCj4gLQkJCQnCoGludGVsX3VjX2Z3
X3R5cGVfcmVwcih1Y19mdy0+dHlwZSksIAo+IGVycik7Cj4gLQkJZ290byBmYWlsOwo+ICsJdWNf
ZnctPnNpemUgPSBmdy0+c2l6ZTsKPiArCXVjX2Z3LT5mZXRjaF9zdGF0dXMgPSBJTlRFTF9VQ19G
SVJNV0FSRV9WRVJJRklFRDsKPiArCj4gKwlpZiAoY29weV90b19vYmopIHsKPiArCQlvYmogPSBp
OTE1X2dlbV9vYmplY3RfY3JlYXRlX2Zyb21fZGF0YShkZXZfcHJpdiwgZnctCj4gPmRhdGEsCj4g
KwkJCQkJCcKgwqDCoMKgwqDCoMKgZnctPnNpemUpOwo+ICsJCWlmIChJU19FUlIob2JqKSkgewo+
ICsJCQllcnIgPSBQVFJfRVJSKG9iaik7Cj4gKwkJCURSTV9ERUJVR19EUklWRVIoIiVzIGZ3IG9i
amVjdF9jcmVhdGUKPiBlcnI9JWRcbiIsCj4gKwkJCQkJwqBpbnRlbF91Y19md190eXBlX3JlcHIo
dWNfZncKPiAtPnR5cGUpLAo+ICsJCQkJCcKgZXJyKTsKPiArCQkJZ290byBmYWlsOwo+ICsJCX0K
PiArCj4gKwkJdWNfZnctPm9iaiA9IG9iajsKPiArCQl1Y19mdy0+ZmV0Y2hfc3RhdHVzID0gSU5U
RUxfVUNfRklSTVdBUkVfU1VDQ0VTUzsKPiDCoAl9Cj4gwqAKPiAtCXVjX2Z3LT5vYmogPSBvYmo7
Cj4gLQl1Y19mdy0+c2l6ZSA9IGZ3LT5zaXplOwo+IC0JdWNfZnctPmZldGNoX3N0YXR1cyA9IElO
VEVMX1VDX0ZJUk1XQVJFX1NVQ0NFU1M7Cj4gwqAJRFJNX0RFQlVHX0RSSVZFUigiJXMgZncgZmV0
Y2ggJXNcbiIsCj4gwqAJCQnCoGludGVsX3VjX2Z3X3R5cGVfcmVwcih1Y19mdy0+dHlwZSksCj4g
wqAJCQnCoGludGVsX3VjX2Z3X3N0YXR1c19yZXByKHVjX2Z3LQo+ID5mZXRjaF9zdGF0dXMpKTsK
PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfdWNfZncuaAo+IGIvZHJp
dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfdWNfZncuaAo+IGluZGV4IGRjMzNiMTIuLjRlN2VjYzgg
MTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfdWNfZncuaAo+ICsrKyBi
L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3VjX2Z3LmgKPiBAQCAtMzYsNiArMzYsNyBAQCBl
bnVtIGludGVsX3VjX2Z3X3N0YXR1cyB7Cj4gwqAJSU5URUxfVUNfRklSTVdBUkVfRkFJTCA9IC0x
LAo+IMKgCUlOVEVMX1VDX0ZJUk1XQVJFX05PTkUgPSAwLAo+IMKgCUlOVEVMX1VDX0ZJUk1XQVJF
X1BFTkRJTkcsCj4gKwlJTlRFTF9VQ19GSVJNV0FSRV9WRVJJRklFRCwKPiDCoAlJTlRFTF9VQ19G
SVJNV0FSRV9TVUNDRVNTCj4gwqB9Owo+IMKgCj4gQEAgLTg0LDYgKzg1LDggQEAgY29uc3QgY2hh
ciAqaW50ZWxfdWNfZndfc3RhdHVzX3JlcHIoZW51bQo+IGludGVsX3VjX2Z3X3N0YXR1cyBzdGF0
dXMpCj4gwqAJCXJldHVybiAiTk9ORSI7Cj4gwqAJY2FzZSBJTlRFTF9VQ19GSVJNV0FSRV9QRU5E
SU5HOgo+IMKgCQlyZXR1cm4gIlBFTkRJTkciOwo+ICsJY2FzZSBJTlRFTF9VQ19GSVJNV0FSRV9W
RVJJRklFRDoKPiArCQlyZXR1cm4gIlZFUklGSUVEIjsKPiDCoAljYXNlIElOVEVMX1VDX0ZJUk1X
QVJFX1NVQ0NFU1M6Cj4gwqAJCXJldHVybiAiU1VDQ0VTUyI7Cj4gwqAJfQo+IEBAIC0xMzEsMTQg
KzEzNCwxNCBAQCBzdGF0aWMgaW5saW5lIHZvaWQgaW50ZWxfdWNfZndfc2FuaXRpemUoc3RydWN0
Cj4gaW50ZWxfdWNfZncgKnVjX2Z3KQo+IMKgICovCj4gwqBzdGF0aWMgaW5saW5lIHUzMiBpbnRl
bF91Y19md19nZXRfdXBsb2FkX3NpemUoc3RydWN0IGludGVsX3VjX2Z3Cj4gKnVjX2Z3KQo+IMKg
ewo+IC0JaWYgKHVjX2Z3LT5mZXRjaF9zdGF0dXMgIT0gSU5URUxfVUNfRklSTVdBUkVfU1VDQ0VT
UykKPiArCWlmICh1Y19mdy0+ZmV0Y2hfc3RhdHVzIDwgSU5URUxfVUNfRklSTVdBUkVfVkVSSUZJ
RUQpCj4gwqAJCXJldHVybiAwOwo+IMKgCj4gwqAJcmV0dXJuIHVjX2Z3LT5oZWFkZXJfc2l6ZSAr
IHVjX2Z3LT51Y29kZV9zaXplOwo+IMKgfQo+IMKgCj4gwqB2b2lkIGludGVsX3VjX2Z3X2ZldGNo
KHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPiAtCQnCoMKgwqDCoMKgwqDCoHN0
cnVjdCBpbnRlbF91Y19mdyAqdWNfZncpOwo+ICsJCcKgwqDCoMKgwqDCoMKgc3RydWN0IGludGVs
X3VjX2Z3ICp1Y19mdywgYm9vbCBjb3B5X3RvX29iaik7Cj4gwqBpbnQgaW50ZWxfdWNfZndfdXBs
b2FkKHN0cnVjdCBpbnRlbF91Y19mdyAqdWNfZncsCj4gwqAJCcKgwqDCoMKgwqDCoMKgaW50ICgq
eGZlcikoc3RydWN0IGludGVsX3VjX2Z3ICp1Y19mdywKPiDCoAkJCQnCoMKgwqBzdHJ1Y3QgaTkx
NV92bWEgKnZtYSkpOwpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f
X19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5v
cmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1n
ZngK