From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paulo Zanoni Subject: Re: [PATCH v4] drm/i915: Enable edp psr error interrupts on hsw Date: Mon, 16 Apr 2018 17:43:54 -0700 Message-ID: <1523925834.2851.12.camel@intel.com> References: <82837b06728ac13f65449c11d1b6acf59a8fa2f5.camel@intel.com> <20180405220023.9449-1-dhinakaran.pandiyan@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTPS id 635276E3D3 for ; Tue, 17 Apr 2018 00:44:09 +0000 (UTC) In-Reply-To: <20180405220023.9449-1-dhinakaran.pandiyan@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Dhinakaran Pandiyan , intel-gfx@lists.freedesktop.org Cc: Daniel Vetter , Daniel Vetter , Rodrigo Vivi List-Id: intel-gfx@lists.freedesktop.org RW0gUXVpLCAyMDE4LTA0LTA1IMOgcyAxNTowMCAtMDcwMCwgRGhpbmFrYXJhbiBQYW5kaXlhbiBl c2NyZXZldToKPiBGcm9tOiBEYW5pZWwgVmV0dGVyIDxkYW5pZWwudmV0dGVyQGZmd2xsLmNoPgo+ IAo+IFRoZSBkZWZpbml0aW9ucyBmb3IgdGhlIGVycm9yIHJlZ2lzdGVyIHNob3VsZCBiZSB2YWxp ZCBvbiBiZHcvc2tsCj4gdG9vLAo+IGJ1dCB0aGVyZSB3ZSBoYXZlbid0IGV2ZW4gZW5hYmxlZCBE RV9NSVNDIGhhbmRsaW5nIHlldC4KPiAKPiBTb21ld2hhdCBjb25mdXNpbmcgdGhlIHRoZSBtb3Zl ZCByZWdpc3RlciBvZmZzZXQgb24gYmR3IGlzIG9ubHkgZm9yCj4gdGhlIF9DVEwvX0FVWCByZWdp c3RlciwgYW5kIHRoYXQgX0lJUi9JTVIgc3RheWVkIHdoZXJlIHRoZXkgaGF2ZSBiZWVuCj4gb24g YmR3Lgo+IAo+IHYyOiBGaXhlcyBmcm9tIFZpbGxlLgo+IAo+IHYzOiBGcm9tIERLCj4gICogUmVi YXNlZCBvbiBkcm0tdGlwCj4gICogUmVtb3ZlZCBCRFcgSUlSIGJpdCBkZWZpbml0aW9uLCBsb29r cyBsaWtlIGFuIHVuaW50ZW50aW9uYWwgY2hhbmdlCj4gdGhhdAo+IHNob3VsZCBiZSBpbiB0aGUg Zm9sbG93aW5nIHBhdGNoLgo+IAo+IHY0OiBGcm9tIERLCj4gICogRG9uJ3QgbWFzayBSRUdfV1JJ VEUuCj4gCj4gUmVmZXJlbmNlczogYnNwZWMvMTE5NzQgW1NSRCBJbnRlcnJ1cHQgQml0IERlZmlu aXRpb24gRGV2SFNXXQo+IENjOiBWaWxsZSBTeXJqw6Rsw6QgPHZpbGxlLnN5cmphbGFAbGludXgu aW50ZWwuY29tPgo+IENjOiBSb2RyaWdvIFZpdmkgPHJvZHJpZ28udml2aUBpbnRlbC5jb20+Cj4g Q2M6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAaW50ZWwuY29tPgo+IFNpZ25lZC1vZmYt Ynk6IERhbmllbCBWZXR0ZXIgPGRhbmllbC52ZXR0ZXJAaW50ZWwuY29tPgo+IFNpZ25lZC1vZmYt Ynk6IERoaW5ha2FyYW4gUGFuZGl5YW4gPGRoaW5ha2FyYW4ucGFuZGl5YW5AaW50ZWwuY29tPgo+ IFJldmlld2VkLWJ5OiBKb3NlIFJvYmVydG8gZGUgU291emEgPGpvc2Uuc291emFAaW50ZWwuY29t Pgo+IC0tLQo+ICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2lycS5jIHwgMzQKPiArKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrCj4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf cmVnLmggfCAgOCArKysrKysrKwo+ICAyIGZpbGVzIGNoYW5nZWQsIDQyIGluc2VydGlvbnMoKykK PiAKPiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9pcnEuYwo+IGIvZHJp dmVycy9ncHUvZHJtL2k5MTUvaTkxNV9pcnEuYwo+IGluZGV4IDI3YWVlMjU0MjliNy4uYzJkM2Yz MDc3OGVlIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfaXJxLmMKPiAr KysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2lycS5jCj4gQEAgLTIzOTEsNiArMjM5MSwy NiBAQCBzdGF0aWMgdm9pZCBpbGtfZGlzcGxheV9pcnFfaGFuZGxlcihzdHJ1Y3QKPiBkcm1faTkx NV9wcml2YXRlICpkZXZfcHJpdiwKPiAgCQlpcm9ubGFrZV9ycHNfY2hhbmdlX2lycV9oYW5kbGVy KGRldl9wcml2KTsKPiAgfQo+ICAKPiArc3RhdGljIHZvaWQgaHN3X2VkcF9wc3JfaXJxX2hhbmRs ZXIoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUKPiAqZGV2X3ByaXYpCj4gK3sKPiArCXUzMiBlZHBf cHNyX2lpciA9IEk5MTVfUkVBRChFRFBfUFNSX0lJUik7Cj4gKwo+ICsJaWYgKGVkcF9wc3JfaWly ICYgRURQX1BTUl9FUlJPUikKPiArCQlEUk1fREVCVUdfS01TKCJQU1IgZXJyb3JcbiIpOwo+ICsK PiArCWlmIChlZHBfcHNyX2lpciAmIEVEUF9QU1JfUFJFX0VOVFJZKSB7Cj4gKwkJRFJNX0RFQlVH X0tNUygiUFNSIHByZXBhcmUgZW50cnkgaW4gMiB2YmxhbmtzXG4iKTsKPiArCQlJOTE1X1dSSVRF KEVEUF9QU1JfSU1SLCBFRFBfUFNSX1BSRV9FTlRSWSk7CgpXaHkgYXJlIHdlIG1hc2tpbmcgaXQg aGVyZT8gRHVyaW5nIHRoZXNlIDIgdmJsYW5rcyBpdCdzIHBvc3NpYmxlIHRoYXQKc29tZXRoaW5n IHdpbGwgaGFwcGVuIChlLmcuLCBmcm9udGJ1ZmZlciB3cml0aW5nLCBjdXJzb3IgbW92aW5nLCBw YWdlCmZsaXBwaW5nKS4gQXJlIHdlIGd1YXJhbnRlZWQgdG8gZ2V0IGEgUE9TVF9FWElUIGludGVy cnVwdCBldmVuIGlmIHdlCmdpdmUgdXAgZW50ZXJpbmcgUFNSIGJlZm9yZSBpdCBpcyBhY3R1YWxs eSBlbnRlcmVkPwoKCj4gKwl9Cj4gKwo+ICsJaWYgKGVkcF9wc3JfaWlyICYgRURQX1BTUl9QT1NU X0VYSVQpIHsKPiArCQlEUk1fREVCVUdfS01TKCJQU1IgZXhpdCBjb21wbGV0ZWRcbiIpOwo+ICsJ CUk5MTVfV1JJVEUoRURQX1BTUl9JTVIsIDApOwo+ICsJfQo+ICsKPiArCUk5MTVfV1JJVEUoRURQ X1BTUl9JSVIsIGVkcF9wc3JfaWlyKTsKPiArfQo+ICsKPiAgc3RhdGljIHZvaWQgaXZiX2Rpc3Bs YXlfaXJxX2hhbmRsZXIoc3RydWN0IGRybV9pOTE1X3ByaXZhdGUKPiAqZGV2X3ByaXYsCj4gIAkJ CQkgICAgdTMyIGRlX2lpcikKPiAgewo+IEBAIC0yNDAzLDYgKzI0MjMsOSBAQCBzdGF0aWMgdm9p ZCBpdmJfZGlzcGxheV9pcnFfaGFuZGxlcihzdHJ1Y3QKPiBkcm1faTkxNV9wcml2YXRlICpkZXZf cHJpdiwKPiAgCWlmIChkZV9paXIgJiBERV9FUlJfSU5UX0lWQikKPiAgCQlpdmJfZXJyX2ludF9o YW5kbGVyKGRldl9wcml2KTsKPiAgCj4gKwlpZiAoZGVfaWlyICYgREVfRURQX1BTUl9JTlRfSFNX KQo+ICsJCWhzd19lZHBfcHNyX2lycV9oYW5kbGVyKGRldl9wcml2KTsKPiArCj4gIAlpZiAoZGVf aWlyICYgREVfQVVYX0NIQU5ORUxfQV9JVkIpCj4gIAkJZHBfYXV4X2lycV9oYW5kbGVyKGRldl9w cml2KTsKPiAgCj4gQEAgLTMyNjAsNiArMzI4MywxMSBAQCBzdGF0aWMgdm9pZCBpcm9ubGFrZV9p cnFfcmVzZXQoc3RydWN0Cj4gZHJtX2RldmljZSAqZGV2KQo+ICAJaWYgKElTX0dFTjcoZGV2X3By aXYpKQo+ICAJCUk5MTVfV1JJVEUoR0VON19FUlJfSU5ULCAweGZmZmZmZmZmKTsKPiAgCj4gKwlp ZiAoSVNfSEFTV0VMTChkZXZfcHJpdikpIHsKPiArCQlJOTE1X1dSSVRFKEVEUF9QU1JfSU1SLCAw eGZmZmZmZmZmKTsKPiArCQlJOTE1X1dSSVRFKEVEUF9QU1JfSUlSLCAweGZmZmZmZmZmKTsKPiAr CX0KCldlIG5lZWQgYW5vdGhlciBJSVIgd3JpdGUgd2UgZG8gZm9yIHRoZSBvdGhlciBwbGF0Zm9y bXMuIFRoaXMgaXMgbm90CmNhcmdvIGN1bHQgKGFzIG1lbnRpb25lZCBpbiBwcmV2aW91cyByZXZp ZXcgZW1haWxzKSwgdGhpcyBpcyByZXF1aXJlZApzaW5jZSBvdXIgaGFyZHdhcmUgaXMgYWJsZSB0 byBzdG9yZSBtb3JlIHRoYW4gb25lIElJUiBpbnRlcnJ1cHQuIFBsZWFzZQpkbyBpdCBsaWtlIHdl IGRvIGZvciB0aGUgb3RoZXIgaW50ZXJydXB0cy4KCkRvIGdpdC1ibGFtZSBpbiB0aGUgcmVsZXZh bnQgbGluZXMgYW5kIHJlYWQgdGhlIGNvbW1pdCBtZXNzYWdlcyBmb3IKbW9yZSBpbmZvcm1hdGlv biBvbiB3aHkgc3R1ZmYgaXMgdGhlIHdheSBpdCBpcy4gSWYgeW91IHN0aWxsIHRoaW5rIHRoaXMK aXMgdW5uZWNlc3NhcnksIGZlZWwgZnJlZSB0byB3cml0ZSBhIHBhdGNoIHJlbW92aW5nIHRoZSB1 bm5lY2Vzc2FyeQpzdHVmZiBmb3IgZXZlcnkgaW50ZXJydXB0IGluc3RlYWQgb2Ygb2YgbWFraW5n IGp1c3Qgb25lIHJlZ2lzdGVyIGJlCm5vdC1jYXJnby1jdWx0ZWQuCgo+ICsKPiAgCWdlbjVfZ3Rf aXJxX3Jlc2V0KGRldl9wcml2KTsKPiAgCj4gIAlpYnhfaXJxX3Jlc2V0KGRldl9wcml2KTsKPiBA QCAtMzY3MSw2ICszNjk5LDEyIEBAIHN0YXRpYyBpbnQgaXJvbmxha2VfaXJxX3Bvc3RpbnN0YWxs KHN0cnVjdAo+IGRybV9kZXZpY2UgKmRldikKPiAgCQkJICAgICAgREVfRFBfQV9IT1RQTFVHKTsK PiAgCX0KPiAgCj4gKwlpZiAoSVNfSEFTV0VMTChkZXZfcHJpdikpIHsKPiArCQlnZW4zX2Fzc2Vy dF9paXJfaXNfemVybyhkZXZfcHJpdiwgRURQX1BTUl9JSVIpOwo+ICsJCUk5MTVfV1JJVEUoRURQ X1BTUl9JTVIsIDApOwo+ICsJCWRpc3BsYXlfbWFzayB8PSBERV9FRFBfUFNSX0lOVF9IU1c7Cj4g Kwl9Cj4gKwo+ICAJZGV2X3ByaXYtPmlycV9tYXNrID0gfmRpc3BsYXlfbWFzazsKPiAgCj4gIAlp YnhfaXJxX3ByZV9wb3N0aW5zdGFsbChkZXYpOwo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pOTE1X3JlZy5oCj4gYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlZy5oCj4g aW5kZXggMTc2ZGNhNjU1NGY0Li5mNTc4M2Q2ZGI2MTQgMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9n cHUvZHJtL2k5MTUvaTkxNV9yZWcuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVf cmVnLmgKPiBAQCAtNDAxMSw2ICs0MDExLDEzIEBAIGVudW0gewo+ICAjZGVmaW5lICAgRURQX1BT Ul9UUDFfVElNRV8wdXMJCQkoMzw8NCkKPiAgI2RlZmluZSAgIEVEUF9QU1JfSURMRV9GUkFNRV9T SElGVAkJMAo+ICAKPiArLyogQnNwZWMgY2xhaW1zIHRob3NlIGFyZW4ndCBzaGlmdGVkIGJ1dCBz dGF5IGF0IDB4NjQ4MDAgKi8KPiArI2RlZmluZSBFRFBfUFNSX0lNUgkJCQlfTU1JTygweDY0ODM0 KQo+ICsjZGVmaW5lIEVEUF9QU1JfSUlSCQkJCV9NTUlPKDB4NjQ4MzgpCj4gKyNkZWZpbmUgICBF RFBfUFNSX0VSUk9SCQkJCSgxPDwyKQo+ICsjZGVmaW5lICAgRURQX1BTUl9QT1NUX0VYSVQJCQko MTw8MSkKPiArI2RlZmluZSAgIEVEUF9QU1JfUFJFX0VOVFJZCQkJKDE8PDApCj4gKwoKSSBrbm93 IHlvdSdsbCByZW1vdmUgdGhlc2UgZGVmaW5pdGlvbnMgaW4gdGhlIG5leHQgcGF0Y2gsIGJ1dCBw bGVhc2UKbWFrZSBzdXJlIHlvdSBhZGQgdGhlIGRlZmluaXRpb25zIGZvbGxvd2luZyB0aGUgbmV3 IHN0YW5kYXJkIGRlc2NyaWJlZAphdCB0aGUgdG9wIG9mIHRoZSBmaWxlOiAoMSA8PCAxKSBpbnN0 ZWFkIG9mICgxPDwxKS4KCgo+ICAjZGVmaW5lIEVEUF9QU1JfQVVYX0NUTAkJCQlfTU1JTyhkZXZf cHJpCj4gdi0+cHNyX21taW9fYmFzZSArIDB4MTApCj4gICNkZWZpbmUgICBFRFBfUFNSX0FVWF9D VExfVElNRV9PVVRfTUFTSwkJKDMgPDwgMjYpCj4gICNkZWZpbmUgICBFRFBfUFNSX0FVWF9DVExf TUVTU0FHRV9TSVpFX01BU0sJKDB4MWYgPDwgMjApCj4gQEAgLTY4MjAsNiArNjgyNyw3IEBAIGVu dW0gewo+ICAjZGVmaW5lIERFX1BDSF9FVkVOVF9JVkIJCSgxPDwyOCkKPiAgI2RlZmluZSBERV9E UF9BX0hPVFBMVUdfSVZCCQkoMTw8MjcpCj4gICNkZWZpbmUgREVfQVVYX0NIQU5ORUxfQV9JVkIJ CSgxPDwyNikKPiArI2RlZmluZSBERV9FRFBfUFNSX0lOVF9IU1cJCSgxPDwxOSkKCkZvciB0aGlz IG9uZSB5b3UncmUgYWxsb3dlZCB0byBub3QgcHV0IHRoZSBzcGFjZXMgc2luY2UgdGhlIG90aGVy IGJpdHMKYXJlIGxpa2UgdGhpcy4gQnV0IHlvdSBhbHNvIGhhdmUgdGhlIG9wdGlvbiBvZiBkcml2 ZS1ieSBmaXhpbmcgdGhlIGJpdHMKb2YgdGhpcyByZWdpc3RlciBpZiB5b3Ugd2FudCBzaW5jZSB5 b3UncmUgdG91Y2hpbmcgaXQuCgoKPiAgI2RlZmluZSBERV9TUFJJVEVDX0ZMSVBfRE9ORV9JVkIJ KDE8PDE0KQo+ICAjZGVmaW5lIERFX1BMQU5FQ19GTElQX0RPTkVfSVZCCQkoMTw8MTMpCj4gICNk ZWZpbmUgREVfUElQRUNfVkJMQU5LX0lWQgkJKDE8PDEwKQpfX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRlbC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdm eEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFp bG1hbi9saXN0aW5mby9pbnRlbC1nZngK