From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Mehta, Sohil" Subject: Re: [PATCH v3 2/2] iommu/amd: Add basic debugfs infrastructure for AMD IOMMU Date: Tue, 17 Apr 2018 00:52:29 +0000 Message-ID: <1523926423.2747.19.camel@intel.com> References: <152302042701.47565.17954813724758433858.stgit@sosxen2.amd.com> <152302067362.47565.628887796165116844.stgit@sosxen2.amd.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <152302067362.47565.628887796165116844.stgit-tq90VzyE+wXkLsZ8J5Uweg@public.gmane.org> Content-Language: en-US Content-ID: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org Errors-To: iommu-bounces-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org To: "gary.hook-5C7GfCeVMHo@public.gmane.org" Cc: "iommu-cunTk1MwBs9QetFLy7KEm3xJsTq8ys+cHZ5vskTnxNA@public.gmane.org" , "linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" List-Id: iommu@lists.linux-foundation.org T24gRnJpLCAyMDE4LTA0LTA2IGF0IDA4OjE3IC0wNTAwLCBHYXJ5IFIgSG9vayB3cm90ZToNCj4g DQo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2lvbW11L01ha2VmaWxlIGIvZHJpdmVycy9pb21tdS9N YWtlZmlsZQ0KPiBpbmRleCA1ZWIxMTIxZDU0YjkuLjBjYTI1MGY2MjZkOSAxMDA2NDQNCj4gLS0t IGEvZHJpdmVycy9pb21tdS9NYWtlZmlsZQ0KPiArKysgYi9kcml2ZXJzL2lvbW11L01ha2VmaWxl DQo+IEBAIC0xMSw2ICsxMSw3IEBAIG9iai0kKENPTkZJR19JT01NVV9JT1ZBKSArPSBpb3ZhLm8N Cj4gwqBvYmotJChDT05GSUdfT0ZfSU9NTVUpwqArPSBvZl9pb21tdS5vDQo+IMKgb2JqLSQoQ09O RklHX01TTV9JT01NVSkgKz0gbXNtX2lvbW11Lm8NCj4gwqBvYmotJChDT05GSUdfQU1EX0lPTU1V KSArPSBhbWRfaW9tbXUubyBhbWRfaW9tbXVfaW5pdC5vDQo+ICtvYmotJChDT05GSUdfSU9NTVVf REVCVUcpICs9IGFtZF9pb21tdV9kZWJ1Z2ZzLm8NCg0KQ29tcGlsaW5nIGFtZF9pb21tdV9kZWJ1 Z2ZzLmMgc2VlbXMgdG8gZGVwZW5kIG9ubHkNCm9uwqBDT05GSUdfSU9NTVVfREVCVUcuIENhbiB3 ZSBwcmV2ZW50IHRoZSBjb2RlIHdpdGhpbg0KYW1kX2lvbW11X2RlYnVnZnMuYyBmcm9tIGdldHRp bmcgY29tcGlsZWQgd2hlbiBlaXRoZXIgQ09ORklHX0FNRF9JT01NVQ0Kb3IgQ09ORklHX0lPTU1V X0RFQlVHIGlzIGRpc2FibGVkPw0KDQo+IMKgb2JqLSQoQ09ORklHX0FNRF9JT01NVV9WMikgKz0g YW1kX2lvbW11X3YyLm8NCj4gwqBvYmotJChDT05GSUdfQVJNX1NNTVUpICs9IGFybS1zbW11Lm8N Cj4gwqBvYmotJChDT05GSUdfQVJNX1NNTVVfVjMpICs9IGFybS1zbW11LXYzLm8KX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KaW9tbXUgbWFpbGluZyBsaXN0 CmlvbW11QGxpc3RzLmxpbnV4LWZvdW5kYXRpb24ub3JnCmh0dHBzOi8vbGlzdHMubGludXhmb3Vu ZGF0aW9uLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2lvbW11 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753041AbeDQAwc (ORCPT ); Mon, 16 Apr 2018 20:52:32 -0400 Received: from mga02.intel.com ([134.134.136.20]:25175 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752981AbeDQAwa (ORCPT ); Mon, 16 Apr 2018 20:52:30 -0400 X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,461,1517904000"; d="scan'208";a="33878543" From: "Mehta, Sohil" To: "gary.hook@amd.com" CC: "linux-kernel@vger.kernel.org" , "iommu@lists.linux-foundation.org" Subject: Re: [PATCH v3 2/2] iommu/amd: Add basic debugfs infrastructure for AMD IOMMU Thread-Topic: [PATCH v3 2/2] iommu/amd: Add basic debugfs infrastructure for AMD IOMMU Thread-Index: AQHT1eZcbGSq7dmBrE2nNUs46v6qOg== Date: Tue, 17 Apr 2018 00:52:29 +0000 Message-ID: <1523926423.2747.19.camel@intel.com> References: <152302042701.47565.17954813724758433858.stgit@sosxen2.amd.com> <152302067362.47565.628887796165116844.stgit@sosxen2.amd.com> In-Reply-To: <152302067362.47565.628887796165116844.stgit@sosxen2.amd.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [172.25.110.4] Content-Type: text/plain; charset="utf-8" Content-ID: MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by mail.home.local id w3H0qaje028944 On Fri, 2018-04-06 at 08:17 -0500, Gary R Hook wrote: > > diff --git a/drivers/iommu/Makefile b/drivers/iommu/Makefile > index 5eb1121d54b9..0ca250f626d9 100644 > --- a/drivers/iommu/Makefile > +++ b/drivers/iommu/Makefile > @@ -11,6 +11,7 @@ obj-$(CONFIG_IOMMU_IOVA) += iova.o >  obj-$(CONFIG_OF_IOMMU) += of_iommu.o >  obj-$(CONFIG_MSM_IOMMU) += msm_iommu.o >  obj-$(CONFIG_AMD_IOMMU) += amd_iommu.o amd_iommu_init.o > +obj-$(CONFIG_IOMMU_DEBUG) += amd_iommu_debugfs.o Compiling amd_iommu_debugfs.c seems to depend only on CONFIG_IOMMU_DEBUG. Can we prevent the code within amd_iommu_debugfs.c from getting compiled when either CONFIG_AMD_IOMMU or CONFIG_IOMMU_DEBUG is disabled? >  obj-$(CONFIG_AMD_IOMMU_V2) += amd_iommu_v2.o >  obj-$(CONFIG_ARM_SMMU) += arm-smmu.o >  obj-$(CONFIG_ARM_SMMU_V3) += arm-smmu-v3.o