From: Igor Mammedov <imammedo@redhat.com>
To: qemu-devel@nongnu.org
Cc: peter.maydell@linaro.org, qemu-arm@nongnu.org, eric.auger@redhat.com
Subject: [Qemu-arm] [PATCH for-2.13 v2 1/5] arm: always start from first_cpu when registering loader cpu reset callback
Date: Wed, 18 Apr 2018 16:28:01 +0200 [thread overview]
Message-ID: <1524061685-83305-2-git-send-email-imammedo@redhat.com> (raw)
In-Reply-To: <1524061685-83305-1-git-send-email-imammedo@redhat.com>
if arm_load_kernel() were passed non first_cpu, QEMU would end up
with partially set do_cpu_reset() callback leaving some CPUs without it.
Make sure that do_cpu_reset() is registered for all CPUs by enumerating
CPUs from first_cpu.
Signed-off-by: Igor Mammedov <imammedo@redhat.com>
Reviewed-by: Peter Maydell <peter.maydell@linaro.org>
---
hw/arm/boot.c | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/hw/arm/boot.c b/hw/arm/boot.c
index 26184bc..9ae6ab2 100644
--- a/hw/arm/boot.c
+++ b/hw/arm/boot.c
@@ -1188,7 +1188,7 @@ void arm_load_kernel(ARMCPU *cpu, struct arm_boot_info *info)
* actually loading a kernel, the handler is also responsible for
* arranging that we start it correctly.
*/
- for (cs = CPU(cpu); cs; cs = CPU_NEXT(cs)) {
+ for (cs = first_cpu; cs; cs = CPU_NEXT(cs)) {
qemu_register_reset(do_cpu_reset, ARM_CPU(cs));
}
}
--
2.7.4
next prev parent reply other threads:[~2018-04-18 14:29 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-18 14:28 [Qemu-arm] [PATCH for-2.13 v2 0/5] arm: isolate and clean up dtb generation Igor Mammedov
2018-04-18 14:28 ` Igor Mammedov [this message]
2018-04-18 16:20 ` [Qemu-arm] [PATCH for-2.13 v2 1/5] arm: always start from first_cpu when registering loader cpu reset callback Philippe Mathieu-Daudé
2018-04-18 14:28 ` [Qemu-arm] [PATCH for-2.13 v2 2/5] ppc: e500: switch E500 based machines to full machine definition Igor Mammedov
2018-04-19 4:15 ` David Gibson
2018-04-19 8:30 ` Igor Mammedov
2018-04-19 9:47 ` David Gibson
2018-04-18 14:28 ` [Qemu-arm] [PATCH for-2.13 v2 3/5] pc: simplify MachineClass::get_hotplug_handler handling Igor Mammedov
2018-04-18 14:56 ` Eduardo Habkost
2018-04-18 16:19 ` Philippe Mathieu-Daudé
2018-04-19 8:02 ` [Qemu-arm] [Qemu-devel] " Igor Mammedov
2018-04-18 14:28 ` [Qemu-arm] [PATCH for-2.13 v2 4/5] platform-bus-device: use device plug callback instead of machine_done notifier Igor Mammedov
2018-04-18 16:29 ` Philippe Mathieu-Daudé
2018-04-19 8:18 ` [Qemu-arm] [PATCH for-2.13 v3 " Igor Mammedov
2018-04-18 14:28 ` [Qemu-arm] [PATCH for-2.13 v2 5/5] arm/boot: split load_dtb() from arm_load_kernel() Igor Mammedov
2018-04-27 13:47 ` [Qemu-arm] [Qemu-devel] " Andrew Jones
2018-04-27 17:51 ` Peter Maydell
2018-05-01 9:43 ` Igor Mammedov
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1524061685-83305-2-git-send-email-imammedo@redhat.com \
--to=imammedo@redhat.com \
--cc=eric.auger@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-arm@nongnu.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.