diff for duplicates of <1524142404.2012.20.camel@realtek.com> diff --git a/a/1.txt b/N1/1.txt index 2244e7d..87e3cd2 100644 --- a/a/1.txt +++ b/N1/1.txt @@ -1,56 +1,62 @@ -T24gVGh1LCAyMDE4LTA0LTE5IGF0IDEyOjUyICswMzAwLCBLYWxsZSBWYWxvIHdyb3RlOg0KPiA8 -cGtzaGloQHJlYWx0ZWsuY29tPiB3cml0ZXM6DQo+IA0KPiA+IEZyb206IFBpbmctS2UgU2hpaCA8 -cGtzaGloQHJlYWx0ZWsuY29tPg0KPiA+DQo+ID4gVGhlIG1vZHVsZSBwYXJhbWV0ZXIgYW50X3Nl -bCBpcyB1c2VkIHRvIGNvbnRyb2wgYW50ZW5uYSBudW1iZXIgYW5kIHBhdGguDQo+ID4gVGhlcmUg -aXMgYW4gZXhpc3RpbmcgZW51bSBBTlRfe1gyLFgxfSBkZWZpbmVkIHRoZSBhbnRlbm5hIG51bWJl -ciwgc28NCj4gPiBhZGQgYSBuZXcgZW51bSBBTlRfe01BSU4sQVVYfSB0byBtYWtlIGl0IHJlYWRh -YmxlLiBBZnRlciB0aGlzIHdvcmssDQo+ID4gaW5jb3JyZWN0IGdpdmVuIHZhbHVlcyBkZXBlbmQg -b24gYW50X3NlbCB3ZXJlIGV4cG9zZWQsIHNvIHJlZmlsbCB2YWx1ZXMNCj4gPiBhY2NvcmRpbmcg -Zm9sbG93aW5nIGRlZmluaXRpb246DQo+ID7CoMKgwqBhbnRfc2VswqDCoMKgYW50X251bcKgwqDC -oGFudF9wYXRowqDCoHByaW50X2xhYmVsDQo+ID7CoMKgwqDCoMKgwqAxwqDCoMKgwqDCoMKgQU5U -X1gxwqDCoMKgwqBBTlRfQVVYwqDCoMKgwqDCoMKgwqDCoCMyDQo+ID7CoMKgwqDCoMKgwqAywqDC -oMKgwqDCoMKgQU5UX1gywqDCoMKgwqBBTlRfTUFJTsKgwqDCoMKgwqDCoMKgIzENCj4gPiBUaGVu -LCB0aGUgd29ya2Fyb3VuZCBpbiBoYWxidGNvdXRzcmMuYyB3YXMgcmVtb3ZlZC4NCj4gPg0KPiA+ -IFRoZSBleHBlcmltZW50YWwgcmVzdWx0cyB3aXRoIHNpbmdsZSBhbnRlbm5hIGNvbm5lY3RlZCB0 -byBzcGVjaWZpYyBwYXRoDQo+ID4gYXJlIGluIGZvbGxvd2luZzoNCj4gPsKgwqDCoGFudF9zZWzC -oMKgQU5UX01BSU4oIzEpwqDCoEFOVF9BVVgoIzIpDQo+ID7CoMKgwqDCoMKgwqAwwqDCoMKgwqDC -oMKgwqDCoC04wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgLTYyDQo+ID7CoMKgwqDCoMKgwqAxwqDC -oMKgwqDCoMKgwqDCoC02MsKgwqDCoMKgwqDCoMKgwqDCoMKgwqAtMTANCj4gPsKgwqDCoMKgwqDC -oDLCoMKgwqDCoMKgwqDCoMKgLTbCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAtNjANCj4gPg0KPiA+ -IFNpZ25lZC1vZmYtYnk6IFBpbmctS2UgU2hpaCA8cGtzaGloQHJlYWx0ZWsuY29tPg0KPiA+IENj -OiBTdGFibGUgPHN0YWJsZUB2Z2VyLmtlcm5lbC5vcmc+ICMgNC43Kw0KPiA+IFJldmlld2VkLWJ5 -OiBMYXJyeSBGaW5nZXIgPExhcnJ5LkZpbmdlckBsd2Zpbmdlci5uZXQ+DQo+ID4gLS0tDQo+ID4g -SGkgS2FsbGUsDQo+ID4NCj4gPiBUaGlzIHBhdGNoIHdvdWxkIHNlbmQgdG8gNC4xNy4NCj4gDQo+ -IEZvciAtcmMgcmVsZWFzZXMgSSByZXF1aXJlIGEgcXVpdGUgY2xlYXIgYnVnIHJlcG9ydCBidXQg -SSBkbyBub3QNCj4gdW5kZXJzdGFuZCB3aGF0IHlvdSBhcmUgZml4aW5nIGhlcmUsIGV2ZW4gYWZ0 -ZXIgcmVhZGluZyB0aGUgY29tbWl0IGxvZw0KPiB0d2ljZS4gQ291bGQgeW91IHRyeSB0byBpbXBy -b3ZlIGl0PyBFc3BlY2lhbGx5IGZvY3VzIG9uIGRlc2NyaWJpbmcgdGhlDQo+IGJ1ZyBpbiBzaW1w -bGUgdGVybXMgYW5kIGhvdyB0aGlzIHBhdGNoIGNoYW5nZXMgdGhlIGZ1bmN0aW9uYWxpdHkgZnJv -bQ0KPiB1c2VyJ3MgcG9pbnQgb2Ygdmlldy4NCj4gDQpUaGUgcGF0Y2ggbWFpbmx5IGZpeCB0aGUg -d3JvbmcgdmFsdWUgb2bCoGFudF9udW0gYW5kwqBzaW5nbGVfYW50X3BhdGggd2hlbg0KYW50X3Nl -bCBpcyBzZXQuDQoNCsKgIMKgIMKgIMKgIGlmIChtb2RfcGFyYW1zLT5hbnRfc2VsKSB7IMKgIMKg -IMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKg -IMKgIMKgDQrCoMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgcnRscHJpdi0+YnRjb2V4aXN0LmJ0Y19p -bmZvLmFudF9udW0gPSDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoMKgDQot -wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoChtb2RfcGFyYW1z -LT5hbnRfc2VsID09IDEgPyBBTlRfWDIgOiBBTlRfWDEpOyDCoCDCoCDCoCDCoCDCoMKgDQorwqDC -oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoChtb2RfcGFyYW1zLT5h -bnRfc2VsID09IDEgPyBBTlRfWDEgOiBBTlRfWDIpOyDCoCDCoCDCoCDCoCDCoMKgDQrCoCDCoCDC -oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC -oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoMKg -DQrCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCBydGxwcml2LT5idGNvZXhpc3QuYnRjX2luZm8uc2lu -Z2xlX2FudF9wYXRoID0gwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqDCoA0KLcKgwqDCoMKgwqDC -oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAobW9kX3BhcmFtcy0+YW50X3NlbCA9 -PSAxID8gMCA6IDEpOyDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoMKgDQorwqDCoMKgwqDC -oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoChtb2RfcGFyYW1zLT5hbnRfc2Vs -ID09IDEgPyBBTlRfQVVYIDogQU5UX01BSU4pOyDCoCDCoCDCoCDCoA0KwqDCoCDCoCDCoCDCoH0g -wqAgwqANClNvLCBuZWVkIHdvcmthcm91bmQgdG8gZml4IHRoZSBwcm9ibGVtLg0KDQpGb3IgZW5k -IHVzZXIsIG1vc3QgcGVvcGxlIGRvbid0IG5lZWQgYW50X3NlbCwgYnV0IEhQIHVzZXIgbmVlZHMg -dG8gc2V0IHRvIDEuDQpJbiBjYXNlIGFudF9zZWw9MSwgdGhlIHJlc3VsdCBpcyBhbG1vc3QgdGhl -IHNhbWUsIGJ1dCBhbnRfc2VsPTIgdGhhdCBpcyByYXJlDQp1c2VkIGlzIGJyb2tlbi4gU28sIHRo -aXMgYnVnIG1heSBiZSBub3Qgc2VlbiBieSB1c2VyLg0KDQpBbm90aGVyIHRoaW5nIGlzIHdlIHdh -bnQgdG8gYXBwbHkgdGhpcyBwYXRjaCB0byBzdGFibGUgcmVsZWFzZSB0byBnaXZlIGNvcnJlY3QN -CnZhbHVlcyBhbmQgcmVtb3ZlIHRoZSB3b3JrYXJvdW5kLCBzbyBJIHRoaW5rIGl0IGNhbiBhcHBs -eSB0byAtcmMgdG9vLg0KDQpBbnl3YXksIEknbGwgYWRkIG1vcmUgZGVzY3JpcHRpb24gdG8gY29t -bWl0IGxvZywgYW5kIHlvdSBjYW4gZGVjaWRlIHRvDQphcHBseSB0aGlzIHBhdGNoIHRvIDQuMTcg -b3IgcXVldWUgdG8gNC4xOC4NCg0KVGhhbmtzDQpQSw0K +On Thu, 2018-04-19 at 12:52 +0300, Kalle Valo wrote: +> <pkshih@realtek.com> writes: +> +> > From: Ping-Ke Shih <pkshih@realtek.com> +> > +> > The module parameter ant_sel is used to control antenna number and path. +> > There is an existing enum ANT_{X2,X1} defined the antenna number, so +> > add a new enum ANT_{MAIN,AUX} to make it readable. After this work, +> > incorrect given values depend on ant_sel were exposed, so refill values +> > according following definition: +> > ant_sel ant_num ant_path print_label +> > 1 ANT_X1 ANT_AUX #2 +> > 2 ANT_X2 ANT_MAIN #1 +> > Then, the workaround in halbtcoutsrc.c was removed. +> > +> > The experimental results with single antenna connected to specific path +> > are in following: +> > ant_sel ANT_MAIN(#1) ANT_AUX(#2) +> > 0 -8 -62 +> > 1 -62 -10 +> > 2 -6 -60 +> > +> > Signed-off-by: Ping-Ke Shih <pkshih@realtek.com> +> > Cc: Stable <stable@vger.kernel.org> # 4.7+ +> > Reviewed-by: Larry Finger <Larry.Finger@lwfinger.net> +> > --- +> > Hi Kalle, +> > +> > This patch would send to 4.17. +> +> For -rc releases I require a quite clear bug report but I do not +> understand what you are fixing here, even after reading the commit log +> twice. Could you try to improve it? Especially focus on describing the +> bug in simple terms and how this patch changes the functionality from +> user's point of view. +> +The patch mainly fix the wrong value of ant_num and single_ant_path when +ant_sel is set. + + if (mod_params->ant_sel) { + rtlpriv->btcoexist.btc_info.ant_num = +- (mod_params->ant_sel == 1 ? ANT_X2 : ANT_X1); ++ (mod_params->ant_sel == 1 ? ANT_X1 : ANT_X2); + + rtlpriv->btcoexist.btc_info.single_ant_path = +- (mod_params->ant_sel == 1 ? 0 : 1); ++ (mod_params->ant_sel == 1 ? ANT_AUX : ANT_MAIN); + } +So, need workaround to fix the problem. + +For end user, most people don't need ant_sel, but HP user needs to set to 1. +In case ant_sel=1, the result is almost the same, but ant_sel=2 that is rare +used is broken. So, this bug may be not seen by user. + +Another thing is we want to apply this patch to stable release to give correct +values and remove the workaround, so I think it can apply to -rc too. + +Anyway, I'll add more description to commit log, and you can decide to +apply this patch to 4.17 or queue to 4.18. + +Thanks +PK diff --git a/a/content_digest b/N1/content_digest index 621ff7c..0331183 100644 --- a/a/content_digest +++ b/N1/content_digest @@ -9,61 +9,67 @@ " stable@vger.kernel.org <stable@vger.kernel.org>\0" "\00:1\0" "b\0" - "T24gVGh1LCAyMDE4LTA0LTE5IGF0IDEyOjUyICswMzAwLCBLYWxsZSBWYWxvIHdyb3RlOg0KPiA8\n" - "cGtzaGloQHJlYWx0ZWsuY29tPiB3cml0ZXM6DQo+IA0KPiA+IEZyb206IFBpbmctS2UgU2hpaCA8\n" - "cGtzaGloQHJlYWx0ZWsuY29tPg0KPiA+DQo+ID4gVGhlIG1vZHVsZSBwYXJhbWV0ZXIgYW50X3Nl\n" - "bCBpcyB1c2VkIHRvIGNvbnRyb2wgYW50ZW5uYSBudW1iZXIgYW5kIHBhdGguDQo+ID4gVGhlcmUg\n" - "aXMgYW4gZXhpc3RpbmcgZW51bSBBTlRfe1gyLFgxfSBkZWZpbmVkIHRoZSBhbnRlbm5hIG51bWJl\n" - "ciwgc28NCj4gPiBhZGQgYSBuZXcgZW51bSBBTlRfe01BSU4sQVVYfSB0byBtYWtlIGl0IHJlYWRh\n" - "YmxlLiBBZnRlciB0aGlzIHdvcmssDQo+ID4gaW5jb3JyZWN0IGdpdmVuIHZhbHVlcyBkZXBlbmQg\n" - "b24gYW50X3NlbCB3ZXJlIGV4cG9zZWQsIHNvIHJlZmlsbCB2YWx1ZXMNCj4gPiBhY2NvcmRpbmcg\n" - "Zm9sbG93aW5nIGRlZmluaXRpb246DQo+ID7CoMKgwqBhbnRfc2VswqDCoMKgYW50X251bcKgwqDC\n" - "oGFudF9wYXRowqDCoHByaW50X2xhYmVsDQo+ID7CoMKgwqDCoMKgwqAxwqDCoMKgwqDCoMKgQU5U\n" - "X1gxwqDCoMKgwqBBTlRfQVVYwqDCoMKgwqDCoMKgwqDCoCMyDQo+ID7CoMKgwqDCoMKgwqAywqDC\n" - "oMKgwqDCoMKgQU5UX1gywqDCoMKgwqBBTlRfTUFJTsKgwqDCoMKgwqDCoMKgIzENCj4gPiBUaGVu\n" - "LCB0aGUgd29ya2Fyb3VuZCBpbiBoYWxidGNvdXRzcmMuYyB3YXMgcmVtb3ZlZC4NCj4gPg0KPiA+\n" - "IFRoZSBleHBlcmltZW50YWwgcmVzdWx0cyB3aXRoIHNpbmdsZSBhbnRlbm5hIGNvbm5lY3RlZCB0\n" - "byBzcGVjaWZpYyBwYXRoDQo+ID4gYXJlIGluIGZvbGxvd2luZzoNCj4gPsKgwqDCoGFudF9zZWzC\n" - "oMKgQU5UX01BSU4oIzEpwqDCoEFOVF9BVVgoIzIpDQo+ID7CoMKgwqDCoMKgwqAwwqDCoMKgwqDC\n" - "oMKgwqDCoC04wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgLTYyDQo+ID7CoMKgwqDCoMKgwqAxwqDC\n" - "oMKgwqDCoMKgwqDCoC02MsKgwqDCoMKgwqDCoMKgwqDCoMKgwqAtMTANCj4gPsKgwqDCoMKgwqDC\n" - "oDLCoMKgwqDCoMKgwqDCoMKgLTbCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAtNjANCj4gPg0KPiA+\n" - "IFNpZ25lZC1vZmYtYnk6IFBpbmctS2UgU2hpaCA8cGtzaGloQHJlYWx0ZWsuY29tPg0KPiA+IENj\n" - "OiBTdGFibGUgPHN0YWJsZUB2Z2VyLmtlcm5lbC5vcmc+ICMgNC43Kw0KPiA+IFJldmlld2VkLWJ5\n" - "OiBMYXJyeSBGaW5nZXIgPExhcnJ5LkZpbmdlckBsd2Zpbmdlci5uZXQ+DQo+ID4gLS0tDQo+ID4g\n" - "SGkgS2FsbGUsDQo+ID4NCj4gPiBUaGlzIHBhdGNoIHdvdWxkIHNlbmQgdG8gNC4xNy4NCj4gDQo+\n" - "IEZvciAtcmMgcmVsZWFzZXMgSSByZXF1aXJlIGEgcXVpdGUgY2xlYXIgYnVnIHJlcG9ydCBidXQg\n" - "SSBkbyBub3QNCj4gdW5kZXJzdGFuZCB3aGF0IHlvdSBhcmUgZml4aW5nIGhlcmUsIGV2ZW4gYWZ0\n" - "ZXIgcmVhZGluZyB0aGUgY29tbWl0IGxvZw0KPiB0d2ljZS4gQ291bGQgeW91IHRyeSB0byBpbXBy\n" - "b3ZlIGl0PyBFc3BlY2lhbGx5IGZvY3VzIG9uIGRlc2NyaWJpbmcgdGhlDQo+IGJ1ZyBpbiBzaW1w\n" - "bGUgdGVybXMgYW5kIGhvdyB0aGlzIHBhdGNoIGNoYW5nZXMgdGhlIGZ1bmN0aW9uYWxpdHkgZnJv\n" - "bQ0KPiB1c2VyJ3MgcG9pbnQgb2Ygdmlldy4NCj4gDQpUaGUgcGF0Y2ggbWFpbmx5IGZpeCB0aGUg\n" - "d3JvbmcgdmFsdWUgb2bCoGFudF9udW0gYW5kwqBzaW5nbGVfYW50X3BhdGggd2hlbg0KYW50X3Nl\n" - "bCBpcyBzZXQuDQoNCsKgIMKgIMKgIMKgIGlmIChtb2RfcGFyYW1zLT5hbnRfc2VsKSB7IMKgIMKg\n" - "IMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKg\n" - "IMKgIMKgDQrCoMKgIMKgIMKgIMKgIMKgIMKgIMKgIMKgcnRscHJpdi0+YnRjb2V4aXN0LmJ0Y19p\n" - "bmZvLmFudF9udW0gPSDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoMKgDQot\n" - "wqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoChtb2RfcGFyYW1z\n" - "LT5hbnRfc2VsID09IDEgPyBBTlRfWDIgOiBBTlRfWDEpOyDCoCDCoCDCoCDCoCDCoMKgDQorwqDC\n" - "oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoChtb2RfcGFyYW1zLT5h\n" - "bnRfc2VsID09IDEgPyBBTlRfWDEgOiBBTlRfWDIpOyDCoCDCoCDCoCDCoCDCoMKgDQrCoCDCoCDC\n" - "oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDC\n" - "oCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoMKg\n" - "DQrCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCBydGxwcml2LT5idGNvZXhpc3QuYnRjX2luZm8uc2lu\n" - "Z2xlX2FudF9wYXRoID0gwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqAgwqDCoA0KLcKgwqDCoMKgwqDC\n" - "oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqAobW9kX3BhcmFtcy0+YW50X3NlbCA9\n" - "PSAxID8gMCA6IDEpOyDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoCDCoMKgDQorwqDCoMKgwqDC\n" - "oMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoChtb2RfcGFyYW1zLT5hbnRfc2Vs\n" - "ID09IDEgPyBBTlRfQVVYIDogQU5UX01BSU4pOyDCoCDCoCDCoCDCoA0KwqDCoCDCoCDCoCDCoH0g\n" - "wqAgwqANClNvLCBuZWVkIHdvcmthcm91bmQgdG8gZml4IHRoZSBwcm9ibGVtLg0KDQpGb3IgZW5k\n" - "IHVzZXIsIG1vc3QgcGVvcGxlIGRvbid0IG5lZWQgYW50X3NlbCwgYnV0IEhQIHVzZXIgbmVlZHMg\n" - "dG8gc2V0IHRvIDEuDQpJbiBjYXNlIGFudF9zZWw9MSwgdGhlIHJlc3VsdCBpcyBhbG1vc3QgdGhl\n" - "IHNhbWUsIGJ1dCBhbnRfc2VsPTIgdGhhdCBpcyByYXJlDQp1c2VkIGlzIGJyb2tlbi4gU28sIHRo\n" - "aXMgYnVnIG1heSBiZSBub3Qgc2VlbiBieSB1c2VyLg0KDQpBbm90aGVyIHRoaW5nIGlzIHdlIHdh\n" - "bnQgdG8gYXBwbHkgdGhpcyBwYXRjaCB0byBzdGFibGUgcmVsZWFzZSB0byBnaXZlIGNvcnJlY3QN\n" - "CnZhbHVlcyBhbmQgcmVtb3ZlIHRoZSB3b3JrYXJvdW5kLCBzbyBJIHRoaW5rIGl0IGNhbiBhcHBs\n" - "eSB0byAtcmMgdG9vLg0KDQpBbnl3YXksIEknbGwgYWRkIG1vcmUgZGVzY3JpcHRpb24gdG8gY29t\n" - "bWl0IGxvZywgYW5kIHlvdSBjYW4gZGVjaWRlIHRvDQphcHBseSB0aGlzIHBhdGNoIHRvIDQuMTcg\n" - b3IgcXVldWUgdG8gNC4xOC4NCg0KVGhhbmtzDQpQSw0K + "On Thu, 2018-04-19 at 12:52 +0300, Kalle Valo wrote:\n" + "> <pkshih@realtek.com> writes:\n" + "> \n" + "> > From: Ping-Ke Shih <pkshih@realtek.com>\n" + "> >\n" + "> > The module parameter ant_sel is used to control antenna number and path.\n" + "> > There is an existing enum ANT_{X2,X1} defined the antenna number, so\n" + "> > add a new enum ANT_{MAIN,AUX} to make it readable. After this work,\n" + "> > incorrect given values depend on ant_sel were exposed, so refill values\n" + "> > according following definition:\n" + "> >\302\240\302\240\302\240ant_sel\302\240\302\240\302\240ant_num\302\240\302\240\302\240ant_path\302\240\302\240print_label\n" + "> >\302\240\302\240\302\240\302\240\302\240\302\2401\302\240\302\240\302\240\302\240\302\240\302\240ANT_X1\302\240\302\240\302\240\302\240ANT_AUX\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240#2\n" + "> >\302\240\302\240\302\240\302\240\302\240\302\2402\302\240\302\240\302\240\302\240\302\240\302\240ANT_X2\302\240\302\240\302\240\302\240ANT_MAIN\302\240\302\240\302\240\302\240\302\240\302\240\302\240#1\n" + "> > Then, the workaround in halbtcoutsrc.c was removed.\n" + "> >\n" + "> > The experimental results with single antenna connected to specific path\n" + "> > are in following:\n" + "> >\302\240\302\240\302\240ant_sel\302\240\302\240ANT_MAIN(#1)\302\240\302\240ANT_AUX(#2)\n" + "> >\302\240\302\240\302\240\302\240\302\240\302\2400\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240-8\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240-62\n" + "> >\302\240\302\240\302\240\302\240\302\240\302\2401\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240-62\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240-10\n" + "> >\302\240\302\240\302\240\302\240\302\240\302\2402\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240-6\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240-60\n" + "> >\n" + "> > Signed-off-by: Ping-Ke Shih <pkshih@realtek.com>\n" + "> > Cc: Stable <stable@vger.kernel.org> # 4.7+\n" + "> > Reviewed-by: Larry Finger <Larry.Finger@lwfinger.net>\n" + "> > ---\n" + "> > Hi Kalle,\n" + "> >\n" + "> > This patch would send to 4.17.\n" + "> \n" + "> For -rc releases I require a quite clear bug report but I do not\n" + "> understand what you are fixing here, even after reading the commit log\n" + "> twice. Could you try to improve it? Especially focus on describing the\n" + "> bug in simple terms and how this patch changes the functionality from\n" + "> user's point of view.\n" + "> \n" + "The patch mainly fix the wrong value of\302\240ant_num and\302\240single_ant_path when\n" + "ant_sel is set.\n" + "\n" + "\302\240 \302\240 \302\240 \302\240 if (mod_params->ant_sel) { \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240\n" + "\302\240\302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240rtlpriv->btcoexist.btc_info.ant_num = \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240\302\240\n" + "-\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240(mod_params->ant_sel == 1 ? ANT_X2 : ANT_X1); \302\240 \302\240 \302\240 \302\240 \302\240\302\240\n" + "+\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240(mod_params->ant_sel == 1 ? ANT_X1 : ANT_X2); \302\240 \302\240 \302\240 \302\240 \302\240\302\240\n" + "\302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240\302\240\n" + "\302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 rtlpriv->btcoexist.btc_info.single_ant_path = \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240\302\240\n" + "-\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240(mod_params->ant_sel == 1 ? 0 : 1); \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240 \302\240\302\240\n" + "+\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240\302\240(mod_params->ant_sel == 1 ? ANT_AUX : ANT_MAIN); \302\240 \302\240 \302\240 \302\240\n" + "\302\240\302\240 \302\240 \302\240 \302\240} \302\240 \302\240\n" + "So, need workaround to fix the problem.\n" + "\n" + "For end user, most people don't need ant_sel, but HP user needs to set to 1.\n" + "In case ant_sel=1, the result is almost the same, but ant_sel=2 that is rare\n" + "used is broken. So, this bug may be not seen by user.\n" + "\n" + "Another thing is we want to apply this patch to stable release to give correct\n" + "values and remove the workaround, so I think it can apply to -rc too.\n" + "\n" + "Anyway, I'll add more description to commit log, and you can decide to\n" + "apply this patch to 4.17 or queue to 4.18.\n" + "\n" + "Thanks\n" + PK -6ef254ca8ba047d34bafba02b74ef764656a0a90b5887b5dbde717441acb8129 +b76c721495facbc7bb61387bfa38bd992f8bb17a87d668ed78895b6ad35964d7
This is an external index of several public inboxes, see mirroring instructions on how to clone and mirror all data and code used by this external index.