From: Luca Boccassi <bluca@debian.org>
To: Maxime Coquelin <maxime.coquelin@redhat.com>,
Lee Roberts <lee.roberts@hpe.com>,
ferruh.yigit@intel.com, Thomas Monjalon <thomas@monjalon.net>,
Yuanhan Liu <yliu@fridaylinux.org>
Cc: dev@dpdk.org
Subject: Re: [PATCH] kni: fix compilation under RHEL 7.5
Date: Thu, 19 Apr 2018 22:49:21 +0100 [thread overview]
Message-ID: <1524174561.14582.2.camel@debian.org> (raw)
In-Reply-To: <1b24f058-2a55-73a9-14ab-5002637a7c92@redhat.com>
On Thu, 2018-04-19 at 15:09 +0200, Maxime Coquelin wrote:
> Hi Luca, Yuanhan,
>
> On 03/02/2018 12:20 AM, Lee Roberts wrote:
> > Fix kni compilation under RHEL 7.5.
> >
> > Signed-off-by: Lee Roberts <lee.roberts@hpe.com>
> > ---
> > lib/librte_eal/linuxapp/kni/compat.h | 5 +++++
> > 1 file changed, 5 insertions(+)
> >
> > diff --git a/lib/librte_eal/linuxapp/kni/compat.h
> > b/lib/librte_eal/linuxapp/kni/compat.h
> > index 3f8c0bc..6a6968d 100644
> > --- a/lib/librte_eal/linuxapp/kni/compat.h
> > +++ b/lib/librte_eal/linuxapp/kni/compat.h
> > @@ -101,6 +101,11 @@
> > #undef NET_NAME_UNKNOWN
> > #endif
> >
> > +#if (defined(RHEL_RELEASE_CODE) && \
> > + (RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7, 5)))
> > +#define ndo_change_mtu ndo_change_mtu_rh74
> > +#endif
> > +
> > #if LINUX_VERSION_CODE >= KERNEL_VERSION(4, 11, 0)
> > #define HAVE_SIGNAL_FUNCTIONS_OWN_HEADER
> > #endif
> >
>
> Any chance we pick these patches in stable branches so that
> we can build them with RHEL 7.5 without disabling KNI?
>
> I think it should apply cleanly on all of them, but I can send the
> backport patches for each of them if necessary.
>
> Thanks,
> Maxime
Sure, I can have a look early next week for 16.11.
--
Kind regards,
Luca Boccassi
prev parent reply other threads:[~2018-04-19 21:49 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-03-01 23:20 [PATCH] kni: fix compilation under RHEL 7.5 Lee Roberts
2018-03-02 0:18 ` Stephen Hemminger
2018-03-02 3:18 ` Roberts, Lee A.
2018-03-22 18:07 ` Ferruh Yigit
2018-03-27 22:15 ` Thomas Monjalon
2018-04-19 13:09 ` Maxime Coquelin
2018-04-19 21:49 ` Luca Boccassi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1524174561.14582.2.camel@debian.org \
--to=bluca@debian.org \
--cc=dev@dpdk.org \
--cc=ferruh.yigit@intel.com \
--cc=lee.roberts@hpe.com \
--cc=maxime.coquelin@redhat.com \
--cc=thomas@monjalon.net \
--cc=yliu@fridaylinux.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.