From: Andy Shevchenko <andriy.shevchenko@linux.intel.com>
To: John Garry <john.garry@huawei.com>,
rjw@rjwysocki.net, linux-acpi@vger.kernel.org, lenb@kernel.org,
mika.westerberg@linux.intel.com, lorenzo.pieralisi@arm.com
Cc: linux-kernel@vger.kernel.org, arnd@arndb.de,
graeme.gregory@linaro.org, helgaas@kernel.org,
linuxarm@huawei.com, z.liuxinliang@hisilicon.com
Subject: Re: [RFC PATCH 2/2] HISI LPC: Add PNP device support
Date: Fri, 20 Apr 2018 16:28:30 +0300 [thread overview]
Message-ID: <1524230910.21176.474.camel@linux.intel.com> (raw)
In-Reply-To: <e838b3ef-5cf8-ac12-6b44-a1f8001f8b94@huawei.com>
On Fri, 2018-04-20 at 14:09 +0100, John Garry wrote:
> On 20/04/2018 13:50, Andy Shevchenko wrote:
> > On Fri, 2018-04-20 at 18:07 +0800, John Garry wrote:
> > > + if (res->flags | IORESOURCE_IO)
> >
> > What does this mean?
>
> Here we check the resource flag for each resource for this PNP device
> -
> for IO resources we must translate the resource value from the bus
> address to the logical PIO address.
Please, re-read your code again.
--
Andy Shevchenko <andriy.shevchenko@linux.intel.com>
Intel Finland Oy
next prev parent reply other threads:[~2018-04-20 13:28 UTC|newest]
Thread overview: 38+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-04-20 10:07 [RFC PATCH 0/2] HISI LPC: Add PNP device support John Garry
2018-04-20 10:07 ` John Garry
2018-04-20 10:07 ` [RFC PATCH 1/2] ACPI / PNP: Don't add "enumeration_by_parent" devices John Garry
2018-04-20 10:07 ` John Garry
2018-04-20 13:07 ` Mika Westerberg
2018-04-20 13:24 ` John Garry
2018-04-20 13:24 ` John Garry
2018-04-20 13:52 ` Mika Westerberg
2018-04-20 14:09 ` John Garry
2018-04-20 14:09 ` John Garry
2018-04-26 13:49 ` John Garry
2018-04-26 13:49 ` John Garry
2018-04-26 14:08 ` Mika Westerberg
2018-04-26 14:23 ` John Garry
2018-04-26 14:23 ` John Garry
2018-04-26 14:40 ` Mika Westerberg
2018-04-27 9:17 ` John Garry
2018-04-27 9:17 ` John Garry
2018-04-30 5:36 ` Lee Jones
2018-04-30 9:00 ` John Garry
2018-04-30 9:00 ` John Garry
2018-04-30 9:26 ` Lee Jones
2018-04-30 9:35 ` John Garry
2018-04-30 9:35 ` John Garry
2018-04-30 10:46 ` Lee Jones
2018-04-30 10:57 ` John Garry
2018-04-30 10:57 ` John Garry
2018-04-20 10:07 ` [RFC PATCH 2/2] HISI LPC: Add PNP device support John Garry
2018-04-20 10:07 ` John Garry
2018-04-20 12:50 ` Andy Shevchenko
2018-04-20 13:09 ` John Garry
2018-04-20 13:09 ` John Garry
2018-04-20 13:28 ` Andy Shevchenko [this message]
2018-04-20 13:32 ` John Garry
2018-04-20 13:32 ` John Garry
2018-04-20 13:12 ` Mika Westerberg
2018-04-20 13:36 ` John Garry
2018-04-20 13:36 ` John Garry
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1524230910.21176.474.camel@linux.intel.com \
--to=andriy.shevchenko@linux.intel.com \
--cc=arnd@arndb.de \
--cc=graeme.gregory@linaro.org \
--cc=helgaas@kernel.org \
--cc=john.garry@huawei.com \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linuxarm@huawei.com \
--cc=lorenzo.pieralisi@arm.com \
--cc=mika.westerberg@linux.intel.com \
--cc=rjw@rjwysocki.net \
--cc=z.liuxinliang@hisilicon.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.