From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mathieu Desnoyers Subject: Re: [PATCH 3/6] sched,perf,kvm: Fix preemption condition Date: Wed, 2 Jun 2021 10:15:16 -0400 (EDT) Message-ID: <1524365960.5868.1622643316351.JavaMail.zimbra@efficios.com> References: <20210602131225.336600299@infradead.org> <20210602133040.398289363@infradead.org> Mime-Version: 1.0 Content-Transfer-Encoding: 7bit Return-path: DKIM-Filter: OpenDKIM Filter v2.10.3 mail.efficios.com 9F3AF302B63 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=default; t=1622643316; bh=wTS/crR/26N4BDTiNFNNZoqsETfUenagK9Jc/umukAM=; h=Date:From:To:Message-ID:MIME-Version; b=HjuuxeCx/W0ucWdgkdPe4Ltmueov6LEz9QoWVQ9n275sUH5V2BfBx2uLemee8nOgV iEPOUdYsPm3Mmmkxyd2M/xe2NzuiK0lte25kNJqF/D6aBdMudEsd6+/AvYnVI3XvQB I3eKlxdMnA/4sIrtiEyziYHBHFsURA8x1tU1usHbZhQ+Nqw4zpB4HKNzuSQ6QLswXS 8VevSWMXfGVlYdJrwg5WBPwEe4w0fAdx0pE768+FRtKKL3etA75RfRjkypdxFoVZY5 KUm3EJy+oFxv1WaIjL0MV00CLSuspl8VcSBxV1CpXr+Or5zRpRWJvt+/OT6gN/Sqjt hvtczOpS4cKPQ== In-Reply-To: <20210602133040.398289363-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org> List-ID: Content-Type: text/plain; charset="us-ascii" To: Peter Zijlstra Cc: Thomas Gleixner , Ingo Molnar , Juri Lelli , Vincent Guittot , Dietmar Eggemann , rostedt , Ben Segall , Mel Gorman , bristot , Borislav Petkov , x86 , "H. Peter Anvin" , Jens Axboe , Alasdair Kergon , Mike Snitzer , dm-devel-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org, "David S. Miller" , Jakub Kicinski , Felipe Balbi , Greg Kroah-Hartman , Alexander Viro , Tejun Heo , Zefan Li ----- On Jun 2, 2021, at 9:12 AM, Peter Zijlstra peterz-wEGCiKHe2LqWVfeAwA7xHQ@public.gmane.org wrote: [...] > --- a/kernel/events/core.c > +++ b/kernel/events/core.c > @@ -8568,13 +8568,12 @@ static void perf_event_switch(struct tas > }, > }; > > - if (!sched_in && task->state == TASK_RUNNING) > + if (!sched_in && current->on_rq) { > switch_event.event_id.header.misc |= > PERF_RECORD_MISC_SWITCH_OUT_PREEMPT; > + } > > - perf_iterate_sb(perf_event_switch_output, > - &switch_event, > - NULL); > + perf_iterate_sb(perf_event_switch_output, &switch_event, NULL); > } There is a lot of code cleanup going on here which does not seem to belong to a "Fix" patch. Thanks, Mathieu -- Mathieu Desnoyers EfficiOS Inc. http://www.efficios.com From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id D645CC47097 for ; Thu, 3 Jun 2021 06:34:33 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 518D96140A for ; Thu, 3 Jun 2021 06:33:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 518D96140A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=efficios.com Authentication-Results: mail.kernel.org; spf=tempfail smtp.mailfrom=dm-devel-bounces@redhat.com Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-511-Gb5C5snwO5WfkwtZm8VEVQ-1; Thu, 03 Jun 2021 02:33:27 -0400 X-MC-Unique: Gb5C5snwO5WfkwtZm8VEVQ-1 Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 872C78042B4; Thu, 3 Jun 2021 06:33:16 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 67EE21383F; Thu, 3 Jun 2021 06:33:16 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id E95181800FFC; Thu, 3 Jun 2021 06:33:15 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.rdu2.redhat.com [10.11.54.4]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 152EFP2n032004 for ; Wed, 2 Jun 2021 10:15:25 -0400 Received: by smtp.corp.redhat.com (Postfix) id 89113208AB9E; Wed, 2 Jun 2021 14:15:25 +0000 (UTC) Received: from mimecast-mx02.redhat.com (mimecast02.extmail.prod.ext.rdu2.redhat.com [10.11.55.18]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 8354D208BDCB for ; Wed, 2 Jun 2021 14:15:22 +0000 (UTC) Received: from us-smtp-1.mimecast.com (us-smtp-1.mimecast.com [207.211.31.81]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mimecast-mx02.redhat.com (Postfix) with ESMTPS id 50C90803D50 for ; Wed, 2 Jun 2021 14:15:22 +0000 (UTC) Received: from mail.efficios.com (mail.efficios.com [167.114.26.124]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-33-of_tRiXQOLmvqZahlgayUA-1; Wed, 02 Jun 2021 10:15:18 -0400 X-MC-Unique: of_tRiXQOLmvqZahlgayUA-1 Received: from localhost (localhost [127.0.0.1]) by mail.efficios.com (Postfix) with ESMTP id 678EE302DAA; Wed, 2 Jun 2021 10:15:17 -0400 (EDT) Received: from mail.efficios.com ([127.0.0.1]) by localhost (mail03.efficios.com [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 8RvjTnc1vjOW; Wed, 2 Jun 2021 10:15:17 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mail.efficios.com (Postfix) with ESMTP id 9F3AF302B63; Wed, 2 Jun 2021 10:15:16 -0400 (EDT) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.efficios.com 9F3AF302B63 X-Virus-Scanned: amavisd-new at efficios.com Received: from mail.efficios.com ([127.0.0.1]) by localhost (mail03.efficios.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id INsgB7HWhvRx; Wed, 2 Jun 2021 10:15:16 -0400 (EDT) Received: from mail03.efficios.com (mail03.efficios.com [167.114.26.124]) by mail.efficios.com (Postfix) with ESMTP id 702A6302A65; Wed, 2 Jun 2021 10:15:16 -0400 (EDT) Date: Wed, 2 Jun 2021 10:15:16 -0400 (EDT) From: Mathieu Desnoyers To: Peter Zijlstra Message-ID: <1524365960.5868.1622643316351.JavaMail.zimbra@efficios.com> In-Reply-To: <20210602133040.398289363@infradead.org> References: <20210602131225.336600299@infradead.org> <20210602133040.398289363@infradead.org> MIME-Version: 1.0 X-Originating-IP: [167.114.26.124] Thread-Topic: sched,perf,kvm: Fix preemption condition Thread-Index: NELkknquBPwUAC7hR8bH+DhrqDwz1A== X-Mimecast-Impersonation-Protect: Policy=CLT - Impersonation Protection Definition; Similar Internal Domain=false; Similar Monitored External Domain=false; Custom External Domain=false; Mimecast External Domain=false; Newly Observed Domain=false; Internal User Name=false; Custom Display Name List=false; Reply-to Address Mismatch=false; Targeted Threat Dictionary=false; Mimecast Threat Dictionary=false; Custom Threat Dictionary=false X-Scanned-By: MIMEDefang 2.78 on 10.11.54.4 X-loop: dm-devel@redhat.com X-Mailman-Approved-At: Thu, 03 Jun 2021 02:32:49 -0400 Cc: Juri Lelli , Mark Rutland , Pavel Machek , Mike Snitzer , Alexander Shishkin , kgdb-bugreport@lists.sourceforge.net, Lai Jiangshan , Oleg Nesterov , Ben Segall , linux-mm , dm-devel@redhat.com, Paolo Bonzini , Zefan Li , "H. Peter Anvin" , "Joel Fernandes, Google" , netdev , Jiri Olsa , Alasdair Kergon , Daniel Thompson , Davidlohr Bueso , Vincent Guittot , KVM list , Will Deacon , cgroups , x86 , Ingo Molnar , Mel Gorman , Jakub Kicinski , paulmck , linux-pm@vger.kernel.org, Boqun Feng , Jason Wessel , Josh Triplett , rostedt , linux-block@vger.kernel.org, linux-fsdevel , Borislav Petkov , Alexander Viro , Waiman Long , Namhyung Kim , Thomas Gleixner , acme , Dietmar Eggemann , Jens Axboe , Felipe Balbi , Stephen Boyd , Greg Kroah-Hartman , linux-usb@vger.kernel.org, "Rafael J. Wysocki" , Douglas Anderson , linux-kernel , linux-perf-users@vger.kernel.org, Johannes Weiner , Tejun Heo , John Stultz , Andrew Morton , rcu , bristot , "David S. Miller" Subject: Re: [dm-devel] [PATCH 3/6] sched, perf, kvm: Fix preemption condition X-BeenThere: dm-devel@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: device-mapper development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dm-devel-bounces@redhat.com Errors-To: dm-devel-bounces@redhat.com X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=dm-devel-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit ----- On Jun 2, 2021, at 9:12 AM, Peter Zijlstra peterz@infradead.org wrote: [...] > --- a/kernel/events/core.c > +++ b/kernel/events/core.c > @@ -8568,13 +8568,12 @@ static void perf_event_switch(struct tas > }, > }; > > - if (!sched_in && task->state == TASK_RUNNING) > + if (!sched_in && current->on_rq) { > switch_event.event_id.header.misc |= > PERF_RECORD_MISC_SWITCH_OUT_PREEMPT; > + } > > - perf_iterate_sb(perf_event_switch_output, > - &switch_event, > - NULL); > + perf_iterate_sb(perf_event_switch_output, &switch_event, NULL); > } There is a lot of code cleanup going on here which does not seem to belong to a "Fix" patch. Thanks, Mathieu -- Mathieu Desnoyers EfficiOS Inc. http://www.efficios.com -- dm-devel mailing list dm-devel@redhat.com https://listman.redhat.com/mailman/listinfo/dm-devel From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-10.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id A22E2C47083 for ; Wed, 2 Jun 2021 14:17:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 8A3A7613D8 for ; Wed, 2 Jun 2021 14:17:48 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231931AbhFBOTC (ORCPT ); Wed, 2 Jun 2021 10:19:02 -0400 Received: from mail.efficios.com ([167.114.26.124]:40642 "EHLO mail.efficios.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232154AbhFBORA (ORCPT ); Wed, 2 Jun 2021 10:17:00 -0400 Received: from localhost (localhost [127.0.0.1]) by mail.efficios.com (Postfix) with ESMTP id 678EE302DAA; Wed, 2 Jun 2021 10:15:17 -0400 (EDT) Received: from mail.efficios.com ([127.0.0.1]) by localhost (mail03.efficios.com [127.0.0.1]) (amavisd-new, port 10032) with ESMTP id 8RvjTnc1vjOW; Wed, 2 Jun 2021 10:15:17 -0400 (EDT) Received: from localhost (localhost [127.0.0.1]) by mail.efficios.com (Postfix) with ESMTP id 9F3AF302B63; Wed, 2 Jun 2021 10:15:16 -0400 (EDT) DKIM-Filter: OpenDKIM Filter v2.10.3 mail.efficios.com 9F3AF302B63 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=efficios.com; s=default; t=1622643316; bh=wTS/crR/26N4BDTiNFNNZoqsETfUenagK9Jc/umukAM=; h=Date:From:To:Message-ID:MIME-Version; b=HjuuxeCx/W0ucWdgkdPe4Ltmueov6LEz9QoWVQ9n275sUH5V2BfBx2uLemee8nOgV iEPOUdYsPm3Mmmkxyd2M/xe2NzuiK0lte25kNJqF/D6aBdMudEsd6+/AvYnVI3XvQB I3eKlxdMnA/4sIrtiEyziYHBHFsURA8x1tU1usHbZhQ+Nqw4zpB4HKNzuSQ6QLswXS 8VevSWMXfGVlYdJrwg5WBPwEe4w0fAdx0pE768+FRtKKL3etA75RfRjkypdxFoVZY5 KUm3EJy+oFxv1WaIjL0MV00CLSuspl8VcSBxV1CpXr+Or5zRpRWJvt+/OT6gN/Sqjt hvtczOpS4cKPQ== X-Virus-Scanned: amavisd-new at efficios.com Received: from mail.efficios.com ([127.0.0.1]) by localhost (mail03.efficios.com [127.0.0.1]) (amavisd-new, port 10026) with ESMTP id INsgB7HWhvRx; Wed, 2 Jun 2021 10:15:16 -0400 (EDT) Received: from mail03.efficios.com (mail03.efficios.com [167.114.26.124]) by mail.efficios.com (Postfix) with ESMTP id 702A6302A65; Wed, 2 Jun 2021 10:15:16 -0400 (EDT) Date: Wed, 2 Jun 2021 10:15:16 -0400 (EDT) From: Mathieu Desnoyers To: Peter Zijlstra Cc: Thomas Gleixner , Ingo Molnar , Juri Lelli , Vincent Guittot , Dietmar Eggemann , rostedt , Ben Segall , Mel Gorman , bristot , Borislav Petkov , x86 , "H. Peter Anvin" , Jens Axboe , Alasdair Kergon , Mike Snitzer , dm-devel@redhat.com, "David S. Miller" , Jakub Kicinski , Felipe Balbi , Greg Kroah-Hartman , Alexander Viro , Tejun Heo , Zefan Li , Johannes Weiner , Jason Wessel , Daniel Thompson , Douglas Anderson , acme , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , "Rafael J. Wysocki" , Pavel Machek , Will Deacon , Waiman Long , Boqun Feng , Oleg Nesterov , Davidlohr Bueso , paulmck , Josh Triplett , Lai Jiangshan , "Joel Fernandes, Google" , John Stultz , Stephen Boyd , Andrew Morton , Paolo Bonzini , linux-kernel , linux-block@vger.kernel.org, netdev , linux-usb@vger.kernel.org, linux-fsdevel , cgroups , kgdb-bugreport@lists.sourceforge.net, linux-perf-users@vger.kernel.org, linux-pm@vger.kernel.org, rcu , linux-mm , KVM list Message-ID: <1524365960.5868.1622643316351.JavaMail.zimbra@efficios.com> In-Reply-To: <20210602133040.398289363@infradead.org> References: <20210602131225.336600299@infradead.org> <20210602133040.398289363@infradead.org> Subject: Re: [PATCH 3/6] sched,perf,kvm: Fix preemption condition MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-Originating-IP: [167.114.26.124] X-Mailer: Zimbra 8.8.15_GA_4018 (ZimbraWebClient - FF88 (Linux)/8.8.15_GA_4026) Thread-Topic: sched,perf,kvm: Fix preemption condition Thread-Index: NELkknquBPwUAC7hR8bH+DhrqDwz1A== Precedence: bulk List-ID: X-Mailing-List: linux-block@vger.kernel.org ----- On Jun 2, 2021, at 9:12 AM, Peter Zijlstra peterz@infradead.org wrote: [...] > --- a/kernel/events/core.c > +++ b/kernel/events/core.c > @@ -8568,13 +8568,12 @@ static void perf_event_switch(struct tas > }, > }; > > - if (!sched_in && task->state == TASK_RUNNING) > + if (!sched_in && current->on_rq) { > switch_event.event_id.header.misc |= > PERF_RECORD_MISC_SWITCH_OUT_PREEMPT; > + } > > - perf_iterate_sb(perf_event_switch_output, > - &switch_event, > - NULL); > + perf_iterate_sb(perf_event_switch_output, &switch_event, NULL); > } There is a lot of code cleanup going on here which does not seem to belong to a "Fix" patch. Thanks, Mathieu -- Mathieu Desnoyers EfficiOS Inc. http://www.efficios.com