From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Stultz Subject: [RFC][PATCH 1/2] drm_hwcomposer: Cleanup gl precompositor init and provide uses_GL flag Date: Mon, 23 Apr 2018 17:06:43 -0700 Message-ID: <1524528404-12331-1-git-send-email-john.stultz@linaro.org> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mail-pf0-x244.google.com (mail-pf0-x244.google.com [IPv6:2607:f8b0:400e:c00::244]) by gabe.freedesktop.org (Postfix) with ESMTPS id 1BCE36E31F for ; Tue, 24 Apr 2018 00:06:51 +0000 (UTC) Received: by mail-pf0-x244.google.com with SMTP id p15so10658440pff.11 for ; Mon, 23 Apr 2018 17:06:51 -0700 (PDT) List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: dri-devel Cc: Rob Herring , Matt Szczesiak , Dmitry Shmidt , Sean Paul , Robert Foss , Alexandru-Cosmin Gheorghe , Liviu Dudau , Alistair Strachan , Marissa Wall , David Hanna List-Id: dri-devel@lists.freedesktop.org VGhlIGRybV9od2NvbXBvc2VyIGhhcyBpdHMgb3duIEdMIHByZS1jb21wb3NpdG9yIHdoaWNoIGlz IHVzZWQKdG8gc3F1aXNoIGxheWVycyB3aGVuIHRoZXJlIGFyZSBtb3JlIGxheWVycyB0aGVuIHBs YW5lcyBvbiB0aGUKZGlzcGxheSBoYXJkd2FyZS4gSW4gbWFueSB3YXlzIHRoaXMgZHVwbGljYXRl cyB0aGUgY2xpZW50LXNpZGUKR0wgY29tcG9zaXRpbmcgdGhhdCBpcyBkb25lIGluIFN1cmZhY2VG bGluZ2VyLCBidXQgaW4gdGhlb3J5IGNhbgpiZSBtb3JlIGhpZ2hseSBvcHRpbWl6ZWQgZm9yIHRo ZSBoYXJkd2FyZS4KClVuZm9ydHVuYXRlbHksIGR1ZSB0byB0aGVzZSBvcHRpbWl6YXRpb25zLCB0 aGUgZHJtX2h3Y29tcG9zZXIncwpwcmUtY29tcG9zaXRvciBiZWNvbWVzIHNvbWV3aGF0IGhhcmR3 YXJlIHNwZWNpZmljIChvcmlnaW5hbGx5CnRhcmdldGluZyBudmlkaWEgaGFyZHdhcmUsIEkgYmVs aWV2ZSkuCgpTbyBvbiBzb21lIGhhcmR3YXJlLCB0aGUgZ2wgcHJlY29tcG9zaXRvciBtYXkgbm90 IGFjdHVhbGx5CmluaXRpYWxpemUgZHVlIHRvIGhhcmR3YXJlIG1pc3NpbmcgZmVhdHVyZXMsIG9y IHRoZSBoYXJkd2FyZQpzdXBwb3J0aW5nIGRpZmZlcmVudCBzaGFkZXIgQVBJcy4KClJhdGhlciB0 aGVuIHRyeSB0byByZXdvcmsgdGhlIGRybV9od2NvbXBvc2VycyBwcmVjb21wb3NpdG9yCnRvIGJl IG1vcmUgZ2VuZXJpYywgSSBpbnN0ZWFkIHN1Z2dlc3QgdGhhdCB3aGVuIHRoZQpwcmVjb21wb3Np dG9yIGZhaWxzIHRvIGluaXRpYWxpemUsIHdlIHNpbXBseSBmYWxsIGJhY2sgdG8gdGhlCmFscmVh ZHkgbW9yZSB3aWRlbHkgY29tcGF0aWJsZSBjbGllbnQgY29tcG9zaXRvciBpbgpTdXJmYWNlRmxp bmdlci4KClRodXMsIHRoaXMgcGF0Y2ggY2xlYW5zIHVwIHNvbWUgb2YgdGhlIHByZWNvbXBvc2l0 b3IKaW5pdGlhbGl6YXRpb24sIHdoaWNoIGRpZG4ndCBoYW5kbGUgZmFpbHVyZXMgd2VsbC4KCkZl ZWRiYWNrIG9yIGFsdGVybmF0aXZlIGlkZWFzIHdvdWxkIGJlIGdyZWF0bHkgYXBwcmVjaWF0ZWQh CgpDYzogTWFyaXNzYSBXYWxsIDxtYXJpc3Nhd0Bnb29nbGUuY29tPgpDYzogU2VhbiBQYXVsIDxz ZWFucGF1bEBnb29nbGUuY29tPgpDYzogRG1pdHJ5IFNobWlkdCA8ZGltaXRyeXNoQGdvb2dsZS5j b20+CkNjOiBSb2JlcnQgRm9zcyA8cm9iZXJ0LmZvc3NAY29sbGFib3JhLmNvbT4KQ2M6IE1hdHQg U3pjemVzaWFrIDxtYXR0LnN6Y3plc2lha0Bhcm0uY29tPgpDYzogTGl2aXUgRHVkYXUgPExpdml1 LkR1ZGF1QGFybS5jb20+CkNjOiBEYXZpZCBIYW5uYSA8ZGF2aWQuaGFubmExMUBnbWFpbC5jb20+ CkNjOiBSb2IgSGVycmluZyA8cm9iLmhlcnJpbmdAbGluYXJvLm9yZz4KQ2M6IEFsZXhhbmRydS1D b3NtaW4gR2hlb3JnaGUgPEFsZXhhbmRydS1Db3NtaW4uR2hlb3JnaGVAYXJtLmNvbT4KQ2M6IEFs aXN0YWlyIFN0cmFjaGFuIDxhc3RyYWNoYW5AZ29vZ2xlLmNvbT4KU2lnbmVkLW9mZi1ieTogSm9o biBTdHVsdHogPGpvaG4uc3R1bHR6QGxpbmFyby5vcmc+Ci0tLQogZHJtZGlzcGxheWNvbXBvc2l0 b3IuY3BwIHwgNDAgKysrKysrKysrKysrKysrKysrKysrLS0tLS0tLS0tLS0tLS0tLS0tLQogZHJt ZGlzcGxheWNvbXBvc2l0b3IuaCAgIHwgIDMgKysrCiAyIGZpbGVzIGNoYW5nZWQsIDI0IGluc2Vy dGlvbnMoKyksIDE5IGRlbGV0aW9ucygtKQoKZGlmZiAtLWdpdCBhL2RybWRpc3BsYXljb21wb3Np dG9yLmNwcCBiL2RybWRpc3BsYXljb21wb3NpdG9yLmNwcAppbmRleCBlNTU2ZTg2Li41YzZiZjli IDEwMDY0NAotLS0gYS9kcm1kaXNwbGF5Y29tcG9zaXRvci5jcHAKKysrIGIvZHJtZGlzcGxheWNv bXBvc2l0b3IuY3BwCkBAIC0yMjIsNiArMjIyLDEzIEBAIGludCBEcm1EaXNwbGF5Q29tcG9zaXRv cjo6SW5pdChEcm1SZXNvdXJjZXMgKmRybSwgaW50IGRpc3BsYXkpIHsKICAgICByZXR1cm4gcmV0 OwogICB9CiAKKyAgcHJlX2NvbXBvc2l0b3JfLnJlc2V0KG5ldyBHTFdvcmtlckNvbXBvc2l0b3Io KSk7CisgIHJldCA9IHByZV9jb21wb3NpdG9yXy0+SW5pdCgpOworICBpZiAocmV0KSB7CisgICAg QUxPR0UoIkZhaWxlZCB0byBpbml0aWFsaXplIE9wZW5HTCBjb21wb3NpdG9yICVkIiwgcmV0KTsK KyAgICBwcmVfY29tcG9zaXRvcl8ucmVzZXQoKTsKKyAgfQorCiAgIGluaXRpYWxpemVkXyA9IHRy dWU7CiAgIHJldHVybiAwOwogfQpAQCAtMjk0LDE0ICszMDEsMTYgQEAgaW50IERybURpc3BsYXlD b21wb3NpdG9yOjpBcHBseVNxdWFzaChEcm1EaXNwbGF5Q29tcG9zaXRpb24gKmRpc3BsYXlfY29t cCkgewogICB9CiAKICAgc3RkOjp2ZWN0b3I8RHJtQ29tcG9zaXRpb25SZWdpb24+ICZyZWdpb25z ID0gZGlzcGxheV9jb21wLT5zcXVhc2hfcmVnaW9ucygpOwotICByZXQgPSBwcmVfY29tcG9zaXRv cl8tPkNvbXBvc2l0ZShkaXNwbGF5X2NvbXAtPmxheWVycygpLmRhdGEoKSwKKyAgaWYgKHByZV9j b21wb3NpdG9yXykgeworICAgIHJldCA9IHByZV9jb21wb3NpdG9yXy0+Q29tcG9zaXRlKGRpc3Bs YXlfY29tcC0+bGF5ZXJzKCkuZGF0YSgpLAogICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg ICAgICByZWdpb25zLmRhdGEoKSwgcmVnaW9ucy5zaXplKCksIGZiLmJ1ZmZlcigpLAogICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICAgICBkaXNwbGF5X2NvbXAtPmltcG9ydGVyKCkpOwot ICBwcmVfY29tcG9zaXRvcl8tPkZpbmlzaCgpOworICAgIHByZV9jb21wb3NpdG9yXy0+RmluaXNo KCk7CiAKLSAgaWYgKHJldCkgewotICAgIEFMT0dFKCJGYWlsZWQgdG8gc3F1YXNoIGxheWVycyIp OwotICAgIHJldHVybiByZXQ7CisgICAgaWYgKHJldCkgeworICAgICAgQUxPR0UoIkZhaWxlZCB0 byBzcXVhc2ggbGF5ZXJzIik7CisgICAgICByZXR1cm4gcmV0OworICAgIH0KICAgfQogCiAgIHJl dCA9IGRpc3BsYXlfY29tcC0+Q3JlYXRlTmV4dFRpbWVsaW5lRmVuY2UoKTsKQEAgLTMyOCwxNCAr MzM3LDE2IEBAIGludCBEcm1EaXNwbGF5Q29tcG9zaXRvcjo6QXBwbHlQcmVDb21wb3NpdGUoCiAg IH0KIAogICBzdGQ6OnZlY3RvcjxEcm1Db21wb3NpdGlvblJlZ2lvbj4gJnJlZ2lvbnMgPSBkaXNw bGF5X2NvbXAtPnByZV9jb21wX3JlZ2lvbnMoKTsKLSAgcmV0ID0gcHJlX2NvbXBvc2l0b3JfLT5D b21wb3NpdGUoZGlzcGxheV9jb21wLT5sYXllcnMoKS5kYXRhKCksCisgIGlmIChwcmVfY29tcG9z aXRvcl8pIHsKKyAgICByZXQgPSBwcmVfY29tcG9zaXRvcl8tPkNvbXBvc2l0ZShkaXNwbGF5X2Nv bXAtPmxheWVycygpLmRhdGEoKSwKICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICAg cmVnaW9ucy5kYXRhKCksIHJlZ2lvbnMuc2l6ZSgpLCBmYi5idWZmZXIoKSwKICAgICAgICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgZGlzcGxheV9jb21wLT5pbXBvcnRlcigpKTsKLSAgcHJl X2NvbXBvc2l0b3JfLT5GaW5pc2goKTsKKyAgICBwcmVfY29tcG9zaXRvcl8tPkZpbmlzaCgpOwog Ci0gIGlmIChyZXQpIHsKLSAgICBBTE9HRSgiRmFpbGVkIHRvIHByZS1jb21wb3NpdGUgbGF5ZXJz Iik7Ci0gICAgcmV0dXJuIHJldDsKKyAgICBpZiAocmV0KSB7CisgICAgICBBTE9HRSgiRmFpbGVk IHRvIHByZS1jb21wb3NpdGUgbGF5ZXJzIik7CisgICAgICByZXR1cm4gcmV0OworICAgIH0KICAg fQogCiAgIHJldCA9IGRpc3BsYXlfY29tcC0+Q3JlYXRlTmV4dFRpbWVsaW5lRmVuY2UoKTsKQEAg LTM5NSwxNSArNDA2LDYgQEAgaW50IERybURpc3BsYXlDb21wb3NpdG9yOjpQcmVwYXJlRnJhbWUo RHJtRGlzcGxheUNvbXBvc2l0aW9uICpkaXNwbGF5X2NvbXApIHsKICAgc3RkOjp2ZWN0b3I8RHJt Q29tcG9zaXRpb25SZWdpb24+ICZwcmVfY29tcF9yZWdpb25zID0KICAgICAgIGRpc3BsYXlfY29t cC0+cHJlX2NvbXBfcmVnaW9ucygpOwogCi0gIGlmICghcHJlX2NvbXBvc2l0b3JfKSB7Ci0gICAg cHJlX2NvbXBvc2l0b3JfLnJlc2V0KG5ldyBHTFdvcmtlckNvbXBvc2l0b3IoKSk7Ci0gICAgaW50 IHJldCA9IHByZV9jb21wb3NpdG9yXy0+SW5pdCgpOwotICAgIGlmIChyZXQpIHsKLSAgICAgIEFM T0dFKCJGYWlsZWQgdG8gaW5pdGlhbGl6ZSBPcGVuR0wgY29tcG9zaXRvciAlZCIsIHJldCk7Ci0g ICAgICByZXR1cm4gcmV0OwotICAgIH0KLSAgfQotCiAgIGludCBzcXVhc2hfbGF5ZXJfaW5kZXgg PSAtMTsKICAgaWYgKHNxdWFzaF9yZWdpb25zLnNpemUoKSA+IDApIHsKICAgICBzcXVhc2hfZnJh bWVidWZmZXJfaW5kZXhfID0gKHNxdWFzaF9mcmFtZWJ1ZmZlcl9pbmRleF8gKyAxKSAlIDI7CmRp ZmYgLS1naXQgYS9kcm1kaXNwbGF5Y29tcG9zaXRvci5oIGIvZHJtZGlzcGxheWNvbXBvc2l0b3Iu aAppbmRleCBmMTk2NWZiLi5lZDZjNWY5IDEwMDY0NAotLS0gYS9kcm1kaXNwbGF5Y29tcG9zaXRv ci5oCisrKyBiL2RybWRpc3BsYXljb21wb3NpdG9yLmgKQEAgLTk4LDYgKzk4LDkgQEAgY2xhc3Mg RHJtRGlzcGxheUNvbXBvc2l0b3IgewogICAgIHJldHVybiAmc3F1YXNoX3N0YXRlXzsKICAgfQog CisgIGJvb2wgdXNlc19HTCgpIHsKKyAgICByZXR1cm4gISFwcmVfY29tcG9zaXRvcl87CisgIH0K ICBwcml2YXRlOgogICBzdHJ1Y3QgTW9kZVN0YXRlIHsKICAgICBib29sIG5lZWRzX21vZGVzZXQg PSBmYWxzZTsKLS0gCjIuNy40CgpfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fXwpkcmktZGV2ZWwgbWFpbGluZyBsaXN0CmRyaS1kZXZlbEBsaXN0cy5mcmVlZGVz a3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9k cmktZGV2ZWwK