From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mika Kahola Subject: Re: [PATCH 2/3] drm/i915/dp: Fix sink-crc reads. Date: Tue, 24 Apr 2018 16:26:10 +0300 Message-ID: <1524576370.11552.7.camel@intel.com> References: <20180424025659.23659-1-dhinakaran.pandiyan@intel.com> <20180424025659.23659-2-dhinakaran.pandiyan@intel.com> Reply-To: mika.kahola@intel.com Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id E69836E058 for ; Tue, 24 Apr 2018 13:26:13 +0000 (UTC) In-Reply-To: <20180424025659.23659-2-dhinakaran.pandiyan@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Dhinakaran Pandiyan , intel-gfx@lists.freedesktop.org Cc: rodrigo.vivi@intel.com List-Id: intel-gfx@lists.freedesktop.org T24gTW9uLCAyMDE4LTA0LTIzIGF0IDE5OjU2IC0wNzAwLCBEaGluYWthcmFuIFBhbmRpeWFuIHdy b3RlOgo+IFNpbmsgY3JjIGlzIGNhbGN1bGF0ZWQgYnkgdGhlIHNpbmsgZm9yIHN0YXRpYyBmcmFt ZXMgaXJyZXNwZWN0aXZlIG9mCj4gd2hhdCB0aGUgZHJpdmVyIHNldHMgaW4gVEVTVF9TSU5LX1NU QVJUIGRwY2QuIFNpbmNlIFBTUiBpcyB0aGUgb25seQo+IHVzZQo+IGNhc2UgZm9yIHNpbmsgY3Jj LCB3ZSBkb24ndCByZWFsbHkgbmVlZCB0aGUgc2lua19jcmNfe3N0YXJ0LCBzdG9wfQo+IGNvZGUu Cj4gCj4gVGhlIHNlY29uZCBwcm9ibGVtIHdpdGggdGhlIGN1cnJlbnQgaW1wbGVtZW50YXRpb24g aXMgdmJsYW5rIHdhaXRzLgo+IEVuYWJsaW5nIHZibGFuayBpbnRlcnJ1cHRzIHRyaWdnZXJzIFBT UiBleGl0LCB3aGljaCBtZWFucyB3ZSBhcmVuJ3QKPiByZWFsbHkgcmVhZGluZyB0aGUgY29ycmVj dCBDUkMgdmFsdWVzIGZvciBQU1IgdGVzdHMuIHZibGFuayB3YWl0cyBhcmUKPiByZXBsYWNlZCBi eSBkZWxheXMuCj4gCj4gV2l0aCB0aGUgY2hhbmdlcyBtYWRlIGluIHRoaXMgcGF0Y2gsIHNpbmsg Q1JDIGlzIGF2YWlsYWJsZSBvbmx5IGZvcgo+IHN0YXRpYyBmcmFtZXMuIEkgaGF2ZSB0ZXN0ZWQg dGhpcyBvbiBhIFNLTCBsYXB0b3Agd2l0aCBQU1IgcGFuZWwuCj4gCj4gU2lnbmVkLW9mZi1ieTog RGhpbmFrYXJhbiBQYW5kaXlhbiA8ZGhpbmFrYXJhbi5wYW5kaXlhbkBpbnRlbC5jb20+Cj4gLS0t Cj4gwqBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2RlYnVnZnMuYyB8wqDCoMKgMiArLQo+IMKg ZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZHAuY8KgwqDCoMKgwqB8IDExNCArKysrLS0tLS0t LS0tLS0tLS0tLS0tLS0KPiAtLS0tLS0tLS0tLS0KPiDCoGRyaXZlcnMvZ3B1L2RybS9pOTE1L2lu dGVsX2Rydi5owqDCoMKgwqB8wqDCoMKgMyArLQo+IMKgMyBmaWxlcyBjaGFuZ2VkLCAxNSBpbnNl cnRpb25zKCspLCAxMDQgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2k5MTVfZGVidWdmcy5jCj4gYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X2Rl YnVnZnMuYwo+IGluZGV4IDJmMDVmNTI2MmJiYS4uMzVmYTE0MThjYzA3IDEwMDY0NAo+IC0tLSBh L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2k5MTVfZGVidWdmcy5jCj4gKysrIGIvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaTkxNV9kZWJ1Z2ZzLmMKPiBAQCAtMjc4NCw3ICsyNzg0LDcgQEAgc3RhdGljIGlu dCBpOTE1X3NpbmtfY3JjKHN0cnVjdCBzZXFfZmlsZSAqbSwKPiB2b2lkICpkYXRhKQo+IMKgCj4g wqAJCWludGVsX2RwID0gZW5jX3RvX2ludGVsX2RwKHN0YXRlLT5iZXN0X2VuY29kZXIpOwo+IMKg Cj4gLQkJcmV0ID0gaW50ZWxfZHBfc2lua19jcmMoaW50ZWxfZHAsIGNydGNfc3RhdGUsIGNyYyk7 Cj4gKwkJcmV0ID0gaW50ZWxfZHBfc2lua19jcmMoaW50ZWxfZHAsIGNyYyk7Cj4gwqAJCWlmIChy ZXQpCj4gwqAJCQlnb3RvIGVycjsKPiDCoAo+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0v aTkxNS9pbnRlbF9kcC5jCj4gYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcC5jCj4gaW5k ZXggN2RjYzg3NGI3ZDhmLi43MzUyYWI2MzFlYTggMTAwNjQ0Cj4gLS0tIGEvZHJpdmVycy9ncHUv ZHJtL2k5MTUvaW50ZWxfZHAuYwo+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rw LmMKPiBAQCAtMzg3NiwzMiArMzg3NiwxOCBAQCBpbnRlbF9kcF9jb25maWd1cmVfbXN0KHN0cnVj dCBpbnRlbF9kcAo+ICppbnRlbF9kcCkKPiDCoAkJCQkJaW50ZWxfZHAtPmlzX21zdCk7Cj4gwqB9 Cj4gwqAKPiAtc3RhdGljIGludCBpbnRlbF9kcF9zaW5rX2NyY19zdG9wKHN0cnVjdCBpbnRlbF9k cCAqaW50ZWxfZHAsCj4gLQkJCQnCoMKgc3RydWN0IGludGVsX2NydGNfc3RhdGUKPiAqY3J0Y19z dGF0ZSwgYm9vbCBkaXNhYmxlX3dhKQo+ICtpbnQgaW50ZWxfZHBfc2lua19jcmMoc3RydWN0IGlu dGVsX2RwICppbnRlbF9kcCwgdTggKmNyYykKPiDCoHsKPiAtCXN0cnVjdCBpbnRlbF9kaWdpdGFs X3BvcnQgKmRpZ19wb3J0ID0KPiBkcF90b19kaWdfcG9ydChpbnRlbF9kcCk7Cj4gLQlzdHJ1Y3Qg ZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSB0b19pOTE1KGRpZ19wb3J0LQo+ID5iYXNlLmJh c2UuZGV2KTsKPiAtCXN0cnVjdCBpbnRlbF9jcnRjICppbnRlbF9jcnRjID0gdG9faW50ZWxfY3J0 YyhjcnRjX3N0YXRlLQo+ID5iYXNlLmNydGMpOwo+IC0JdTggYnVmOwo+IC0JaW50IHJldCA9IDA7 Cj4gLQlpbnQgY291bnQgPSAwOwo+IC0JaW50IGF0dGVtcHRzID0gMTA7Cj4gKwlpbnQgY291bnQg PSAwLCByZXQgPSAwLCBhdHRlbXB0czsKPiDCoAo+IC0JaWYgKGRybV9kcF9kcGNkX3JlYWRiKCZp bnRlbF9kcC0+YXV4LCBEUF9URVNUX1NJTkssICZidWYpIDwKPiAwKSB7Cj4gLQkJRFJNX0RFQlVH X0tNUygiU2luayBDUkMgY291bGRuJ3QgYmUgc3RvcHBlZAo+IHByb3Blcmx5XG4iKTsKPiAtCQly ZXQgPSAtRUlPOwo+IC0JCWdvdG8gb3V0Owo+IC0JfQo+ICsJZm9yIChhdHRlbXB0cyA9IDA7IGF0 dGVtcHRzIDwgMyAmJiBjb3VudCA9PSAwOyBhdHRlbXB0cysrKSB7CkEgcXVlc3Rpb24uIEhvdyBk aWQgeW91IGVuZCB1cCB3aXRoIHRocmVlIGF0dGVtcHRzIG9yIG9uZSBhbmQgYSBoYWxmCmZyYW1l cz8gV2UgdXNlZCB0byB0cnkgNiB0aW1lcyBvciA2IHZibGFua3MgdW50aWwgd2UgZ2F2ZSB1cCB0 cnlpbmcuCldlbGwsIEkgZG9uJ3QgcmVhbGx5IGtub3cgdGhlIGhpc3Rvcnkgd2h5IHdlIGhhdmUg ZW5kZWQgdXAgd2l0aCA2CmF0dGVtcHRzIGluIHRoZSBmaXJzdCBwbGFjZS7CoAoKCj4gKwkJdTgg YnVmOwo+IMKgCj4gLQlpZiAoZHJtX2RwX2RwY2Rfd3JpdGViKCZpbnRlbF9kcC0+YXV4LCBEUF9U RVNUX1NJTkssCj4gLQkJCcKgwqDCoMKgwqDCoMKgYnVmICYgfkRQX1RFU1RfU0lOS19TVEFSVCkg PCAwKSB7Cj4gLQkJRFJNX0RFQlVHX0tNUygiU2luayBDUkMgY291bGRuJ3QgYmUgc3RvcHBlZAo+ IHByb3Blcmx5XG4iKTsKPiAtCQlyZXQgPSAtRUlPOwo+IC0JCWdvdG8gb3V0Owo+IC0JfQo+IC0K PiAtCWRvIHsKPiAtCQlpbnRlbF93YWl0X2Zvcl92YmxhbmsoZGV2X3ByaXYsIGludGVsX2NydGMt PnBpcGUpOwo+ICsJCS8qIFdhaXQgZm9yIGFwcHJveGltYXRlbHkgaGFsZiBhIGZyYW1lLCB3ZSBj YW5ub3QKPiB3YWl0IGZvciBhCj4gKwkJwqAqIHZibGFuayBpbnRlcnJ1cHQgYXMgaXQgdHJpZ2dl cnMgUFNSIGV4aXQuCj4gKwkJwqAqLwo+ICsJCWlmIChhdHRlbXB0cykKPiArCQkJdXNsZWVwX3Jh bmdlKDgwMDAsIDg1MDApOwo+IMKgCj4gwqAJCWlmIChkcm1fZHBfZHBjZF9yZWFkYigmaW50ZWxf ZHAtPmF1eCwKPiDCoAkJCQnCoMKgwqDCoMKgwqBEUF9URVNUX1NJTktfTUlTQywgJmJ1ZikgPCAw KQo+IHsKPiBAQCAtMzkwOSw5MyArMzg5NSwxOSBAQCBzdGF0aWMgaW50IGludGVsX2RwX3Npbmtf Y3JjX3N0b3Aoc3RydWN0Cj4gaW50ZWxfZHAgKmludGVsX2RwLAo+IMKgCQkJZ290byBvdXQ7Cj4g wqAJCX0KPiDCoAkJY291bnQgPSBidWYgJiBEUF9URVNUX0NPVU5UX01BU0s7Cj4gLQl9IHdoaWxl ICgtLWF0dGVtcHRzICYmIGNvdW50KTsKPiAtCj4gLQlpZiAoYXR0ZW1wdHMgPT0gMCkgewo+IC0J CURSTV9ERUJVR19LTVMoIlRJTUVPVVQ6IFNpbmsgQ1JDIGNvdW50ZXIgaXMgbm90Cj4gemVyb2Vk IGFmdGVyIGNhbGN1bGF0aW9uIGlzIHN0b3BwZWRcbiIpOwo+IC0JCXJldCA9IC1FVElNRURPVVQ7 Cj4gwqAJfQo+IMKgCj4gLSBvdXQ6Cj4gLQlpZiAoZGlzYWJsZV93YSkKPiAtCQloc3dfZW5hYmxl X2lwcyhjcnRjX3N0YXRlKTsKPiAtCXJldHVybiByZXQ7Cj4gLX0KPiAtCj4gLXN0YXRpYyBpbnQg aW50ZWxfZHBfc2lua19jcmNfc3RhcnQoc3RydWN0IGludGVsX2RwICppbnRlbF9kcCwKPiAtCQkJ CcKgwqDCoHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlCj4gKmNydGNfc3RhdGUpCj4gLXsKPiAtCXN0 cnVjdCBpbnRlbF9kaWdpdGFsX3BvcnQgKmRpZ19wb3J0ID0KPiBkcF90b19kaWdfcG9ydChpbnRl bF9kcCk7Cj4gLQlzdHJ1Y3QgZHJtX2k5MTVfcHJpdmF0ZSAqZGV2X3ByaXYgPSB0b19pOTE1KGRp Z19wb3J0LQo+ID5iYXNlLmJhc2UuZGV2KTsKPiAtCXN0cnVjdCBpbnRlbF9jcnRjICppbnRlbF9j cnRjID0gdG9faW50ZWxfY3J0YyhjcnRjX3N0YXRlLQo+ID5iYXNlLmNydGMpOwo+IC0JdTggYnVm Owo+IC0JaW50IHJldDsKPiAtCj4gLQlpZiAoZHJtX2RwX2RwY2RfcmVhZGIoJmludGVsX2RwLT5h dXgsIERQX1RFU1RfU0lOS19NSVNDLAo+ICZidWYpIDwgMCkKPiAtCQlyZXR1cm4gLUVJTzsKPiAt Cj4gLQlpZiAoIShidWYgJiBEUF9URVNUX0NSQ19TVVBQT1JURUQpKQo+IC0JCXJldHVybiAtRU5P VFRZOwo+IC0KPiAtCWlmIChkcm1fZHBfZHBjZF9yZWFkYigmaW50ZWxfZHAtPmF1eCwgRFBfVEVT VF9TSU5LLCAmYnVmKSA8Cj4gMCkKPiAtCQlyZXR1cm4gLUVJTzsKPiAtCj4gLQlpZiAoYnVmICYg RFBfVEVTVF9TSU5LX1NUQVJUKSB7Cj4gLQkJcmV0ID0gaW50ZWxfZHBfc2lua19jcmNfc3RvcChp bnRlbF9kcCwgY3J0Y19zdGF0ZSwKPiBmYWxzZSk7Cj4gLQkJaWYgKHJldCkKPiAtCQkJcmV0dXJu IHJldDsKPiAtCX0KPiAtCj4gLQloc3dfZGlzYWJsZV9pcHMoY3J0Y19zdGF0ZSk7Cj4gLQo+IC0J aWYgKGRybV9kcF9kcGNkX3dyaXRlYigmaW50ZWxfZHAtPmF1eCwgRFBfVEVTVF9TSU5LLAo+IC0J CQnCoMKgwqDCoMKgwqDCoGJ1ZiB8IERQX1RFU1RfU0lOS19TVEFSVCkgPCAwKSB7Cj4gLQkJaHN3 X2VuYWJsZV9pcHMoY3J0Y19zdGF0ZSk7Cj4gLQkJcmV0dXJuIC1FSU87Cj4gLQl9Cj4gLQo+IC0J aW50ZWxfd2FpdF9mb3JfdmJsYW5rKGRldl9wcml2LCBpbnRlbF9jcnRjLT5waXBlKTsKPiAtCXJl dHVybiAwOwo+IC19Cj4gLQo+IC1pbnQgaW50ZWxfZHBfc2lua19jcmMoc3RydWN0IGludGVsX2Rw ICppbnRlbF9kcCwgc3RydWN0Cj4gaW50ZWxfY3J0Y19zdGF0ZSAqY3J0Y19zdGF0ZSwgdTggKmNy YykKPiAtewo+IC0Jc3RydWN0IGludGVsX2RpZ2l0YWxfcG9ydCAqZGlnX3BvcnQgPQo+IGRwX3Rv X2RpZ19wb3J0KGludGVsX2RwKTsKPiAtCXN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJp diA9IHRvX2k5MTUoZGlnX3BvcnQtCj4gPmJhc2UuYmFzZS5kZXYpOwo+IC0Jc3RydWN0IGludGVs X2NydGMgKmludGVsX2NydGMgPSB0b19pbnRlbF9jcnRjKGNydGNfc3RhdGUtCj4gPmJhc2UuY3J0 Yyk7Cj4gLQl1OCBidWY7Cj4gLQlpbnQgY291bnQsIHJldDsKPiAtCWludCBhdHRlbXB0cyA9IDY7 Cj4gLQo+IC0JcmV0ID0gaW50ZWxfZHBfc2lua19jcmNfc3RhcnQoaW50ZWxfZHAsIGNydGNfc3Rh dGUpOwo+IC0JaWYgKHJldCkKPiAtCQlyZXR1cm4gcmV0Owo+IC0KPiAtCWRvIHsKPiAtCQlpbnRl bF93YWl0X2Zvcl92YmxhbmsoZGV2X3ByaXYsIGludGVsX2NydGMtPnBpcGUpOwo+IC0KPiAtCQlp ZiAoZHJtX2RwX2RwY2RfcmVhZGIoJmludGVsX2RwLT5hdXgsCj4gLQkJCQnCoMKgwqDCoMKgwqBE UF9URVNUX1NJTktfTUlTQywgJmJ1ZikgPCAwKQo+IHsKPiAtCQkJcmV0ID0gLUVJTzsKPiAtCQkJ Z290byBzdG9wOwo+IC0JCX0KPiAtCQljb3VudCA9IGJ1ZiAmIERQX1RFU1RfQ09VTlRfTUFTSzsK PiAtCj4gLQl9IHdoaWxlICgtLWF0dGVtcHRzICYmIGNvdW50ID09IDApOwo+IC0KPiAtCWlmIChh dHRlbXB0cyA9PSAwKSB7Cj4gLQkJRFJNX0VSUk9SKCJQYW5lbCBpcyB1bmFibGUgdG8gY2FsY3Vs YXRlIGFueSBDUkMKPiBhZnRlciA2IHZibGFua3NcbiIpOwo+ICsJaWYgKGF0dGVtcHRzID09IDMp IHsKPiDCoAkJcmV0ID0gLUVUSU1FRE9VVDsKPiAtCQlnb3RvIHN0b3A7Cj4gKwkJZ290byBvdXQ7 Cj4gwqAJfQo+IMKgCj4gwqAJaWYgKGRybV9kcF9kcGNkX3JlYWQoJmludGVsX2RwLT5hdXgsIERQ X1RFU1RfQ1JDX1JfQ1IsIGNyYywKPiA2KSAhPSA2KSB7Cj4gwqAJCXJldCA9IC1FSU87Cj4gLQkJ Z290byBzdG9wOwo+ICsJCWdvdG8gb3V0Owo+IMKgCX0KPiDCoAo+IC1zdG9wOgo+IC0JaW50ZWxf ZHBfc2lua19jcmNfc3RvcChpbnRlbF9kcCwgY3J0Y19zdGF0ZSwgdHJ1ZSk7Cj4gK291dDoKPiDC oAlyZXR1cm4gcmV0Owo+IMKgfQo+IMKgCj4gZGlmZiAtLWdpdCBhL2RyaXZlcnMvZ3B1L2RybS9p OTE1L2ludGVsX2Rydi5oCj4gYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kcnYuaAo+IGlu ZGV4IDQ0ZWQyNDhmMWZlOS4uY2FjZWU5NDc0OWUyIDEwMDY0NAo+IC0tLSBhL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2Rydi5oCj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf ZHJ2LmgKPiBAQCAtMTY0NCw4ICsxNjQ0LDcgQEAgdm9pZCBpbnRlbF9kcF9zaW5rX2RwbXMoc3Ry dWN0IGludGVsX2RwCj4gKmludGVsX2RwLCBpbnQgbW9kZSk7Cj4gwqB2b2lkIGludGVsX2RwX2Vu Y29kZXJfcmVzZXQoc3RydWN0IGRybV9lbmNvZGVyICplbmNvZGVyKTsKPiDCoHZvaWQgaW50ZWxf ZHBfZW5jb2Rlcl9zdXNwZW5kKHN0cnVjdCBpbnRlbF9lbmNvZGVyICppbnRlbF9lbmNvZGVyKTsK PiDCoHZvaWQgaW50ZWxfZHBfZW5jb2Rlcl9kZXN0cm95KHN0cnVjdCBkcm1fZW5jb2RlciAqZW5j b2Rlcik7Cj4gLWludCBpbnRlbF9kcF9zaW5rX2NyYyhzdHJ1Y3QgaW50ZWxfZHAgKmludGVsX2Rw LAo+IC0JCcKgwqDCoMKgwqDCoHN0cnVjdCBpbnRlbF9jcnRjX3N0YXRlICpjcnRjX3N0YXRlLCB1 OCAqY3JjKTsKPiAraW50IGludGVsX2RwX3NpbmtfY3JjKHN0cnVjdCBpbnRlbF9kcCAqaW50ZWxf ZHAsIHU4ICpjcmMpOwo+IMKgYm9vbCBpbnRlbF9kcF9jb21wdXRlX2NvbmZpZyhzdHJ1Y3QgaW50 ZWxfZW5jb2RlciAqZW5jb2RlciwKPiDCoAkJCcKgwqDCoMKgwqBzdHJ1Y3QgaW50ZWxfY3J0Y19z dGF0ZSAqcGlwZV9jb25maWcsCj4gwqAJCQnCoMKgwqDCoMKgc3RydWN0IGRybV9jb25uZWN0b3Jf c3RhdGUKPiAqY29ubl9zdGF0ZSk7Ci0tIApNaWthIEthaG9sYSAtIEludGVsIE9UQwoKX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxp bmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJl ZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==