Re: [PATCH v3 0/2] IB/hfi1: Cleanup PCIe link configuration

[Doug Ledford <dledford@redhat.com>]

[-- Attachment #1: Type: text/plain, Size: 1470 bytes --]

On Fri, 2018-04-27 at 12:58 -0500, Bjorn Helgaas wrote:
> On Mon, Apr 16, 2018 at 07:28:23PM -0500, Frederick Lawler wrote:
> > The IB/hfi1 driver uses custom macros to configure the target link speed. Some 
> > macros were previously replaced, but not fully. This patch series addresses the
> > configuration inconsistencies by adding PCI_EXP_LNKCTL2_TLS* macros to PCI,
> > and then use them in the following IB/hfi1 patch.
> > 
> > V3: 
> > 	* PCI: Add PCI_EXP_LNKCTL2_TLS_* macros
> > 	* Drop patch to use extract_speed() in do_pcie_gen3_transition()
> > V2:
> > 	* s/LINK/LNK
> > 
> > Frederick Lawler (2):
> >   PCI: Add PCI_EXP_LNKCTL2_TLS* macros
> >   IB/hfi1: Replace custom hfi1 macros with PCIe macros
> > 
> >  drivers/infiniband/hw/hfi1/pcie.c | 24 ++++++++----------------
> >  include/uapi/linux/pci_regs.h     |  5 +++++
> >  2 files changed, 13 insertions(+), 16 deletions(-)
> 
> I applied these, with Michael's reviewed-by on the second, to
> pci/misc for v4.18, thanks!
> 
> Ideally we could pull some of this link speed management code into the
> PCI core someday, but I think these patches are useful as-is.
> 
> Oh, I did s/PCI_EXP_LNKCTL2_TLS_2_5GB/PCI_EXP_LNKCTL2_TLS_2_5GT/
> because the link speeds are actually defined in terms of GT/s, not
> GB/s.

Thanks :-)

-- 
Doug Ledford <dledford@redhat.com>
    GPG KeyID: B826A3330E572FDD
    Key fingerprint = AE6B 1BDA 122B 23B4 265B  1274 B826 A333 0E57 2FDD

[-- Attachment #2: This is a digitally signed message part --]
[-- Type: application/pgp-signature, Size: 833 bytes --]