All of lore.kernel.org
 help / color / mirror / Atom feed
From: Paulo Zanoni <paulo.r.zanoni@intel.com>
To: "José Roberto de Souza" <jose.souza@intel.com>,
	igt-dev@lists.freedesktop.org
Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
Subject: Re: [igt-dev] [PATCH] lib/kbl: Add missing Kaby Lake PCI ID
Date: Fri, 27 Apr 2018 16:36:56 -0700	[thread overview]
Message-ID: <1524872216.2544.19.camel@intel.com> (raw)
In-Reply-To: <20180427230516.6188-1-jose.souza@intel.com>

Em Sex, 2018-04-27 às 16:05 -0700, José Roberto de Souza escreveu:
> This PCI ID was recently added to kernel in commit
> '672e314b21dc ("drm/i915/kbl: Add KBL GT2 sku")'
> but not added here.

Please see "[PATCH igt 1/3] lib: sync with the newer i915_pciids.h from
the Kernel (KBL + ICL)".

We should just be copying i915_pciids.h from the Kernel to here, so
both files stay in sync and differences are easier to spot.

This also means that the new ID should be added in a different spot.

Thanks,
Paulo

> 
> Cc: Rodrigo Vivi <rodrigo.vivi@intel.com>
> Cc: James Ausmus <james.ausmus@intel.com>
> Signed-off-by: José Roberto de Souza <jose.souza@intel.com>
> ---
>  lib/i915_pciids.h | 3 ++-
>  1 file changed, 2 insertions(+), 1 deletion(-)
> 
> diff --git a/lib/i915_pciids.h b/lib/i915_pciids.h
> index 0b2ba46f..334d6321 100644
> --- a/lib/i915_pciids.h
> +++ b/lib/i915_pciids.h
> @@ -354,7 +354,8 @@
>  	INTEL_VGA_DEVICE(0x5912, info), /* DT  GT2 */ \
>  	INTEL_VGA_DEVICE(0x591B, info), /* Halo GT2 */ \
>  	INTEL_VGA_DEVICE(0x591A, info), /* SRV GT2 */ \
> -	INTEL_VGA_DEVICE(0x591D, info) /* WKS GT2 */
> +	INTEL_VGA_DEVICE(0x591D, info), /* WKS GT2 */ \
> +	INTEL_VGA_DEVICE(0x591C, info)  /* ULX GT2 */
>  
>  #define INTEL_KBL_GT3_IDS(info) \
>  	INTEL_VGA_DEVICE(0x5923, info), /* ULT GT3 */ \
_______________________________________________
igt-dev mailing list
igt-dev@lists.freedesktop.org
https://lists.freedesktop.org/mailman/listinfo/igt-dev

  reply	other threads:[~2018-04-27 23:37 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-04-27 23:05 [igt-dev] [PATCH] lib/kbl: Add missing Kaby Lake PCI ID José Roberto de Souza
2018-04-27 23:36 ` Paulo Zanoni [this message]
2018-04-28  0:00   ` Souza, Jose
2018-04-30 13:23 ` [igt-dev] ✓ Fi.CI.BAT: success for " Patchwork
2018-04-30 17:35 ` [igt-dev] ✓ Fi.CI.IGT: " Patchwork

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1524872216.2544.19.camel@intel.com \
    --to=paulo.r.zanoni@intel.com \
    --cc=igt-dev@lists.freedesktop.org \
    --cc=jose.souza@intel.com \
    --cc=rodrigo.vivi@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.