From: Knut Omang <knut.omang@oracle.com>
To: "Daniel P. Berrangé" <berrange@redhat.com>
Cc: qemu-devel@nongnu.org, Peter Maydell <peter.maydell@linaro.org>
Subject: Re: [Qemu-devel] [PULL v1 2/2] tests: Add test-listen - a stress test for QEMU socket listen
Date: Tue, 01 May 2018 16:21:01 +0200 [thread overview]
Message-ID: <1525184461.2540.675.camel@oracle.com> (raw)
In-Reply-To: <20180501140744.GD32129@redhat.com>
On Tue, 2018-05-01 at 15:07 +0100, Daniel P. Berrangé wrote:
> On Tue, May 01, 2018 at 04:00:35PM +0200, Knut Omang wrote:
> > Hi Peter,
> >
> > Seems this test was lost along the way?
> >
> > I thought it got merged with Daniel's fix to the potential leak
> > that the test exposed in your build, but it seems not?
>
> I've never been able to get this test, nor another one of my own
> to succesfully pass automated testing in all the various test
> envs Peter and our many CI systems use.
Ok, that explains it - no big deal from my side, I just thought
it was "value lost" against future errors.
Would it make sense to let the test check for environment and just
really run in cases where it reliably passes?
That will also serve as documentation as to where there might be
additional issues hidden?
Knut
next prev parent reply other threads:[~2018-05-01 14:21 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-11-06 15:33 [Qemu-devel] [PULL v1 0/2] Merge IO 2017/11/06 Daniel P. Berrange
2017-11-06 15:33 ` [Qemu-devel] [PULL v1 1/2] sockets: avoid leak of listen file descriptor Daniel P. Berrange
2017-11-06 15:33 ` [Qemu-devel] [PULL v1 2/2] tests: Add test-listen - a stress test for QEMU socket listen Daniel P. Berrange
2018-05-01 14:00 ` Knut Omang
2018-05-01 14:07 ` Daniel P. Berrangé
2018-05-01 14:21 ` Knut Omang [this message]
2018-05-01 14:36 ` Daniel P. Berrangé
2017-11-06 16:11 ` [Qemu-devel] [PULL v1 0/2] Merge IO 2017/11/06 Peter Maydell
2017-11-06 17:43 ` Daniel P. Berrange
2017-11-06 17:58 ` Peter Maydell
2017-11-07 9:19 ` Daniel P. Berrange
2017-11-07 14:40 ` Daniel P. Berrange
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1525184461.2540.675.camel@oracle.com \
--to=knut.omang@oracle.com \
--cc=berrange@redhat.com \
--cc=peter.maydell@linaro.org \
--cc=qemu-devel@nongnu.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.