From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paulo Zanoni Subject: Re: [PATCH] drm/i915: configure the transcoder clocks before touching pipeconf on HSW+ Date: Wed, 02 May 2018 14:06:31 -0700 Message-ID: <1525295191.2516.11.camel@intel.com> References: <20180427231208.9092-1-paulo.r.zanoni@intel.com> <20180430181212.GE23723@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 8591A6E579 for ; Wed, 2 May 2018 21:06:44 +0000 (UTC) In-Reply-To: <20180430181212.GE23723@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Ville =?ISO-8859-1?Q?Syrj=E4l=E4?= Cc: intel-gfx@lists.freedesktop.org, Arthur J Runyan List-Id: intel-gfx@lists.freedesktop.org RW0gU2VnLCAyMDE4LTA0LTMwIMOgcyAyMToxMiArMDMwMCwgVmlsbGUgU3lyasOkbMOkIGVzY3Jl dmV1Ogo+IE9uIEZyaSwgQXByIDI3LCAyMDE4IGF0IDA0OjEyOjA4UE0gLTA3MDAsIFBhdWxvIFph bm9uaSB3cm90ZToKPiA+IEZvciBhbGwgcGxhdGZvcm1zIHRoYXQgcnVuIGhhc3dlbGxfY3J0Y19l bmFibGUsIG91ciBzcGVjIHRlbGxzIHVzCj4gPiB0bwo+ID4gY29uZmlndXJlIHRoZSB0cmFuc2Nv ZGVyIGNsb2NrcyBiZWZvcmUgaXQgdGVsbHMgdXMgdG8gc2V0IHBpcGVjb25mCj4gPiBhbmQKPiA+ IHRoZSBvdGhlciBwaXBlL3RyYW5zY29kZXIvcGxhbmUgcmVnaXN0ZXJzLgo+ID4gCj4gPiBGb3Ig c29tZSByZWFzb24gd2UndmUgYmVlbiBhYmxlIHRvIGdldCBhd2F5IHdpdGggZG9pbmcgd2hhdCB3 ZSB3ZXJlCj4gPiBkb2luZyB1bnRpbCBub3csIGJ1dCBzdGFydGluZyBmcm9tIEljZWxha2UsIHdl IGdldCBtYWNoaW5lIGhhbmdzIGlmCj4gPiB3ZQo+ID4gdHJ5IHRvIHRvdWNoIHRoZSBwaXBlL3Ry YW5zY29kZXIgcmVnaXN0ZXJzIHdpdGhvdXQgaGF2aW5nIHRoZQo+ID4gY2xvY2tzCj4gPiBjb25m aWd1cmVkLgo+ID4gCj4gPiBTbyB0aGlzIHBhdGNoIGNoYW5nZXMgYWxsIHRoZSByZWxldmFudCBw bGF0Zm9ybXMgdG8gY2FsbAo+ID4gaW50ZWxfZGRpX2VuYWJsZV9waXBlX2Nsb2NrIGF0IHRoZSBw b2ludCB3ZSdyZSBzdXBwb3NlZCB0bywKPiA+IGFjY29yZGluZwo+ID4gdG8gdGhlIHNwZWMuCj4g Cj4gSSBkb24ndCB0aGluayB0aGlzIHJlYWxseSBtYXRjaGVzIHRoZSBzcGVjLiBZb3UncmUgbm93 IGVuYWJsaW5nIHRoZQo+IGNsb2NrIGJlZm9yZSBjb25maWd1cmluZyB0aGUgcG9ydCBzdHVmZiBh bmQgbGluayB0cmFpbmluZy4gU28gQUZBSUNTCj4gaW50ZWxfZGRpX2VuYWJsZV9waXBlX2Nsb2Nr KCkgc2VlbXMgdG8gYmUgaW4gdGhlIGNvcnJlY3QgcGxhY2UsIGJ1dAo+IHdlJ3JlIGp1c3QgY29u ZmlndXJpbmcgYWxsIHRoZSBwaXBlL3RyYW5zY29kZXIvZXRjLiBzdHVmZiB3YXkgdG9vCj4gZWFy bHkuCgpZb3UncmUgcmlnaHQsIEkgbWlzc2VkIHRoZSBsaW5rIHRyYWluaW5nIHBhcnQsIGl0IG5l ZWRzIHRvIGNvbWUgYmVmb3JlLgoKQnV0IGFueXdheSwgbW92aW5nIGVuYWJsZV9waXBlX2Nsb2Nr KCkgKyBsaW5rX3RyYWluaW5nICgpdXAgaXMgdGhlIHNhbWUKYXMgbW92aW5nIGFsbCB0aGUgcGlw ZS90cmFuc2NvZGVyL2V0YyBzdHVmZiBkb3duLCB0aGUgb25seSBkaWZmZXJlbmNlCmJlaW5nIHdo ZW4gd2Ugc2V0IGludGVsX2NydGMtPmFjdGl2ZS4gSSdsbCB3cml0ZSBhIHNlY29uZCB2ZXJzaW9u LgoKPiAKPiA+IAo+ID4gSXQgc2VlbXMgdGhlcmUgaXMgYSB3YXkgdG8gd29yayBhcm91bmQgdGhp cyBwcm9ibGVtIG9uIElDTCB3aXRoCj4gPiBzb21lCj4gPiBjaGlja2VuIGJpdCwgYnV0IEkgc3Rp bGwgY291bGRuJ3QgZmluZCB3aGljaCBvbmUgaXQgaXMsIGFuZCBpdCdzCj4gPiBiZXR0ZXIgaWYg d2UganVzdCBkbyB0aGUgcmlnaHQgdGhpbmcgaGVyZS4KCldlIGdvdCB0aGUgaW5mbyB3ZSB3YW50 ZWQgYW5kIG5vdyBrbm93IGhvdyB0byB3b3JrIGFyb3VuZCB0aGUgcHJvYmxlbSwKYnV0IEkgc3Rp bGwgdGhpbmsgd2Ugc2hvdWxkIGdvIGZvciB0aGUgc29sdXRpb24gd2hlcmUgd2UgcHJvZ3JhbSB0 aGUKaGFyZHdhcmUgaW4gdGhlIG9yZGVyIGl0IGV4cGVjdHMgdG8gYmUgcHJvZ3JhbW1lZC4KCk9y IHdlIGNvdWxkIGRvIGJvdGg6IHByb2dyYW0gY29ycmVjdGx5ICphbmQqIGVuYWJsZSB0aGUgY2hp Y2tlbiBiaXRzLgoKVGhhbmtzLApQYXVsbwoKPiA+IAo+ID4gQ2M6IEFydGh1ciBKIFJ1bnlhbiA8 YXJ0aHVyLmoucnVueWFuQGludGVsLmNvbT4KPiA+IENjOiBKYW1lcyBBdXNtdXMgPGphbWVzLmF1 c211c0BpbnRlbC5jb20+Cj4gPiBTaWduZWQtb2ZmLWJ5OiBQYXVsbyBaYW5vbmkgPHBhdWxvLnIu emFub25pQGludGVsLmNvbT4KPiA+IC0tLQo+ID4gIGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVs X2Rpc3BsYXkuYyB8IDggKysrKy0tLS0KPiA+ICAxIGZpbGUgY2hhbmdlZCwgNCBpbnNlcnRpb25z KCspLCA0IGRlbGV0aW9ucygtKQo+ID4gCj4gPiBMdWNraWx5IG91ciBDSSBzeXN0ZW0gc2hvdWxk IGJlIGluIGEgc3BvdCB3aGVyZSBpdCBpcyBhYmxlIHRvIHRlbGwKPiA+IHVzCj4gPiB3aGV0aGVy IHRoaXMgcGF0Y2ggaXMgZ29vZCB3aXRoIGhpZ2ggY29uZmlkZW5jZS4gSSBoYXZlbid0IHRlc3Rl ZAo+ID4gaXQKPiA+IG9uIGV2ZXJ5IGFmZmVjdGVkIHBsYXRmb3JtLgo+ID4gCj4gPiBkaWZmIC0t Z2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZGlzcGxheS5jCj4gPiBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ID4gaW5kZXggNDg1NzZlYTJkMzZjLi5jOTNh ZWQyZWMxNmQgMTAwNjQ0Cj4gPiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9kaXNw bGF5LmMKPiA+ICsrKyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2Rpc3BsYXkuYwo+ID4g QEAgLTU1NzgsOCArNTU3OCwxMSBAQCBzdGF0aWMgdm9pZCBoYXN3ZWxsX2NydGNfZW5hYmxlKHN0 cnVjdAo+ID4gaW50ZWxfY3J0Y19zdGF0ZSAqcGlwZV9jb25maWcsCj4gPiAgCQkJCSAgICAgJmlu dGVsX2NydGMtPmNvbmZpZy0+ZmRpX21fbiwgCj4gPiBOVUxMKTsKPiA+ICAJfQo+ID4gIAo+ID4g LQlpZiAoIXRyYW5zY29kZXJfaXNfZHNpKGNwdV90cmFuc2NvZGVyKSkKPiA+ICsJaWYgKCF0cmFu c2NvZGVyX2lzX2RzaShjcHVfdHJhbnNjb2RlcikpIHsKPiA+ICsJCWludGVsX2RkaV9lbmFibGVf cGlwZV9jbG9jayhwaXBlX2NvbmZpZyk7Cj4gPiArCj4gPiAgCQloYXN3ZWxsX3NldF9waXBlY29u ZihjcnRjKTsKPiA+ICsJfQo+ID4gIAo+ID4gIAloYXN3ZWxsX3NldF9waXBlbWlzYyhjcnRjKTsK PiA+ICAKPiA+IEBAIC01NTg5LDkgKzU1OTIsNiBAQCBzdGF0aWMgdm9pZCBoYXN3ZWxsX2NydGNf ZW5hYmxlKHN0cnVjdAo+ID4gaW50ZWxfY3J0Y19zdGF0ZSAqcGlwZV9jb25maWcsCj4gPiAgCj4g PiAgCWludGVsX2VuY29kZXJzX3ByZV9lbmFibGUoY3J0YywgcGlwZV9jb25maWcsIG9sZF9zdGF0 ZSk7Cj4gPiAgCj4gPiAtCWlmICghdHJhbnNjb2Rlcl9pc19kc2koY3B1X3RyYW5zY29kZXIpKQo+ ID4gLQkJaW50ZWxfZGRpX2VuYWJsZV9waXBlX2Nsb2NrKHBpcGVfY29uZmlnKTsKPiA+IC0KPiA+ ICAJLyogRGlzcGxheSBXQSAjMTE4MDogV2FEaXNhYmxlU2NhbGFyQ2xvY2tHYXRpbmc6IGdsaywg Y25sCj4gPiAqLwo+ID4gIAlwc2xfY2xrZ2F0ZV93YSA9IChJU19HRU1JTklMQUtFKGRldl9wcml2 KSB8fAo+ID4gSVNfQ0FOTk9OTEFLRShkZXZfcHJpdikpICYmCj4gPiAgCQkJIGludGVsX2NydGMt PmNvbmZpZy0+cGNoX3BmaXQuZW5hYmxlZDsKPiA+IC0tIAo+ID4gMi4xNC4zCj4gPiAKPiA+IF9f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCj4gPiBJbnRlbC1n ZnggbWFpbGluZyBsaXN0Cj4gPiBJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCj4gPiBo dHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo+ IAo+IApfX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fXwpJbnRl bC1nZnggbWFpbGluZyBsaXN0CkludGVsLWdmeEBsaXN0cy5mcmVlZGVza3RvcC5vcmcKaHR0cHM6 Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9pbnRlbC1nZngK