From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Spotswood Subject: Re: [PATCH 4/5] drm/i915/icl/huc: Correctly authenticate the HuC for Icelake Date: Fri, 04 May 2018 15:26:18 -0700 Message-ID: <1525472778.3618.13.camel@intel.com> References: <1525287804-2071-1-git-send-email-oscar.mateo@intel.com> <1525287804-2071-5-git-send-email-oscar.mateo@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by gabe.freedesktop.org (Postfix) with ESMTPS id 76DC96E0B2 for ; Fri, 4 May 2018 22:26:20 +0000 (UTC) In-Reply-To: <1525287804-2071-5-git-send-email-oscar.mateo@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Oscar Mateo , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCAyMDE4LTA1LTAyIGF0IDEyOjAzIC0wNzAwLCBPc2NhciBNYXRlbyB3cm90ZToKPiBU aGUgcmVnaXN0ZXIgdG8gY2hlY2sgZm9yIGNvcnJlY3QgSHVDIGF1dGhlbnRpY2F0aW9uIGJ5IHRo ZSBHdUMKPiBoYXMgY2hhbmdlZCBpbiBJY2VsYWtlLiBMb29rIGludG8gdGhlIHJpZ2h0IHJlZ2lz dGVyICYgYml0Lgo+IAo+IHYyOiByZWJhc2VkLgo+IHYzOiByZWJhc2VkLgo+IHY0OiBGaXggSTkx NV9QQVJBTV9IVUNfU1RBVFVTIGFzIHdlbGwgKFRvbnkpCj4gdjU6IEZpeCBkdXBsaWNhdGUgQ2MK PiAKPiBCU3BlYzogMTk2ODYKPiAKPiBTaWduZWQtb2ZmLWJ5OiBPc2NhciBNYXRlbyA8b3NjYXIu bWF0ZW9AaW50ZWwuY29tPgo+IENjOiBUb255IFllIDx0b255LnllQGludGVsLmNvbT4KPiBDYzog VmluYXkgQmVsZ2F1bWthciA8dmluYXkuYmVsZ2F1bWthckBpbnRlbC5jb20+Cj4gQ2M6IE1pY2hl bCBUaGllcnJ5IDxtaWNoZWwudGhpZXJyeUBpbnRlbC5jb20+Cj4gQ2M6IE1pY2hhbCBXYWpkZWN6 a28gPG1pY2hhbC53YWpkZWN6a29AaW50ZWwuY29tPgo+IENjOiBKb2huIFNwb3Rzd29vZCA8am9o bi5hLnNwb3Rzd29vZEBpbnRlbC5jb20+Cj4gQ2M6IEFudXNoYSBTcml2YXRzYSA8YW51c2hhLnNy aXZhdHNhQGludGVsLmNvbT4KPiAtLS0KPiDCoGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1 Y19yZWcuaCB8wqDCoDMgKysrCj4gwqBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9odWMuY8Kg wqDCoMKgwqB8IDIzICsrKysrKysrKysrKysrKysrKystLS0tCj4gwqAyIGZpbGVzIGNoYW5nZWQs IDIyIGluc2VydGlvbnMoKyksIDQgZGVsZXRpb25zKC0pCj4gCj4gZGlmZiAtLWdpdCBhL2RyaXZl cnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Y19yZWcuaAo+IGIvZHJpdmVycy9ncHUvZHJtL2k5MTUv aW50ZWxfZ3VjX3JlZy5oCj4gaW5kZXggZDg2MDg0Ny4uOWYxNGY5ZiAxMDA2NDQKPiAtLS0gYS9k cml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9ndWNfcmVnLmgKPiArKysgYi9kcml2ZXJzL2dwdS9k cm0vaTkxNS9pbnRlbF9ndWNfcmVnLmgKPiBAQCAtNzYsNiArNzYsOSBAQAo+IMKgI2RlZmluZSBI VUNfU1RBVFVTMsKgwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgX01NSU8oMHhEM0IwKQo+IMKgI2Rl ZmluZcKgwqDCoEhVQ19GV19WRVJJRklFRMKgwqDCoMKgwqDCoMKgKDE8PDcpCj4gwqAKPiArI2Rl ZmluZSBIVUNfS0VSTkVMX0xPQURfSU5GTwlfTU1JTygweEMxREMpCj4gKyNkZWZpbmXCoMKgwqBI VUNfTE9BRF9TVUNDRVNTRlVMCSgxIDw8IDApCj4gKwo+IMKgI2RlZmluZSBHVUNfV09QQ01fU0la RQkJCV9NTUlPKDB4YzA1MCkKPiDCoCNkZWZpbmXCoMKgwqBHVUNfV09QQ01fU0laRV9MT0NLRUQJ CcKgwqAoMTw8MCkKPiDCoCNkZWZpbmXCoMKgwqBHVUNfV09QQ01fU0laRV9TSElGVAkJMTIKPiBk aWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfaHVjLmMKPiBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2h1Yy5jCj4gaW5kZXggMjkxMjg1Mi4uYjUwOTc1NiAxMDA2NDQK PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9odWMuYwo+ICsrKyBiL2RyaXZlcnMv Z3B1L2RybS9pOTE1L2ludGVsX2h1Yy5jCj4gQEAgLTQ4LDkgKzQ4LDE5IEBAIGludCBpbnRlbF9o dWNfYXV0aChzdHJ1Y3QgaW50ZWxfaHVjICpodWMpCj4gwqAJc3RydWN0IGRybV9pOTE1X3ByaXZh dGUgKmk5MTUgPSBodWNfdG9faTkxNShodWMpOwo+IMKgCXN0cnVjdCBpbnRlbF9ndWMgKmd1YyA9 ICZpOTE1LT5ndWM7Cj4gwqAJc3RydWN0IGk5MTVfdm1hICp2bWE7Cj4gKwlpOTE1X3JlZ190IHN0 YXR1c19yZWc7Cj4gwqAJdTMyIHN0YXR1czsKPiArCXUzMiBzdGF0dXNfb2s7Cj4gwqAJaW50IHJl dDsKPiDCoAo+ICsJaWYgKElOVEVMX0dFTihpOTE1KSA+PSAxMSkgewo+ICsJCXN0YXR1c19yZWcg PSBIVUNfS0VSTkVMX0xPQURfSU5GTzsKPiArCQlzdGF0dXNfb2sgPSBIVUNfTE9BRF9TVUNDRVNT RlVMOwo+ICsJfSBlbHNlIHsKPiArCQlzdGF0dXNfcmVnID0gSFVDX1NUQVRVUzI7Cj4gKwkJc3Rh dHVzX29rID0gSFVDX0ZXX1ZFUklGSUVEOwo+ICsJfQo+ICsKPiDCoAlpZiAoaHVjLT5mdy5sb2Fk X3N0YXR1cyAhPSBJTlRFTF9VQ19GSVJNV0FSRV9TVUNDRVNTKQo+IMKgCQlyZXR1cm4gLUVOT0VY RUM7Cj4gwqAKPiBAQCAtNzIsOSArODIsOSBAQCBpbnQgaW50ZWxfaHVjX2F1dGgoc3RydWN0IGlu dGVsX2h1YyAqaHVjKQo+IMKgCj4gwqAJLyogQ2hlY2sgYXV0aGVudGljYXRpb24gc3RhdHVzLCBp dCBzaG91bGQgYmUgZG9uZSBieSBub3cgKi8KPiDCoAlyZXQgPSBfX2ludGVsX3dhaXRfZm9yX3Jl Z2lzdGVyKGk5MTUsCj4gLQkJCQkJSFVDX1NUQVRVUzIsCj4gLQkJCQkJSFVDX0ZXX1ZFUklGSUVE LAo+IC0JCQkJCUhVQ19GV19WRVJJRklFRCwKPiArCQkJCQlzdGF0dXNfcmVnLAo+ICsJCQkJCXN0 YXR1c19vaywKPiArCQkJCQlzdGF0dXNfb2ssCj4gwqAJCQkJCTIsIDUwLCAmc3RhdHVzKTsKCk1p bm9yIHF1ZXN0aW9uOiDCoFlvdSBhcmUgY2hlY2tpbmcgZGlmZmVyZW50IHJlZ2lzdGVycyBkZXBl bmRpbmcgb24gZ2VuLgrCoFdpbGwgdGhlIGZhc3QgYW5kIHNsb3cgdGltZW91dCB2YWx1ZXMgYXBw bHkgZXF1YWxseSB0byBib3RoIHNpdHVhdGlvbnMKPwoKPiDCoAlpZiAocmV0KSB7Cj4gwqAJCURS TV9FUlJPUigiSHVDOiBGaXJtd2FyZSBub3QgdmVyaWZpZWQgJSN4XG4iLAo+IHN0YXR1cyk7Cj4g QEAgLTExMiw3ICsxMjIsMTIgQEAgaW50IGludGVsX2h1Y19jaGVja19zdGF0dXMoc3RydWN0IGlu dGVsX2h1Ywo+ICpodWMpCj4gwqAJCXJldHVybiAtRU5PREVWOwo+IMKgCj4gwqAJaW50ZWxfcnVu dGltZV9wbV9nZXQoZGV2X3ByaXYpOwo+IC0Jc3RhdHVzID0gSTkxNV9SRUFEKEhVQ19TVEFUVVMy KSAmIEhVQ19GV19WRVJJRklFRDsKPiArCj4gKwlpZiAoSU5URUxfR0VOKGRldl9wcml2KSA+PSAx MSkKPiArCQlzdGF0dXMgPSBJOTE1X1JFQUQoSFVDX0tFUk5FTF9MT0FEX0lORk8pICYKPiBIVUNf TE9BRF9TVUNDRVNTRlVMOwo+ICsJZWxzZQo+ICsJCXN0YXR1cyA9IEk5MTVfUkVBRChIVUNfU1RB VFVTMikgJiBIVUNfRldfVkVSSUZJRUQ7Cj4gKwo+IMKgCWludGVsX3J1bnRpbWVfcG1fcHV0KGRl dl9wcml2KTsKPiDCoAo+IMKgCXJldHVybiBzdGF0dXM7Cl9fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50ZWwtZ2Z4 QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9yZy9tYWls bWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=