From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx2.suse.de ([195.135.220.15]:56772 "EHLO mx2.suse.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1754208AbeEHJPz (ORCPT ); Tue, 8 May 2018 05:15:55 -0400 Message-ID: <1525770559.24345.10.camel@suse.com> Subject: Re: [PATCH v3 1/2] usb: misc: xapea00x: add driver for Xaptum ENF Access Card From: Oliver Neukum To: "David R. Bild" Cc: Peter Huewe , Jarkko Sakkinen , Greg Kroah-Hartman , linux-integrity@vger.kernel.org, linux-usb@vger.kernel.org Date: Tue, 08 May 2018 11:09:19 +0200 In-Reply-To: References: <20180504130022.5231-1-david.bild@xaptum.com> <20180504130022.5231-2-david.bild@xaptum.com> <1525687128.24345.3.camel@suse.com> Content-Type: text/plain; charset="UTF-8" Mime-Version: 1.0 Sender: linux-integrity-owner@vger.kernel.org List-ID: Am Montag, den 07.05.2018, 08:31 -0500 schrieb David R. Bild : > > > + spi_master->flags = 0; > > > + spi_master->setup = xapea00x_spi_setup; > > > + spi_master->transfer_one_message = xapea00x_spi_transfer_one_message; > > > + > > > + retval = spi_register_master(spi_master); > > > + > > > + if (retval) > > > + goto free_spi; > > > + > > > + dev->spi_master = spi_master; > > > > Race condition. > > > > What race condition do you see? (I appreciate the review, but need > some more specific help here.) Hi, you have registered the master. So it is functional, but if any callback goes for dev->spi_master at that point, it will read an incorrect value. HTH Oliver From mboxrd@z Thu Jan 1 00:00:00 1970 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Subject: [v3,1/2] usb: misc: xapea00x: add driver for Xaptum ENF Access Card From: Oliver Neukum Message-Id: <1525770559.24345.10.camel@suse.com> Date: Tue, 08 May 2018 11:09:19 +0200 To: "David R. Bild" Cc: Peter Huewe , Jarkko Sakkinen , Greg Kroah-Hartman , linux-integrity@vger.kernel.org, linux-usb@vger.kernel.org List-ID: QW0gTW9udGFnLCBkZW4gMDcuMDUuMjAxOCwgMDg6MzEgLTA1MDAgc2NocmllYiAgRGF2aWQgUi4g QmlsZCA6Cj4gPiA+ICvCoMKgwqDCoCBzcGlfbWFzdGVyLT5mbGFncyA9IDA7Cj4gPiA+ICvCoMKg wqDCoCBzcGlfbWFzdGVyLT5zZXR1cCA9IHhhcGVhMDB4X3NwaV9zZXR1cDsKPiA+ID4gK8KgwqDC oMKgIHNwaV9tYXN0ZXItPnRyYW5zZmVyX29uZV9tZXNzYWdlID0geGFwZWEwMHhfc3BpX3RyYW5z ZmVyX29uZV9tZXNzYWdlOwo+ID4gPiArCj4gPiA+ICvCoMKgwqDCoCByZXR2YWwgPSBzcGlfcmVn aXN0ZXJfbWFzdGVyKHNwaV9tYXN0ZXIpOwo+ID4gPiArCj4gPiA+ICvCoMKgwqDCoCBpZiAocmV0 dmFsKQo+ID4gPiArwqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgIGdvdG8gZnJlZV9zcGk7Cj4gPiA+ ICsKPiA+ID4gK8KgwqDCoMKgIGRldi0+c3BpX21hc3RlciA9IHNwaV9tYXN0ZXI7Cj4gPiAKPiA+ IFJhY2UgY29uZGl0aW9uLgo+ID4gCj4gCj4gV2hhdCByYWNlIGNvbmRpdGlvbiBkbyB5b3Ugc2Vl P8KgIChJIGFwcHJlY2lhdGUgdGhlIHJldmlldywgYnV0IG5lZWQKPiBzb21lIG1vcmUgc3BlY2lm aWMgaGVscCBoZXJlLikKCkhpLAoKeW91IGhhdmUgcmVnaXN0ZXJlZCB0aGUgbWFzdGVyLiBTbyBp dCBpcyBmdW5jdGlvbmFsLCBidXQgaWYgYW55CmNhbGxiYWNrIGdvZXMgZm9yIGRldi0+c3BpX21h c3RlciBhdCB0aGF0IHBvaW50LCBpdCB3aWxsIHJlYWQgYW4KaW5jb3JyZWN0IHZhbHVlLgoKCUhU SAoJCU9saXZlcgotLS0KVG8gdW5zdWJzY3JpYmUgZnJvbSB0aGlzIGxpc3Q6IHNlbmQgdGhlIGxp bmUgInVuc3Vic2NyaWJlIGxpbnV4LXVzYiIgaW4KdGhlIGJvZHkgb2YgYSBtZXNzYWdlIHRvIG1h am9yZG9tb0B2Z2VyLmtlcm5lbC5vcmcKTW9yZSBtYWpvcmRvbW8gaW5mbyBhdCAgaHR0cDovL3Zn ZXIua2VybmVsLm9yZy9tYWpvcmRvbW8taW5mby5odG1sCg==