From mboxrd@z Thu Jan 1 00:00:00 1970 From: John Spotswood Subject: Re: [PATCH 4/5] drm/i915/icl/huc: Correctly authenticate the HuC for Icelake Date: Tue, 08 May 2018 16:22:54 -0700 Message-ID: <1525821774.3618.17.camel@intel.com> References: <1525287804-2071-1-git-send-email-oscar.mateo@intel.com> <1525287804-2071-5-git-send-email-oscar.mateo@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by gabe.freedesktop.org (Postfix) with ESMTPS id 7F14B6EBD9 for ; Tue, 8 May 2018 23:22:54 +0000 (UTC) In-Reply-To: <1525287804-2071-5-git-send-email-oscar.mateo@intel.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Oscar Mateo , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org T24gV2VkLCAyMDE4LTA1LTAyIGF0IDEyOjAzIC0wNzAwLCBPc2NhciBNYXRlbyB3cm90ZToKPiBU aGUgcmVnaXN0ZXIgdG8gY2hlY2sgZm9yIGNvcnJlY3QgSHVDIGF1dGhlbnRpY2F0aW9uIGJ5IHRo ZSBHdUMKPiBoYXMgY2hhbmdlZCBpbiBJY2VsYWtlLiBMb29rIGludG8gdGhlIHJpZ2h0IHJlZ2lz dGVyICYgYml0Lgo+IAo+IHYyOiByZWJhc2VkLgo+IHYzOiByZWJhc2VkLgo+IHY0OiBGaXggSTkx NV9QQVJBTV9IVUNfU1RBVFVTIGFzIHdlbGwgKFRvbnkpCj4gdjU6IEZpeCBkdXBsaWNhdGUgQ2MK PiAKPiBCU3BlYzogMTk2ODYKPiAKPiBTaWduZWQtb2ZmLWJ5OiBPc2NhciBNYXRlbyA8b3NjYXIu bWF0ZW9AaW50ZWwuY29tPgo+IENjOiBUb255IFllIDx0b255LnllQGludGVsLmNvbT4KPiBDYzog VmluYXkgQmVsZ2F1bWthciA8dmluYXkuYmVsZ2F1bWthckBpbnRlbC5jb20+Cj4gQ2M6IE1pY2hl bCBUaGllcnJ5IDxtaWNoZWwudGhpZXJyeUBpbnRlbC5jb20+Cj4gQ2M6IE1pY2hhbCBXYWpkZWN6 a28gPG1pY2hhbC53YWpkZWN6a29AaW50ZWwuY29tPgo+IENjOiBKb2huIFNwb3Rzd29vZCA8am9o bi5hLnNwb3Rzd29vZEBpbnRlbC5jb20+CgpSZXZpZXdlZC1ieTogSm9obiBTcG90c3dvb2QgPGpv aG4uYS5zcG90c3dvb2RAaW50ZWwuY29tPgoKPiBDYzogQW51c2hhIFNyaXZhdHNhIDxhbnVzaGEu c3JpdmF0c2FAaW50ZWwuY29tPgo+IC0tLQo+IMKgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxf Z3VjX3JlZy5oIHzCoMKgMyArKysKPiDCoGRyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2h1Yy5j wqDCoMKgwqDCoHwgMjMgKysrKysrKysrKysrKysrKysrKy0tLS0KPiDCoDIgZmlsZXMgY2hhbmdl ZCwgMjIgaW5zZXJ0aW9ucygrKSwgNCBkZWxldGlvbnMoLSkKPiAKPiBkaWZmIC0tZ2l0IGEvZHJp dmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZ3VjX3JlZy5oCj4gYi9kcml2ZXJzL2dwdS9kcm0vaTkx NS9pbnRlbF9ndWNfcmVnLmgKPiBpbmRleCBkODYwODQ3Li45ZjE0ZjlmIDEwMDY0NAo+IC0tLSBh L2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2d1Y19yZWcuaAo+ICsrKyBiL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX2d1Y19yZWcuaAo+IEBAIC03Niw2ICs3Niw5IEBACj4gwqAjZGVmaW5l IEhVQ19TVEFUVVMywqDCoMKgwqDCoMKgwqDCoMKgwqDCoMKgwqBfTU1JTygweEQzQjApCj4gwqAj ZGVmaW5lwqDCoMKgSFVDX0ZXX1ZFUklGSUVEwqDCoMKgwqDCoMKgwqAoMTw8NykKPiDCoAo+ICsj ZGVmaW5lIEhVQ19LRVJORUxfTE9BRF9JTkZPCV9NTUlPKDB4QzFEQykKPiArI2RlZmluZcKgwqDC oEhVQ19MT0FEX1NVQ0NFU1NGVUwJKDEgPDwgMCkKPiArCj4gwqAjZGVmaW5lIEdVQ19XT1BDTV9T SVpFCQkJX01NSU8oMHhjMDUwKQo+IMKgI2RlZmluZcKgwqDCoEdVQ19XT1BDTV9TSVpFX0xPQ0tF RAkJwqDCoCgxPDwwKQo+IMKgI2RlZmluZcKgwqDCoEdVQ19XT1BDTV9TSVpFX1NISUZUCQkxMgo+ IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRlbF9odWMuYwo+IGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfaHVjLmMKPiBpbmRleCAyOTEyODUyLi5iNTA5NzU2IDEwMDY0 NAo+IC0tLSBhL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX2h1Yy5jCj4gKysrIGIvZHJpdmVy cy9ncHUvZHJtL2k5MTUvaW50ZWxfaHVjLmMKPiBAQCAtNDgsOSArNDgsMTkgQEAgaW50IGludGVs X2h1Y19hdXRoKHN0cnVjdCBpbnRlbF9odWMgKmh1YykKPiDCoAlzdHJ1Y3QgZHJtX2k5MTVfcHJp dmF0ZSAqaTkxNSA9IGh1Y190b19pOTE1KGh1Yyk7Cj4gwqAJc3RydWN0IGludGVsX2d1YyAqZ3Vj ID0gJmk5MTUtPmd1YzsKPiDCoAlzdHJ1Y3QgaTkxNV92bWEgKnZtYTsKPiArCWk5MTVfcmVnX3Qg c3RhdHVzX3JlZzsKPiDCoAl1MzIgc3RhdHVzOwo+ICsJdTMyIHN0YXR1c19vazsKPiDCoAlpbnQg cmV0Owo+IMKgCj4gKwlpZiAoSU5URUxfR0VOKGk5MTUpID49IDExKSB7Cj4gKwkJc3RhdHVzX3Jl ZyA9IEhVQ19LRVJORUxfTE9BRF9JTkZPOwo+ICsJCXN0YXR1c19vayA9IEhVQ19MT0FEX1NVQ0NF U1NGVUw7Cj4gKwl9IGVsc2Ugewo+ICsJCXN0YXR1c19yZWcgPSBIVUNfU1RBVFVTMjsKPiArCQlz dGF0dXNfb2sgPSBIVUNfRldfVkVSSUZJRUQ7Cj4gKwl9Cj4gKwo+IMKgCWlmIChodWMtPmZ3Lmxv YWRfc3RhdHVzICE9IElOVEVMX1VDX0ZJUk1XQVJFX1NVQ0NFU1MpCj4gwqAJCXJldHVybiAtRU5P RVhFQzsKPiDCoAo+IEBAIC03Miw5ICs4Miw5IEBAIGludCBpbnRlbF9odWNfYXV0aChzdHJ1Y3Qg aW50ZWxfaHVjICpodWMpCj4gwqAKPiDCoAkvKiBDaGVjayBhdXRoZW50aWNhdGlvbiBzdGF0dXMs IGl0IHNob3VsZCBiZSBkb25lIGJ5IG5vdyAqLwo+IMKgCXJldCA9IF9faW50ZWxfd2FpdF9mb3Jf cmVnaXN0ZXIoaTkxNSwKPiAtCQkJCQlIVUNfU1RBVFVTMiwKPiAtCQkJCQlIVUNfRldfVkVSSUZJ RUQsCj4gLQkJCQkJSFVDX0ZXX1ZFUklGSUVELAo+ICsJCQkJCXN0YXR1c19yZWcsCj4gKwkJCQkJ c3RhdHVzX29rLAo+ICsJCQkJCXN0YXR1c19vaywKPiDCoAkJCQkJMiwgNTAsICZzdGF0dXMpOwo+ IMKgCWlmIChyZXQpIHsKPiDCoAkJRFJNX0VSUk9SKCJIdUM6IEZpcm13YXJlIG5vdCB2ZXJpZmll ZCAlI3hcbiIsCj4gc3RhdHVzKTsKPiBAQCAtMTEyLDcgKzEyMiwxMiBAQCBpbnQgaW50ZWxfaHVj X2NoZWNrX3N0YXR1cyhzdHJ1Y3QgaW50ZWxfaHVjCj4gKmh1YykKPiDCoAkJcmV0dXJuIC1FTk9E RVY7Cj4gwqAKPiDCoAlpbnRlbF9ydW50aW1lX3BtX2dldChkZXZfcHJpdik7Cj4gLQlzdGF0dXMg PSBJOTE1X1JFQUQoSFVDX1NUQVRVUzIpICYgSFVDX0ZXX1ZFUklGSUVEOwo+ICsKPiArCWlmIChJ TlRFTF9HRU4oZGV2X3ByaXYpID49IDExKQo+ICsJCXN0YXR1cyA9IEk5MTVfUkVBRChIVUNfS0VS TkVMX0xPQURfSU5GTykgJgo+IEhVQ19MT0FEX1NVQ0NFU1NGVUw7Cj4gKwllbHNlCj4gKwkJc3Rh dHVzID0gSTkxNV9SRUFEKEhVQ19TVEFUVVMyKSAmIEhVQ19GV19WRVJJRklFRDsKPiArCj4gwqAJ aW50ZWxfcnVudGltZV9wbV9wdXQoZGV2X3ByaXYpOwo+IMKgCj4gwqAJcmV0dXJuIHN0YXR1czsK X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KSW50ZWwtZ2Z4 IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vaW50ZWwtZ2Z4Cg==