All of lore.kernel.org
 help / color / mirror / Atom feed
From: "Mkrtchyan, Tigran" <tigran.mkrtchyan@desy.de>
To: Frank van der Linden <fllinden@amazon.com>
Cc: Olga Kornievskaia <aglo@umich.edu>,
	linux-nfs <linux-nfs@vger.kernel.org>,
	trondmy <trondmy@hammerspace.com>
Subject: Re: Kernel OPS when using xattr
Date: Thu, 3 Dec 2020 17:57:11 +0100 (CET)	[thread overview]
Message-ID: <1525949722.2059532.1607014631422.JavaMail.zimbra@desy.de> (raw)
In-Reply-To: <1661972531.2055379.1607013492207.JavaMail.zimbra@desy.de>

Frank's v2 works as well. 

Tigran.

----- Original Message -----
> From: "Tigran Mkrtchyan" <tigran.mkrtchyan@desy.de>
> To: "Frank van der Linden" <fllinden@amazon.com>
> Cc: "Olga Kornievskaia" <aglo@umich.edu>, "linux-nfs" <linux-nfs@vger.kernel.org>, "trondmy" <trondmy@hammerspace.com>
> Sent: Thursday, 3 December, 2020 17:38:12
> Subject: Re: Kernel OPS when using xattr

> Oh. I tested V1.... Let me check v2 as well.
> 
> Tigran.
> 
> ----- Original Message -----
>> From: "Tigran Mkrtchyan" <tigran.mkrtchyan@desy.de>
>> To: "Frank van der Linden" <fllinden@amazon.com>
>> Cc: "Olga Kornievskaia" <aglo@umich.edu>, "linux-nfs"
>> <linux-nfs@vger.kernel.org>, "trondmy" <trondmy@hammerspace.com>
>> Sent: Thursday, 3 December, 2020 17:36:07
>> Subject: Re: Kernel OPS when using xattr
> 
>> The patch from Frank works.
>> ( you can attribute with Tested-by if needed)
>> 
>> Tigran.
>> 
>> ----- Original Message -----
>>> From: "Frank van der Linden" <fllinden@amazon.com>
>>> To: "Tigran Mkrtchyan" <tigran.mkrtchyan@desy.de>
>>> Cc: "Olga Kornievskaia" <aglo@umich.edu>, "linux-nfs"
>>> <linux-nfs@vger.kernel.org>, "trondmy" <trondmy@hammerspace.com>
>>> Sent: Thursday, 3 December, 2020 17:18:58
>>> Subject: Re: Kernel OPS when using xattr
>> 
>>> On Thu, Dec 03, 2020 at 04:43:12PM +0100, Mkrtchyan, Tigran wrote:
>>>> 
>>>> Hi Olga,
>>>> 
>>>> Franks patches are not applied. I will check with Trond's patch and
>>>> then will try those as well.
>>>> 
>>>> Regards,
>>>>    Tigran.
>>> 
>>> Since my change no longer uses SPARSE_PAGES, it'll probably avoid the
>>> oops, so give it a try.
>>> 
>>> Having said that, fixing SPARSE_PAGES seems like a better option.. My
>>> ideal outcome would be to have a working SPARSE_PAGES for all transports.
>>> That would allow GETXATTR and LISTXATTRS to just always specify a max
>>> size array of pages, giving it maximum flexibility to cache the received
>>> result no matter what, and avoiding allocations that are too large.
>>> 
>>> For now, though, I'm happy with the v2 patch I sent in.
>>> 
> > > - Frank

  reply	other threads:[~2020-12-03 16:57 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-12-03  8:20 Kernel OPS when using xattr Mkrtchyan, Tigran
2020-12-03 14:07 ` Olga Kornievskaia
2020-12-03 15:43   ` Mkrtchyan, Tigran
2020-12-03 16:18     ` Frank van der Linden
2020-12-03 16:36       ` Mkrtchyan, Tigran
2020-12-03 16:38         ` Mkrtchyan, Tigran
2020-12-03 16:57           ` Mkrtchyan, Tigran [this message]
2020-12-03 16:59       ` Chuck Lever
2020-12-03 15:07 ` Trond Myklebust
2020-12-03 16:04   ` Mkrtchyan, Tigran
2020-12-03 17:13     ` Trond Myklebust
2020-12-03 17:47       ` Frank van der Linden
2020-12-03 18:23         ` Trond Myklebust
2020-12-03 18:25           ` Frank van der Linden
2020-12-03 17:49       ` Mkrtchyan, Tigran

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1525949722.2059532.1607014631422.JavaMail.zimbra@desy.de \
    --to=tigran.mkrtchyan@desy.de \
    --cc=aglo@umich.edu \
    --cc=fllinden@amazon.com \
    --cc=linux-nfs@vger.kernel.org \
    --cc=trondmy@hammerspace.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.