From mboxrd@z Thu Jan 1 00:00:00 1970 From: Mike Galbraith Subject: Re: kernel spew from nouveau/ swiotlb Date: Thu, 10 May 2018 17:31:20 +0200 Message-ID: <1525966280.5207.1.camel@gmx.de> References: <1525943427.8013.11.camel@gmx.de> <474293973.18773550.1525962696189.JavaMail.zimbra@redhat.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <474293973.18773550.1525962696189.JavaMail.zimbra-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: nouveau-bounces-PD4FTy7X32lNgt0PjOBp9y5qC8QIuHrW@public.gmane.org Sender: "Nouveau" To: Jerome Glisse Cc: nouveau , LKML , Ben Skeggs List-Id: nouveau.vger.kernel.org T24gVGh1LCAyMDE4LTA1LTEwIGF0IDEwOjMxIC0wNDAwLCBKZXJvbWUgR2xpc3NlIHdyb3RlOgo+ IAo+IENvdWxkIHlvdSBiaXNlY3QgPyBJIHdvdWxkIGxvdmUgdG8gcG9pbnQgZmluZ2VyIHVwc3Ry ZWFtIHRvIHRoZSBETUEKPiBmb2xrIHdobyBtYWRlIGNoYW5nZXMgdG8gdGhhdCBBUEkgd2l0aG91 dCB0ZXN0aW5nIHdpdGggR1BVLgoKUnVtbWFnaW5nIGEgYml0LCBpdCBtaWdodCBiZS4uLgoKbm91 dmVhdV9ib19uZXcoKQouLi4KdHRtX2RtYV9wb29sX2FsbG9jX25ld19wYWdlcygpCiAgZG1hX2Fs bG9jX2F0dHJzKCkKICAgIG9wcy0+YWxsb2MoKSA9PSB4ODZfc3dpb3RsYl9hbGxvY19jb2hlcmVu dCgpCiAgICB4ODZfc3dpb3RsYl9hbGxvY19jb2hlcmVudCgpIGZsYWdzIHw9IF9fR0ZQX05PV0FS TjsKICAgICAgc3dpb3RsYl9hbGxvY19jb2hlcmVudCguLmZsYWdzKQogICAgICAgIHN3aW90bGJf YWxsb2NfY29oZXJlbnQoLi5mbGFncykgYXR0cnMgPSAoZmxhZ3MgJiBfX0dGUF9OT1dBUk4pID8g RE1BX0FUVFJfTk9fV0FSTiA6IDA7CiAgICAgICAgICBzd2lvdGxiX2FsbG9jX2J1ZmZlciguLmF0 dHIpCiAgICAgICAgICAgIHN3aW90bGJfYWxsb2NfYnVmZmVyKC4uMCkgIDw9PSBobSwgcGFzcyB6 ZXJvIGluc3RlYWQgb2YgYXR0cj8KICAgICAgICAgICAgICBzd2lvdGxiX3RibF9tYXBfc2luZ2xl KCkgZ3JpcGVhZ2UKCi4uLnRoYXQ/CgoJLU1pa2UKX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX18KTm91dmVhdSBtYWlsaW5nIGxpc3QKTm91dmVhdUBsaXN0cy5m cmVlZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0 aW5mby9ub3V2ZWF1Cg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966255AbeEJPbb (ORCPT ); Thu, 10 May 2018 11:31:31 -0400 Received: from mout.gmx.net ([212.227.17.20]:60725 "EHLO mout.gmx.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965949AbeEJPba (ORCPT ); Thu, 10 May 2018 11:31:30 -0400 Message-ID: <1525966280.5207.1.camel@gmx.de> Subject: Re: [Nouveau] kernel spew from nouveau/ swiotlb From: Mike Galbraith To: Jerome Glisse Cc: nouveau , LKML , Ben Skeggs Date: Thu, 10 May 2018 17:31:20 +0200 In-Reply-To: <474293973.18773550.1525962696189.JavaMail.zimbra@redhat.com> References: <1525943427.8013.11.camel@gmx.de> <474293973.18773550.1525962696189.JavaMail.zimbra@redhat.com> Content-Type: text/plain; charset="ISO-8859-15" X-Mailer: Evolution 3.22.6 Mime-Version: 1.0 Content-Transfer-Encoding: 7bit X-Provags-ID: V03:K1:C+Ij9P9MY4CL5UtO2rhBkWI9ofSiW+3dWeKDnCLJFb8kjwuzNp2 GTHoAZnpHW4ViTgZv5rt9CVu8+7rDPz43QacoDOu8wZ1RWhrRTVXeEsvn8q9nKjkRWfAt51 1kOJDNDv1DREY+F82eYw3mrAEFZArv06sqMO+RhNlDVS9UzEqe8H8iE2T5m4DNzRK6kweoC WK13ifQ3YfZwKhJMpxBSA== X-UI-Out-Filterresults: notjunk:1;V01:K0:uktDvysgenY=:21gnMcQfnGlevP+7RAhBFF Y06mWnOfAL5tW1JuaNXxduakeXhq9KpFE2bwp0+VODENxZJIV2jOxXf09b7W+Fnl8VN6VV50N aPjjvofVkVLBp86VZYfO+oijaqA9O6EAZEY69hSsjxnAbrFqs9jQivoPCkbKXG81JHEaQl0G4 6HPtf1N4OZKqYEe1kZ6u3UduWHyiAknVHBIOgR7MEhCuP15Cd4Gy1hieWalr5dbZ3nz7k2ESB h6IK9vXMB8QoRTzvyazV3/TM3W7CpV1v1ObUu94LETnMOqlApLSJZNVv9lvxfiW5FCmxXiVKG jbltMcQn0b50eQfCanBdYP+SfEVoNe9Jut/qiCPgzWT3KRYel8tS/WdzBw8FvBYjgwbFT/CVR IzdHzmJG9zGaG/7YMdHNM9zbF+5Q9RAjaVG5Ylju+ZTM/S4Q8kEgZ2a1+FwKSw6lQURWG0Sqb bsYbnaupnWdd8nvcMGjWNOm7Gf8Nb0KHqH2JvoeNdqDJZq3FtJTepHh99o4LfB4N6ocVGHSls bzmwANl2LUwmrVpIe2zgjq5+QnjnvoUsUQj6FMAAE/HdraybW9A7GFUXZepsC1gtlqpJg2hCG GoSZ/WbP7bO6k93SquEdqp9O6MtV/uGWrqj4J53MqtMYZVea69g7ooscL4F1KZdh1S7I/QEEL /ZVJHrlfRVdJd4z6divLgK9LdNtaAvotGpDY3kRWbfxIIayVgu8seV6QTW1DWg9t2IbpL3DNf QugpXIhiDgFvyVuQdzZw8+CB8RIJLAk58Tuk8LUMJmPE8Sw9KSJSwjvOVJwq6SsamLXHK6zIc nVuAsra Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, 2018-05-10 at 10:31 -0400, Jerome Glisse wrote: > > Could you bisect ? I would love to point finger upstream to the DMA > folk who made changes to that API without testing with GPU. Rummaging a bit, it might be... nouveau_bo_new() ... ttm_dma_pool_alloc_new_pages() dma_alloc_attrs() ops->alloc() == x86_swiotlb_alloc_coherent() x86_swiotlb_alloc_coherent() flags |= __GFP_NOWARN; swiotlb_alloc_coherent(..flags) swiotlb_alloc_coherent(..flags) attrs = (flags & __GFP_NOWARN) ? DMA_ATTR_NO_WARN : 0; swiotlb_alloc_buffer(..attr) swiotlb_alloc_buffer(..0) <== hm, pass zero instead of attr? swiotlb_tbl_map_single() gripeage ...that? -Mike